Linters/rubocop

Author: MerciMax

.rubocop.yml

@@ -4,7 +4,11 @@ plugins: rubocop-rspec
 
 AllCops:
   NewCops: enable
+  SuggestExtensions: false
 
+Gemspec/DevelopmentDependencies:
+  Enabled: false
+  
 Layout/LineLength:
   Enabled: false
 
@@ -23,9 +27,16 @@ Metrics/MethodLength:
 Metrics/PerceivedComplexity:
   Enabled: false
 
+Metrics/ClassLength:
+  Enabled: false
+
 Style/Documentation:
   Enabled: false
 
+Style/RaiseArgs:
+  EnforcedStyle: compact
+
+
 RSpec/DescribeSymbol:
   Enabled: false
 
@@ -35,5 +46,50 @@ RSpec/MultipleExpectations:
 RSpec/LeakyConstantDeclaration:
   Enabled: false
 
+RSpec/ExampleLength:
+  Enabled: false
+
+RSpec/NamedSubject:
+  Enabled: false
+
+RSpec/SpecFilePathFormat:
+  Enabled: false
+
+RSpec/NestedGroups:
+  Max: 9
+
+RSpec/DescribedClass:
+  Enabled: false
+
+RSpec/DescribeClass:
+  Enabled: false
+
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
+RSpec/RepeatedDescription:
+  Enabled: false
+
+RSpec/BeEq:
+  Enabled: false
+
+RSpec/MultipleDescribes:
+  Enabled: false
+
+RSpec/ExpectActual:
+  Enabled: false
+
 Lint/ConstantDefinitionInBlock:
+  Enabled: false
+
+Lint/SuppressedException:
+  Enabled: false
+
+Lint/SuppressedExceptionInNumberConversion:
+  Enabled: false
+
+Style/FormatStringToken:
+  Enabled: false
+
+Style/SpecialGlobalVars:
   Enabled: false

CONTRIBUTING.md

@@ -3,36 +3,35 @@ We love pull requests. Here's a quick guide:
 1. Fork the repo.
 
 2. Run the tests. We only take pull requests with passing tests, and it's great
-to know that you have a clean slate: `bundle && rake`
+   to know that you have a clean slate: `bundle && rake`
 
 3. Add a test for your change. Only refactoring and documentation changes
-require no new tests. If you are adding functionality or fixing a bug, we need
-a test!
+   require no new tests. If you are adding functionality or fixing a bug, we need
+   a test!
 
 4. Make the test pass.
 
 5. Push to your fork and submit a pull request.
 
-
 At this point you're waiting on us. We like to at least comment on, if not
 accept, pull requests within three business days (and, typically, one business
 day). We may suggest some changes or improvements or alternatives.
 
 Some things that will increase the chance that your pull request is accepted,
 taken straight from the Ruby on Rails guide:
 
-* Use Rails idioms and helpers
-* Include tests that fail without your code, and pass with it
-* Update the documentation, the surrounding one, examples elsewhere, guides,
+- Use Rails idioms and helpers
+- Include tests that fail without your code, and pass with it
+- Update the documentation, the surrounding one, examples elsewhere, guides,
   whatever is affected by your contribution
 
 Syntax:
 
-* Two spaces, no tabs.
-* No trailing whitespace. Blank lines should not have any space.
-* Prefer &&/|| over and/or.
-* MyClass.my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
-* a = b and not a=b.
-* Follow the conventions you see used in the source already.
+- Two spaces, no tabs.
+- No trailing whitespace. Blank lines should not have any space.
+- Prefer &&/|| over and/or.
+- MyClass.my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
+- a = b and not a=b.
+- Follow the conventions you see used in the source already.
 
 And in case we didn't emphasize it enough: we love tests!

Gemfile

@@ -1,5 +1,21 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 gemspec
 
-gem 'license_finder', group: :development
-gem 'rubocop'
+group :development do
+  gem 'coveralls_reborn', require: false
+
+  # License
+  gem 'license_finder', require: false
+
+  # Testing
+  gem 'rspec'
+
+  # Linting
+  gem 'ruboclean', require: false
+  gem 'rubocop', require: false
+  gem 'rubocop-rspec', require: false
+
+  gem 'simplecov', require: false
+end

README.md

@@ -7,30 +7,26 @@
 
 We love building payment applications! So after developing the [DTAUS library for Ruby](https://github.com/salesking/king_dtaus) we move on with SEPA.
 
-
 ## Features
 
 This gem implements the following two messages out of the ISO 20022 standard:
 
-* Credit Transfer Initiation (`pain.001.003.03`, `pain.001.002.03` and `pain.001.001.03`)
-* Direct Debit Initiation (`pain.008.003.02`, `pain.008.002.02` and `pain.008.001.02`)
+- Credit Transfer Initiation (`pain.001.003.03`, `pain.001.002.03` and `pain.001.001.03`)
+- Direct Debit Initiation (`pain.008.003.02`, `pain.008.002.02` and `pain.008.001.02`)
 
 It handles the _Specification of Data Formats_ v3.3 (2019-11-17).
 
 BTW: **pain** is a shortcut for **Pa**yment **In**itiation.
 
-
 ## Requirements
 
-* Ruby 2.7 or newer
-* ActiveModel 4.2 or newer (including 7.0)
-
+- Ruby 2.7 or newer
+- ActiveModel 4.2 or newer (including 7.0)
 
 ## Installation
 
     gem install sepa_king
 
-
 ## Usage
 
 How to create the XML for **Direct Debit Initiation** (in German: "Lastschriften")
@@ -149,7 +145,6 @@ xml_string = sdd.to_xml                    # Use schema pain.008.001.02
 xml_string = sdd.to_xml('pain.008.002.02') # Use schema pain.008.002.02
 ```
 
-
 How to create the XML for **Credit Transfer Initiation** (in German: "Überweisungen")
 
 ```ruby
@@ -269,25 +264,22 @@ end
 **Beware:** The SEPA::IBANValidator is strict - e.g. it does not allow any spaces in the IBAN.
 
 Also see:
-* [lib/sepa_king/validator.rb](https://github.com/salesking/sepa_king/blob/master/lib/sepa_king/validator.rb)
-* [lib/sepa_king/transaction/direct_debit_transaction.rb](https://github.com/salesking/sepa_king/blob/master/lib/sepa_king/transaction/direct_debit_transaction.rb)
 
+- [lib/sepa_king/validator.rb](https://github.com/salesking/sepa_king/blob/master/lib/sepa_king/validator.rb)
+- [lib/sepa_king/transaction/direct_debit_transaction.rb](https://github.com/salesking/sepa_king/blob/master/lib/sepa_king/transaction/direct_debit_transaction.rb)
 
 ## Changelog
 
 https://github.com/salesking/sepa_king/releases
 
-
 ## Contributors
 
 https://github.com/salesking/sepa_king/graphs/contributors
 
-
 ## Resources
 
-* https://www.ebics.de/de/datenformate
-* SalesKing: http://salesking.eu
-
+- https://www.ebics.de/de/datenformate
+- SalesKing: http://salesking.eu
 
 ## License
 

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 

lib/schema/pain.001.001.03.ch.02.xsd

@@ -1209,4 +1209,4 @@ History
 		</xs:restriction>
 	</xs:simpleType>
     -->
-</xs:schema>
+</xs:schema>

lib/schema/pain.001.001.03.xsd

@@ -918,4 +918,4 @@
             <xs:enumeration value="HLF2"/>
         </xs:restriction>
     </xs:simpleType>
-</xs:schema>
+</xs:schema>

lib/sepa_king.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_model'
 require 'bigdecimal'
 require 'nokogiri'

lib/sepa_king/account.rb

@@ -1,14 +1,16 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 module SEPA
   class Account
     include ActiveModel::Validations
     extend Converter
 
     attr_accessor :name, :iban, :bic
+
     convert :name, to: :text
 
     validates_length_of :name, within: 1..70
-    validates_with BICValidator, IBANValidator, message: "%{value} is invalid"
+    validates_with BICValidator, IBANValidator, message: '%{value} is invalid'
 
     def initialize(attributes = {})
       attributes.each do |name, value|

lib/sepa_king/account/creditor_account.rb

@@ -1,8 +1,9 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 module SEPA
   class CreditorAccount < Account
     attr_accessor :creditor_identifier
 
-    validates_with CreditorIdentifierValidator, message: "%{value} is invalid"
+    validates_with CreditorIdentifierValidator, message: '%{value} is invalid'
   end
 end