sto codice fa :shit:

[andrew-ld]

mancanza di uso delle env var

Cloudflare-DDNS.php/cloudflare-ddns.php

Lines 3 to 8 in 49a41d2

	define('CLOUDFLARE_API_KEY', 'Your cloudflare api key');
	define('CLOUDFLARE_EMAIL', 'Your cloudflare email');
	define('DOMAIN', 'example.com');
	define('CLOUDFLARE_RECORD', 'AArecord.example.com');
	define('CLOUDFLARE_RECORD_PROXIED', true);
	define('CHECK_SECONDS', 120);

non usi classi

Cloudflare-DDNS.php/cloudflare-ddns.php

Line 13 in 49a41d2

echo 'Cloudflare API Key: ' . CLOUDFLARE_API_KEY . PHP_EOL . 'Cloudflare email: ' . CLOUDFLARE_EMAIL . PHP_EOL . 'Domain: ' . DOMAIN . PHP_EOL . 'Record: ' . CLOUDFLARE_RECORD . PHP_EOL . 'Check every ' . CHECK_SECONDS . ' seconds.' . PHP_EOL . 'Status: ';

hardcodi l'hostname delle api

Cloudflare-DDNS.php/cloudflare-ddns.php

Line 15 in 49a41d2

curl_setopt($ch, CURLOPT_URL, 'https://api.cloudflare.com/client/v4/zones?name=' . urlencode(DOMAIN));

Cloudflare-DDNS.php/cloudflare-ddns.php

Line 29 in 49a41d2

'https://api.cloudflare.com/client/v4/zones/' . CLOUDFLARE_ID . '/dns_records?type=A&name=' . urlencode(CLOUDFLARE_RECORD));

define messi fuori il top level

Cloudflare-DDNS.php/cloudflare-ddns.php

Line 40 in 49a41d2

define('CLOUDFLARE_RECORD_ID', $result['result'][0]['id']);

uso di servizi di terze parti per avere l'ippi

Cloudflare-DDNS.php/cloudflare-ddns.php

Line 44 in 49a41d2

$ip = file_get_contents('https://ipv4.myip.info/');

mancaza di uso delle exception

Cloudflare-DDNS.php/cloudflare-ddns.php

Line 75 in 49a41d2

die('Error.' . PHP_EOL);

Cloudflare-DDNS.php/cloudflare-ddns.php

Line 72 in 49a41d2

die('Record not found.' . PHP_EOL);

print di roba che dovrebbe essere secreta (potrebbe finire tra i log del supervisor)

Cloudflare-DDNS.php/cloudflare-ddns.php

Line 13 in 49a41d2

echo 'Cloudflare API Key: ' . CLOUDFLARE_API_KEY . PHP_EOL . 'Cloudflare email: ' . CLOUDFLARE_EMAIL . PHP_EOL . 'Domain: ' . DOMAIN . PHP_EOL . 'Record: ' . CLOUDFLARE_RECORD . PHP_EOL . 'Check every ' . CHECK_SECONDS . ' seconds.' . PHP_EOL . 'Status: ';