Error when requesting client access token from server API

[rbanks-willow]

I'm running the OPAL server using the docker image, and I'm getting the following error from the /token endpoint

The request seems to match the swagger definition, so I'm not sure what's missing that's causing the error.

Any help or tips would be appreciated.

[asafc]

Hi @rbanks-willow,

OPAL was recently upgraded to a more recent version of FastAPI and they became a little bit more strict with HTTP request content-type (supposedly due to security issues).

The Content-Type header of all your requests must be application/json, you are currently submitting text/plain.

In postman, simply change the following:

A valid request example

A valid request (and response) will look like this:

[phi1010]

As far as I can tell, this also applies to the obtain-token function from the opal cli -- here with an added pprint of the json response:

/ # opal-server obtain-token keykeykeykey
{'detail': [{'loc': ['body'],
             'msg': 'value is not a valid dict',
             'type': 'type_error.dict'}]}
Traceback (most recent call last):
  File "/usr/local/bin/opal-server", line 33, in <module>
    sys.exit(load_entry_point('opal-server==0.1.9', 'console_scripts', 'opal-server')())
  File "/usr/local/lib/python3.8/site-packages/opal_server-0.1.9-py3.8.egg/opal_server/cli.py", line 62, in cli
    opal_server_config.cli([opal_common_config], typer_app=app, help=main_texts.docs, on_start=on_start)
  File "/usr/local/lib/python3.8/site-packages/opal_common-0.1.9-py3.8.egg/opal_common/confi/confi.py", line 207, in cli
    self.get_cli_object(config_objects, typer_app=typer_app, help=help, on_start=on_start)()
  File "/root/.local/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/root/.local/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/root/.local/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/root/.local/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/root/.local/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/root/.local/lib/python3.8/site-packages/typer/main.py", line 497, in wrapper
    return callback(**use_params)  # type: ignore
  File "/usr/local/lib/python3.8/site-packages/opal_common-0.1.9-py3.8.egg/opal_common/cli/commands.py", line 64, in obtain_token
    res = asyncio.run(fetch())
  File "/usr/local/lib/python3.8/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/local/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()
  File "/usr/local/lib/python3.8/site-packages/opal_common-0.1.9-py3.8.egg/opal_common/cli/commands.py", line 60, in fetch
    return data["token"]
KeyError: 'token'

[phi1010]

(Tested with 0.1.9 and 0.1.10 -- the log messages are from 0.1.9)

[asafc]

hi @phi1010, thanks for letting me know! :)

I will issue a hotfix during the weekend with another issue that was reported today, i guess 0.1.11 is coming sooner that we thought :)

[phi1010]

See my Pull Request; it works in my opal-server docker container -- I hope I did not mess up the python syntax when copypasting.

[phi1010]

#113

[asafc]

#113

Merged! :)