Merge pull request #3 from permitio/raz/better-action-name-support

Refactor action assignment in PermitMcpMiddleware

Author: RazcoDev

permit_fastmcp/middleware/middleware.py

@@ -9,6 +9,7 @@
 import re
 import jwt
 from .config import SETTINGS
+from .utils import generate_action_from_tool_name
 
 logger = logging.getLogger("permit_fastmcp.middleware")
 
@@ -119,7 +120,7 @@ async def on_call_tool(self, context: MiddlewareContext, call_next):
         arguments = getattr(message, "arguments", {})
         # New mapping: resource = MCP_SERVER_NAME, action = tool_name (no prefix)
         resource = SETTINGS.mcp_server_name
-        action = tool_name or "unknown_tool"
+        action = generate_action_from_tool_name(tool_name)
 
         # Build attributes based on configuration
         attributes = {

permit_fastmcp/middleware/utils.py

@@ -0,0 +1,14 @@
+def generate_action_from_tool_name(tool_name: str) -> str:
+    """
+    Generate an action string from a tool name for Permit.io action name standard by replacing special characters with hyphens.
+
+    Args:
+        tool_name: The original tool name
+
+    Returns:
+        The formatted action string with dots, slashes, and underscores replaced by hyphens
+    """
+    if not tool_name:
+        return "unknown-tool"
+
+    return tool_name.replace(".", "-").replace("/", "-").replace("_", "-")

tests/test_utils.py

@@ -0,0 +1,45 @@
+import pytest
+from permit_fastmcp.middleware.utils import generate_action_from_tool_name
+
+
+def test_generate_action_from_tool_name_basic():
+    """Test basic tool name conversion."""
+    assert generate_action_from_tool_name("test_tool") == "test-tool"
+    assert generate_action_from_tool_name("my.tool") == "my-tool"
+    assert generate_action_from_tool_name("path/to/tool") == "path-to-tool"
+
+
+def test_generate_action_from_tool_name_multiple_replacements():
+    """Test tool names with multiple special characters."""
+    assert generate_action_from_tool_name("test.tool_name") == "test-tool-name"
+    assert generate_action_from_tool_name("path/to/my_tool") == "path-to-my-tool"
+    assert (
+        generate_action_from_tool_name("com.example.tool_name")
+        == "com-example-tool-name"
+    )
+
+
+def test_generate_action_from_tool_name_edge_cases():
+    """Test edge cases for tool name conversion."""
+    # Empty string
+    assert generate_action_from_tool_name("") == "unknown-tool"
+
+    # None value
+    assert generate_action_from_tool_name(None) == "unknown-tool"
+
+    # Only special characters
+    assert generate_action_from_tool_name("...") == "---"
+    assert generate_action_from_tool_name("///") == "---"
+    assert generate_action_from_tool_name("___") == "---"
+
+    # Mixed special characters
+    assert (
+        generate_action_from_tool_name("test.tool_name/path") == "test-tool-name-path"
+    )
+
+
+def test_generate_action_from_tool_name_no_changes():
+    """Test tool names that don't need any replacements."""
+    assert generate_action_from_tool_name("simpletool") == "simpletool"
+    assert generate_action_from_tool_name("tool-name") == "tool-name"
+    assert generate_action_from_tool_name("toolname") == "toolname"