WIP

Signed-off-by: Andrew Stein <steinlink@gmail.com>

Author: texodus

.github/workflows/build.yaml

@@ -649,6 +649,7 @@ jobs:
                   path: .
 
             - name: Run Tests
+              id: run_tests
               run: pnpm run test -- --fetch-snapshots
               env:
                   PACKAGE: "server,client,viewer,viewer-datagrid,viewer-charts,viewer-openlayers,workspace,react"
@@ -657,6 +658,15 @@ jobs:
                   PSP_SNAPSHOT_REF: ${{ github.head_ref || github.ref_name }}
                   # PSP_USE_CCACHE: 1
 
+            - name: Upload Test Failures
+              if: ${{ failure() && steps.run_tests.outcome == 'failure' }}
+              uses: actions/upload-artifact@v4
+              with:
+                  name: perspective-js-test-results
+                  path: tools/test/dist/results
+                  if-no-files-found: ignore
+                  overwrite: true
+
     # ,--,--'      .   .-,--.     .  .
     # `- | ,-. ,-. |-   '|__/ . . |- |-. ,-. ,-.
     #  , | |-' `-. |    ,|    | | |  | | | | | |

packages/viewer-charts/src/css/perspective-viewer-charts.css

@@ -4,27 +4,10 @@
     width: 100%;
     height: 100%;
     overflow: hidden;
-    font-family: var(
-        --psp-interface-monospace--font-family,
-        "ui-monospace",
-        "SFMono-Regular",
-        "SF Mono",
-        "Menlo",
-        "Consolas",
-        "Liberation Mono",
-        monospace
-    );
+    font-family: inherit;
+    /* font-family: var(--psp-interface-monospace--font-family, inherit); */
 
-    --psp-webgl--font-family: var(
-        --psp-interface-monospace--font-family,
-        "ui-monospace",
-        "SFMono-Regular",
-        "SF Mono",
-        "Menlo",
-        "Consolas",
-        "Liberation Mono",
-        monospace
-    );
+    /* --psp-webgl--font-family: var(font-family, inherit); */
     --psp-webgl--tooltip--color: var(--psp--color);
     --psp-webgl--tooltip--background: var(--psp--background-color);
     --psp-webgl--tooltip--border-color: var(--psp-inactive--border-color);

packages/viewer-charts/src/ts/theme/theme.ts

@@ -92,7 +92,10 @@ export function resolveTheme(el: Element): Theme {
     const gradientStops = parseCssGradient(gradientSrc);
 
     return {
-        fontFamily: get("--psp-webgl--font-family", "monospace"),
+        fontFamily: get(
+            "--psp-webgl--font-family",
+            get("font-family", "monospace"),
+        ),
         tickColor: get(
             "--psp-webgl--axis-ticks--color",
             "rgba(160, 0, 0, 0.8)",

packages/viewer-charts/test/js/helpers.ts

@@ -19,7 +19,7 @@ import type { ViewerConfigUpdate } from "@perspective-dev/viewer";
  * deterministic on a given machine, but a handful of sub-pixel AA
  * decisions still wiggle across Chromium versions.
  */
-const DEFAULT_MAX_DIFF_PIXEL_RATIO = 0.02;
+const DEFAULT_MAX_DIFF_PIXEL_RATIO = 0.0;
 const DEFAULT_THRESHOLD = 0;
 
 /**

tools/scripts/lint.mjs

@@ -18,13 +18,23 @@ import "zx/globals";
 
 export async function lint_js(is_fix = false) {
     const prettier_flags = is_fix ? "--write" : "--check";
-    await $`prettier ${prettier_flags} "examples/**/*.js" "examples/**/*.tsx" "tools/scripts/*.mjs" "rust/**/*.ts" "rust/**/*.js" "packages/**/*.js" "packages/**/*.ts"`.verbose();
+    await $`prettier ${prettier_flags} \
+        "examples/**/*.js" \
+        "examples/**/*.tsx" \
+        "tools/scripts/*.mjs" \
+        "rust/**/*.ts" \
+        "rust/**/*.js" \
+        "packages/**/*.js" \
+        "packages/**/*.ts" \
+        "**/css/**/*.css" \
+        "**/themes/**/*.css" \
+        "**/html/*.html" \
+        "packages/**/package.json" \
+        "rust/**/package.json" \
+        "examples/**/package.json" \
+        "docs/package.json" \
+        `.verbose();
     await $`prettier --prose-wrap=always ${prettier_flags} "rust/*/docs/**/*.md"`.verbose();
-    // cmd.sh`prettier ${prettier_flags} "**/*.yaml"`;
-    await $`prettier ${prettier_flags} "**/css/**/*.css"`.verbose();
-    await $`prettier ${prettier_flags} "**/themes/**/*.css"`.verbose();
-    await $`prettier ${prettier_flags} "**/html/*.html"`.verbose();
-    await $`prettier ${prettier_flags} "packages/**/package.json" "rust/**/package.json" "examples/**/package.json" "docs/package.json"`.verbose();
 
     const check = is_fix ? [] : ["--check"];
     const dirty = is_fix ? ["--allow-dirty"] : [];

tools/test/src/js/snapshot-sync.ts

@@ -60,6 +60,7 @@ function mirrorSnapshots(srcRoot: string, dest: string) {
     fs.rmSync(dest, { recursive: true, force: true });
     fs.mkdirSync(path.dirname(dest), { recursive: true });
     fs.cpSync(srcSnapshots, dest, { recursive: true });
+    fs.rmSync(path.join(dest, ".git"), { recursive: true, force: true });
 }
 
 export async function fetchSnapshots(): Promise<void> {
@@ -83,6 +84,7 @@ export async function fetchSnapshots(): Promise<void> {
         console.log(
             `Snapshot branch '${requestedRef}' not found on ${repo}; falling back to '${DEFAULT_REF}'.`,
         );
+
         ref = DEFAULT_REF;
     }
 
@@ -126,11 +128,14 @@ export async function writebackSnapshots(): Promise<void> {
         console.log(
             `No snapshot clone at ${CACHE_DIR}; skipping writeback. Run with --fetch-snapshots first to populate the cache.`,
         );
+
         return;
     }
+
     if (!fs.existsSync(DEST_DIR)) {
         return;
     }
+
     fs.cpSync(DEST_DIR, CACHE_DIR, { recursive: true, force: true });
     console.log(`Copied updated snapshots into ${CACHE_DIR}`);
 }