Fixing warnings from rabbit

Author: cvvergara

include/coloring/bipartite.hpp

@@ -40,7 +40,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 namespace pgrouting {
 namespace functions {
 
-std::vector<II_t_rt> pgr_bipartite(pgrouting::UndirectedGraph&);
+std::vector<II_t_rt> pgr_bipartite(const pgrouting::UndirectedGraph&);
 
 }  // namespace functions
 }  // namespace pgrouting

src/coloring/bipartite.cpp

@@ -39,7 +39,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 namespace {
 
-std::vector<II_t_rt> get_bipartition(pgrouting::UndirectedGraph &graph) {
+std::vector<II_t_rt> get_bipartition(const pgrouting::UndirectedGraph &graph) {
     using V_i = pgrouting::UndirectedGraph::V_i;
 
     std::vector<II_t_rt> results;
@@ -56,7 +56,7 @@ std::vector<II_t_rt> get_bipartition(pgrouting::UndirectedGraph &graph) {
         throw;
     } catch (...) {
         throw std::make_pair(
-                std::string("INTERNAL: something went wrong while calling boost::edge_coloring"),
+                std::string("INTERNAL: something went wrong while calling boost::bipartite"),
                 std::string(__PGR_PRETTY_FUNCTION__));;
     }
 
@@ -65,7 +65,7 @@ std::vector<II_t_rt> get_bipartition(pgrouting::UndirectedGraph &graph) {
         int64_t vid = graph[*v].id;
         boost::get(partition_map, *v) ==
             boost::color_traits <boost::default_color_type>::white() ?
-            results.push_back({{vid}, {0}}) : results.push_back({{vid}, {1}});
+            results.push_back({vid, 0}) : results.push_back({vid, 1});
     }
     return results;
 }
@@ -75,7 +75,7 @@ std::vector<II_t_rt> get_bipartition(pgrouting::UndirectedGraph &graph) {
 namespace pgrouting {
 namespace functions {
 
-std::vector<II_t_rt> pgr_bipartite(pgrouting::UndirectedGraph &graph ) {
+std::vector<II_t_rt> pgr_bipartite(const pgrouting::UndirectedGraph &graph ) {
     bool bipartite = boost::is_bipartite(graph.graph);
     return (bipartite)? get_bipartition(graph) : std::vector<II_t_rt>();
 }

src/coloring/coloring_driver.cpp

@@ -101,7 +101,7 @@ void do_coloring(
                 results = sequentialVertexColoring(undigraph);
                 break;
             default:
-                err << "Unknown coloring function" << get_name(which);
+                err << "Unknown coloring function " << get_name(which);
                 return;
         }
 

src/coloring/coloring_process.cpp

@@ -53,8 +53,7 @@ void pgr_process_coloring(
         II_t_rt **result_tuples,
         size_t *result_count) {
     using pgrouting::to_pg_msg;
-    using pgrouting::pgr_free;
-    pgassert(edges_sql);
+
     pgassert(!(*result_tuples));
     pgassert(*result_count == 0);
     pgr_SPI_connect();

src/coloring/edgeColoring.c

@@ -1,6 +1,5 @@
 /*PGR-GNU*****************************************************************
 File: edgeColoring.c
-Generated with Template by:
 
 Generated with Template by:
 Copyright (c) 2015-2026 pgRouting developers

src/coloring/edgeColoring.cpp

@@ -46,7 +46,7 @@ namespace pgrouting {
 namespace functions {
 
 std::vector<II_t_rt>
-edgeColoring(pgrouting::UndirectedGraph g) {
+edgeColoring(const pgrouting::UndirectedGraph g) {
     std::vector<II_t_rt> results(boost::num_edges(g.graph));
     using B_G = pgrouting::UndirectedGraph::B_G;
     using E  = pgrouting::UndirectedGraph::E;
@@ -79,7 +79,7 @@ edgeColoring(pgrouting::UndirectedGraph g) {
 
         /**
          * There is a problem with boost:
-         * Sometimes it returns a color with outsatnding large value
+         * Sometimes it returns a color with outstanding large value
          * When that happens changing color to: colors + 1
          */
         results[i].d2 = get(color_map, *ei) < colors? get(color_map, *ei) + 1 : colors + 1;

src/coloring/sequentialVertexColoring.cpp

@@ -58,7 +58,7 @@ std::vector<II_t_rt> get_results(
     for (boost::tie(v, vend) = vertices(graph.graph); v != vend; ++v) {
         int64_t node = graph[*v].id;
         auto color = colors[*v];
-        results.push_back({{node}, {static_cast<int64_t>(color + 1)}});
+        results.push_back({node, static_cast<int64_t>(color + 1)});
     }
 
     // ordering the results in an increasing order of the node id
@@ -109,7 +109,7 @@ std::vector<II_t_rt> sequentialVertexColoring(const pgrouting::UndirectedGraph &
         throw;
     } catch (...) {
         throw std::make_pair(
-                std::string("INTERNAL: something went wrong while calling boost::edge_coloring"),
+                std::string("INTERNAL: something went wrong while calling boost::sequential_vertex_coloring"),
                 std::string(__PGR_PRETTY_FUNCTION__));;
     }