Merge branch 'develop' into fix-clang-tidy-warnings

Author: cvvergara

.clang-tidy

@@ -8,6 +8,7 @@ Checks: >
     cppcoreguidelines-avoid-non-const-global-variables,
     cppcoreguidelines-avoid-reference-coroutine-parameters,
     cppcoreguidelines-use-default-member-init,
+    cppcoreguidelines-init-variables
 
 WarningsAsErrors: ''
 HeaderFilterRegex: './include'

include/bdAstar/bdAstar.hpp

@@ -156,7 +156,7 @@ class Pgr_bdAstar : public Pgr_bidirectional<G> {
 
         double dx = graph[v].x() - graph[u].x();
         double dy = graph[v].y() - graph[u].y();
-        double current;
+        double current = 0;
 
         switch (m_heuristic) {
             case 0:

include/contraction/contractionGraph.hpp

@@ -181,7 +181,7 @@ class Pgr_contractionGraph : public Pgr_base_graph<G, CH_vertex, CH_edge, t_dire
        */
 
       bool add_shortcut(const CH_edge &edge, V u, V v) {
-         bool inserted;
+         bool inserted = false;
          E e;
          if (edge.cost < 0) return false;
 
@@ -394,7 +394,7 @@ class Pgr_contractionGraph : public Pgr_base_graph<G, CH_vertex, CH_edge, t_dire
         V u, V v, V w,
         std::vector<E> &shortcuts,
         std::ostringstream &log) {
-        bool found_e;
+        bool found_e = false;
         E e;
 
         boost::tie(e, found_e) = boost::edge(u, w, this->graph);
@@ -422,7 +422,7 @@ class Pgr_contractionGraph : public Pgr_base_graph<G, CH_vertex, CH_edge, t_dire
             shortcut.add_contracted_edge_vertices(std::get<0>(e2));
 
             // Add shortcut in the current graph (to go on the process)
-            bool inserted;
+            bool inserted = false;
             E s;
             boost::tie(s, inserted) = boost::add_edge(u, w, this->graph);
             this->graph[s]= shortcut;
@@ -433,16 +433,15 @@ class Pgr_contractionGraph : public Pgr_base_graph<G, CH_vertex, CH_edge, t_dire
     /*! @brief computes p_max used in the contraction hierarchies method
     */
     int64_t compute_pmax(V u, V v, Identifiers<V> out_vertices) {
-        int64_t p_max;
+        int64_t p_max = 0;
         E e, f;
-        bool found_e;
-        p_max = 0;
+        bool found_e = false;
         boost::tie(e, found_e) = boost::edge(u, v, this->graph);
 
         if (found_e) {
             p_max = this->graph[e].cost;
             for (V w : out_vertices) {
-                bool found_f;
+                bool found_f = false;
                 boost::tie(f, found_f) = boost::edge(v, w, this->graph);
                 if ((found_f) && (u != w)) {
                     if ((this->graph[e].cost + this->graph[f].cost) > p_max) {

include/contraction/contractionHierarchies.hpp

@@ -129,7 +129,7 @@ void compute_shortcuts(
         for (const auto &w : out_vertices) {
             if ( u != w ) {
                 typename G::E e, f, g;
-                bool found_e, found_f, found_g;
+                bool found_e = false, found_f = false, found_g = false;
                 boost::tie(e, found_e) = boost::edge(u, v, graph.graph);
                 boost::tie(f, found_f) = boost::edge(v, w, graph.graph);
                 boost::tie(g, found_g) = boost::edge(u, w, graph.graph);
@@ -170,7 +170,7 @@ int64_t vertex_contraction(
 ) {
     Identifiers<typename G::V> adjacent_in_vertices;
     Identifiers<typename G::V> adjacent_out_vertices;
-    int64_t n_old_edges;
+    int64_t n_old_edges = 0;
     std::vector<typename G::E> shortcut_edges;
 
     if (directed) {
@@ -225,7 +225,7 @@ int64_t vertex_contraction(
         << " shortcuts created, " << n_old_edges
         << " old edges" << std::endl;
 
-    int64_t m;
+    int64_t m = 0;
     m = static_cast<int64_t>(shortcut_edges.size())
       - static_cast<int64_t>(n_old_edges);
     log << "  Metric: edge difference = " << shortcut_edges.size()

include/contraction/linearContraction.hpp

@@ -107,10 +107,9 @@ class Pgr_linear {
          pgassert(v != w);
          pgassert(u != w);
 
-         E e, f;
-         bool found_e, found_f;
-
          if (graph.is_directed()) {
+             E e, f;
+             bool found_e = false, found_f = false;
              /*
               *  u --> v --> w
               */

include/cpp_common/base_graph.hpp

@@ -709,7 +709,7 @@ class Pgr_base_graph {
          auto u = get_V(edge.source);
          auto v = get_V(edge.target);
          if (edge.cost >= 0) {
-             bool inserted;
+             bool inserted = false;
              boost::tie(e, inserted) = boost::add_edge(u, v, graph);
              graph[e].cp_members(edge);
          }
@@ -730,7 +730,7 @@ class Pgr_base_graph {
      /**@}*/
 
      template <typename T> void graph_add_edge(const T &edge, bool normal) {
-         bool inserted;
+         bool inserted = false;
          E e;
          if ((edge.cost < 0) && (edge.reverse_cost < 0)) return;
 
@@ -761,7 +761,7 @@ class Pgr_base_graph {
      }
 
      template <typename T> void graph_add_min_edge_no_parallel(const T &edge) {
-         bool inserted;
+         bool inserted = false;
          E e;
          if ((edge.cost < 0) && (edge.reverse_cost < 0)) return;
 
@@ -776,7 +776,7 @@ class Pgr_base_graph {
          pgassert(vertices_map.find(edge.target) != vertices_map.end());
          if (edge.cost >= 0) {
              E e1;
-             bool found;
+             bool found = false;
              boost::tie(e1, found) = boost::edge(vm_s, vm_t, graph);
              if (found) {
                  if (edge.cost < graph[e1].cost) {
@@ -793,7 +793,7 @@ class Pgr_base_graph {
          if (edge.reverse_cost >= 0
                  && (m_is_directed || (!m_is_directed && edge.cost != edge.reverse_cost))) {
              E e1;
-             bool found;
+             bool found = false;
              boost::tie(e1, found) = boost::edge(vm_t, vm_s, graph);
              if (found) {
                  if (edge.reverse_cost < graph[e1].cost) {
@@ -816,7 +816,7 @@ class Pgr_base_graph {
        To Do: Read and apply edges with negative cost in function as it is
        */
      template <typename T> void graph_add_neg_edge(const T &edge, bool normal = true) {
-         bool inserted;
+         bool inserted = false;
          E e;
 
          auto vm_s = get_V(T_V(edge, true));

include/cpp_common/get_data.hpp

@@ -61,8 +61,8 @@ void get_data(
         Func func) {
     const int tuple_limit = 1000000;
 
-    size_t total_tuples;
-    size_t valid_pgtuples;
+    size_t total_tuples = 0;
+    size_t valid_pgtuples = 0;
 
     auto SPIplan = pgr_SPI_prepare(sql);
     auto SPIportal = pgr_SPI_cursor_open(SPIplan);
@@ -120,8 +120,8 @@ std::vector<Data_type> get_data(
         Func func) {
     const int tuple_limit = 1000000;
 
-    size_t total_tuples;
-    size_t valid_pgtuples;
+    size_t total_tuples = 0;
+    size_t valid_pgtuples = 0;
 
     auto SPIplan = pgr_SPI_prepare(sql.c_str());
     auto SPIportal = pgr_SPI_cursor_open(SPIplan);

include/lineGraph/lineGraphFull.hpp

@@ -194,7 +194,7 @@ class Pgr_lineGraphFull : public Pgr_base_graph<G, T_V, T_E, t_directed> {
                 const T &target,
                 int64_t source_in_edge,
                 int64_t source_out_edge) {
-            bool inserted;
+            bool inserted = false;
             E e;
 
             pgassert(m_vertex_map.find({source, source_in_edge}) !=

src/chinese/chinesePostman_driver.cpp

@@ -79,7 +79,7 @@ pgr_do_directedChPP(
 
         pgrouting::graph::PgrDirectedChPPGraph digraph(edges);
 
-        double minCost;
+        double minCost = NAN;
         minCost = digraph.DirectedChPP();
 
         std::vector<Path_rt> pathEdges;

src/coloring/edgeColoring.cpp

@@ -84,7 +84,7 @@ Pgr_edgeColoring::Pgr_edgeColoring(const std::vector<Edge_t> &edges) {
     /*
      * Inserting edges
      */
-    bool added;
+    bool added = false;
     for (const auto &edge : edges) {
         auto v1 = get_boost_vertex(edge.source);
         auto v2 = get_boost_vertex(edge.target);