clang-tidy: fix explicit virtual functions in remaining headers (Fix #3045)

Author: sakirr

.clang-tidy

@@ -11,7 +11,6 @@ Checks: >
     -cppcoreguidelines-avoid-const-or-ref-data-members,
     -cppcoreguidelines-avoid-do-while,
     -cppcoreguidelines-avoid-magic-numbers,
-    -cppcoreguidelines-explicit-virtual-functions,
     -cppcoreguidelines-macro-usage,
     -cppcoreguidelines-narrowing-conversions,
     -cppcoreguidelines-no-malloc,

include/bdAstar/bdAstar.hpp

@@ -78,7 +78,7 @@ class Pgr_bdAstar : public Pgr_bidirectional<G> {
         m_log << "pgr_bdAstar constructor\n";
     }
 
-    virtual ~Pgr_bdAstar() = default;
+    ~Pgr_bdAstar() override = default;
 
     Path pgr_bdAstar(V start_vertex, V end_vertex,
             int heuristic,
@@ -98,7 +98,7 @@ class Pgr_bdAstar : public Pgr_bidirectional<G> {
     using Pgr_bidirectional<G>::clean_log;
 
  private:
-    void explore_forward(const Cost_Vertex_pair &node) {
+    void explore_forward(const Cost_Vertex_pair &node) override {
         typename G::EO_i out, out_end;
 
         auto current_node = node.second;
@@ -124,7 +124,7 @@ class Pgr_bdAstar : public Pgr_bidirectional<G> {
         forward_finished[current_node] = true;
     }
 
-    void explore_backward(const Cost_Vertex_pair &node) {
+    void explore_backward(const Cost_Vertex_pair &node) override {
         typename G::EI_i in, in_end;
 
         auto current_cost = node.first;

include/bdDijkstra/bdDijkstra.hpp

@@ -80,7 +80,7 @@ class Pgr_bdDijkstra : public Pgr_bidirectional<G> {
              m_log << "pgr_bdDijkstra constructor\n";
          }
 
-     virtual ~Pgr_bdDijkstra() = default;
+     ~Pgr_bdDijkstra() override = default;
 
      Path pgr_bdDijkstra(V start_vertex, V end_vertex, bool only_cost) {
          m_log << "pgr_bdDijkstra\n";
@@ -96,7 +96,7 @@ class Pgr_bdDijkstra : public Pgr_bidirectional<G> {
 
 
  private:
-     void explore_forward(const Cost_Vertex_pair &node) {
+     void explore_forward(const Cost_Vertex_pair &node) override {
          typename G::EO_i out, out_end;
 
          auto current_cost = node.first;
@@ -119,7 +119,7 @@ class Pgr_bdDijkstra : public Pgr_bidirectional<G> {
          forward_finished[current_node] = true;
      }
 
-     void explore_backward(const Cost_Vertex_pair &node) {
+     void explore_backward(const Cost_Vertex_pair &node) override {
          typename G::EI_i in, in_end;
 
          auto current_cost = node.first;

include/dagShortestPath/dagShortestPath.hpp

@@ -197,7 +197,7 @@ class Pgr_dag {
               m_goals(goals),
               m_n_goals(n_goals) {}
           template <class B_G>
-              void examine_vertex(V u, B_G &) {
+              void examine_vertex(V u, B_G &) override {
                   auto s_it = m_goals.find(u);
                   if (s_it == m_goals.end()) return;
 

include/spanningTree/kruskal.hpp

@@ -42,7 +42,7 @@ namespace functions {
 template <class G>
 class Pgr_kruskal : public Pgr_mst<G> {
  public:
-     virtual ~Pgr_kruskal() = default;
+     ~Pgr_kruskal() override = default;
      std::vector<MST_rt> kruskal(G &graph);
 
      std::vector<MST_rt> kruskalBFS(
@@ -66,7 +66,7 @@ class Pgr_kruskal : public Pgr_mst<G> {
      typedef typename G::E E;
 
      /* Does all the work */
-     void generate_mst(const G &graph);
+     void generate_mst(const G &graph) override;
 };
 
 

include/spanningTree/prim.hpp

@@ -51,7 +51,7 @@ class Pgr_prim : public Pgr_mst<G> {
      typedef typename G::B_G B_G;
 
  public:
-     virtual ~Pgr_prim() = default;
+     ~Pgr_prim() override = default;
      std::vector<MST_rt> prim(G &graph);
 
      std::vector<MST_rt> primBFS(
@@ -82,7 +82,7 @@ class Pgr_prim : public Pgr_mst<G> {
              const G &graph,
              int64_t root_vertex);
 
-     void generate_mst(const G &graph);
+     void generate_mst(const G &graph) override;
 
  private:
      // Member

include/visitors/astar_visitors.hpp

@@ -43,7 +43,7 @@ class astar_many_goals_visitor : public boost::default_astar_visitor {
      explicit astar_many_goals_visitor(const std::set<V> &goals)
          :m_goals(goals) {}
      template <class B_G>
-         void examine_vertex(V u, B_G &g) {
+         void examine_vertex(V u, B_G &g) override {
              auto s_it = m_goals.find(u);
              if (s_it == m_goals.end()) return;
              // found one more goal

include/visitors/dfs_visitor.hpp

@@ -59,13 +59,13 @@ class Dfs_visitor : public boost::default_dfs_visitor {
              m_depth.resize(m_graph.num_vertices(), 0);
          }
      template <typename B_G>
-         void start_vertex(V v, const B_G&) {
+         void start_vertex(V v, const B_G&) override {
              // exception for visitor termination
              if (v != m_roots) throw found_goals();
              m_depth[v] = 0;
          }
      template <typename B_G>
-         void examine_edge(E e, const B_G&) {
+         void examine_edge(E e, const B_G&) override {
              auto source = m_graph.source(e), target = m_graph.target(e);
              // If the target has not been visited before
              if (m_depth[target] == 0 && target != m_roots) {
@@ -79,7 +79,7 @@ class Dfs_visitor : public boost::default_dfs_visitor {
              }
          }
      template <typename B_G>
-         void tree_edge(E e, const B_G&) {
+         void tree_edge(E e, const B_G&) override {
              m_data.push_back(e);
          }
 

include/visitors/dfs_visitor_with_root.hpp

@@ -47,11 +47,11 @@ class Dfs_visitor_with_root : public boost::default_dfs_visitor {
          m_data(data),
          m_roots(root) {}
      template <typename B_G>
-         void tree_edge(E e, const B_G&) {
+         void tree_edge(E e, const B_G&) override {
              m_data.push_back(e);
          }
      template <typename B_G>
-         void start_vertex(V v, const B_G&) {
+         void start_vertex(V v, const B_G&) override {
              if (v != m_roots) throw found_goals();
          }
 

include/visitors/dijkstra_visitors.hpp

@@ -90,7 +90,7 @@ class dijkstra_many_goal_visitor : public boost::default_dijkstra_visitor {
          m_found_goals(f_goals)   {
          }
      template <class B_G>
-         void examine_vertex(V u, B_G &) {
+         void examine_vertex(V u, B_G &) override {
              auto s_it = m_goals.find(u);
 
              /* examined vertex is not a goal */
@@ -125,7 +125,7 @@ class dijkstra_distance_visitor : public boost::default_dijkstra_visitor {
              pgassert(m_distance_goal > 0);
          }
      template <class B_G>
-         void examine_vertex(V u, B_G &) {
+         void examine_vertex(V u, B_G &) override {
              if (m_dist[u] > m_distance_goal) {
                  throw found_goals();
              }
@@ -155,7 +155,7 @@ class dijkstra_distance_visitor_no_init : public boost::default_dijkstra_visitor
          }
 
      template <class B_G>
-         void examine_vertex(V u, B_G &) {
+         void examine_vertex(V u, B_G &) override {
              if ( 0 == m_num_examined++) m_root = u;
              if (m_dist[u] > m_distance_goal) {
                  throw found_goals();
@@ -166,22 +166,22 @@ class dijkstra_distance_visitor_no_init : public boost::default_dijkstra_visitor
          }
 
      template <class B_G>
-         void examine_edge(E e, B_G &g) {
+         void examine_edge(E e, B_G &g) override {
              if (source(e, g) != m_root && m_predecessors[source(e, g)] == source(e, g)) {
                  m_color[target(e, g)] = boost::black_color;
              }
          }
 
 
      template <class B_G>
-         void edge_not_relaxed(E e, B_G &g) {
+         void edge_not_relaxed(E e, B_G &g) override {
              if (source(e, g) != m_root && m_predecessors[source(e, g)] == source(e, g)) {
                  m_color[target(e, g)] = boost::black_color;
              }
          }
 
      template <class B_G>
-         void discover_vertex(V u, B_G &) {
+         void discover_vertex(V u, B_G &) override {
              if (u  != m_root && m_predecessors[u] == u) {
                  m_color[u] = boost::black_color;
              }