Merge pull request #127 from pharmaverse/123_increase_test_sort

Closes #123 add tests for sort

Author: LiamHobby

tests/testthat/test-sort.R

@@ -1,31 +1,52 @@
-# Suppress cli output during testing
-options(cli.default_handler = function(...) {})
-
-load(metacore::metacore_example("pilot_ADaM.rda"))
-spec <- metacore %>% select_dataset("ADSL", quiet = TRUE)
-data <- haven::read_xpt(metatools_example("adsl.xpt"))
-test_that("sort_order", {
-  data %>%
+# order_cols() tests ----
+test_that("order_cols reorders columns to match metacore spec", {
+  load(metacore::metacore_example("pilot_ADaM.rda"))
+  spec <- metacore %>% select_dataset("ADSL", quiet = TRUE)
+  data <- haven::read_xpt(metatools_example("adsl.xpt"))
+
+  result <- data %>%
     select(AGE, SITEID, everything()) %>%
-    order_cols(spec) %>%
-    expect_equal(data)
-  # Check when too many columns
-  data %>%
+    order_cols(spec)
+
+  expect_equal(result, data)
+})
+
+test_that("order_cols handles extra columns not in spec", {
+  load(metacore::metacore_example("pilot_ADaM.rda"))
+  spec <- metacore %>% select_dataset("ADSL", quiet = TRUE)
+  data <- haven::read_xpt(metatools_example("adsl.xpt"))
+
+  result <- data %>%
     select(AGE, everything(), -SITEID) %>%
-    order_cols(spec) %>%
-    expect_equal(select(data, -SITEID))
+    order_cols(spec)
 
-  # Check when there are too few columns
-  data %>%
+  expected <- select(data, -SITEID)
+  expect_equal(result, expected)
+})
+
+test_that("order_cols handles additional columns beyond spec", {
+  load(metacore::metacore_example("pilot_ADaM.rda"))
+  spec <- metacore %>% select_dataset("ADSL", quiet = TRUE)
+  data <- haven::read_xpt(metatools_example("adsl.xpt"))
+
+  result <- data %>%
     select(AGE, SITEID, everything()) %>%
     mutate(foo = "game") %>%
-    order_cols(spec) %>%
-    expect_equal(mutate(data, foo = "game"))
+    order_cols(spec)
+
+  expected <- mutate(data, foo = "game")
+  expect_equal(result, expected)
 })
 
-test_that("sort_key", {
-  data %>%
+# sort_by_key() tests ----
+test_that("sort_by_key sorts data by key variables from metacore spec", {
+  load(metacore::metacore_example("pilot_ADaM.rda"))
+  spec <- metacore %>% select_dataset("ADSL", quiet = TRUE)
+  data <- haven::read_xpt(metatools_example("adsl.xpt"))
+
+  result <- data %>%
     arrange(TRT01P, AGE) %>%
-    sort_by_key(spec) %>%
-    expect_equal(data)
+    sort_by_key(spec)
+
+  expect_equal(result, data)
 })