Skip to content

Commit aaeb702

Browse files
developer-guymarcofranssen
authored andcommitted
move spiffe-csi-driver and node-driver-registrar to values
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
1 parent be4c27d commit aaeb702

4 files changed

Lines changed: 28 additions & 7 deletions

File tree

charts/spire/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ description: |
2727
- --service-account-signing-key-file=/run/config/pki/sa.key
2828
```
2929
type: application
30-
version: 0.5.2
30+
version: 0.5.3
3131
appVersion: "1.4.4"
3232
keywords: ["spiffe", "spire", "spire-server", "spire-agent"]
3333
home: https://github.com/philips-labs/helm-charts/charts/spire

charts/spire/README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<!-- This README.md is generated. -->
44

5-
![Version: 0.5.2](https://img.shields.io/badge/Version-0.5.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.4.4](https://img.shields.io/badge/AppVersion-1.4.4-informational?style=flat-square)
5+
![Version: 0.5.3](https://img.shields.io/badge/Version-0.5.3-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.4.4](https://img.shields.io/badge/AppVersion-1.4.4-informational?style=flat-square)
66

77
A Helm chart for deploying spire-server and spire-agent.
88

@@ -67,6 +67,10 @@ Kubernetes: `>=1.21.0-0`
6767
| fullnameOverride | string | `""` | |
6868
| imagePullSecrets | list | `[]` | |
6969
| nameOverride | string | `""` | |
70+
| nodeDriverRegistrar.image.pullPolicy | string | `"IfNotPresent"` | |
71+
| nodeDriverRegistrar.image.repository | string | `"quay.io/k8scsi/csi-node-driver-registrar"` | |
72+
| nodeDriverRegistrar.image.tag | string | `"v2.0.1"` | |
73+
| nodeDriverRegistrar.resources | object | `{}` | |
7074
| oidc.acme.cacheDir | string | `"/run/spire"` | |
7175
| oidc.acme.directoryUrl | string | `"https://acme-v02.api.letsencrypt.org/directory"` | |
7276
| oidc.acme.emailAddress | string | `"letsencrypt@example.org"` | |

charts/spire/templates/agent-daemonset.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ spec:
6363
{{- toYaml .Values.agent.resources | nindent 12 }}
6464
# This is the container which runs the SPIFFE CSI driver.
6565
- name: spiffe-csi-driver
66-
image: ghcr.io/spiffe/spiffe-csi-driver:nightly
67-
imagePullPolicy: IfNotPresent
66+
image: {{ .Values.csiDriver.image.repository}}:{{ .Values.csiDriver.image.tag}}
67+
imagePullPolicy: {{ .Values.csiDriver.image.pullPolicy}}
6868
args: [
6969
"-workload-api-socket-dir", "/spire-agent-socket",
7070
"-csi-socket-path", "/spiffe-csi/csi.sock",
@@ -98,8 +98,8 @@ spec:
9898
# of all the little details required to register a CSI driver with
9999
# the kubelet.
100100
- name: node-driver-registrar
101-
image: quay.io/k8scsi/csi-node-driver-registrar:v2.0.1
102-
imagePullPolicy: IfNotPresent
101+
image: {{ .Values.nodeDriverRegistrar.image.repository }}:{{ .Values.nodeDriverRegistrar.image.tag }}
102+
imagePullPolicy: {{ .Values.nodeDriverRegistrar.image.pullPolicy }}
103103
args: [
104104
"-csi-address", "/spiffe-csi/csi.sock",
105105
"-kubelet-registration-path", "/var/lib/kubelet/plugins/csi.spiffe.io/csi.sock",
@@ -113,7 +113,7 @@ spec:
113113
- name: kubelet-plugin-registration-dir
114114
mountPath: /registration
115115
resources:
116-
{{- toYaml .Values.csiDriver.resources | nindent 12 }}
116+
{{- toYaml .Values.nodeDriverRegistrar.resources | nindent 12 }}
117117
volumes:
118118
- name: spire-config
119119
configMap:

charts/spire/values.yaml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,23 @@ csiDriver:
7272
# cpu: 100m
7373
# memory: 64Mi
7474

75+
nodeDriverRegistrar:
76+
image:
77+
repository: quay.io/k8scsi/csi-node-driver-registrar
78+
pullPolicy: IfNotPresent
79+
tag: v2.0.1
80+
resources: {}
81+
# We usually recommend not to specify default resources and to leave this as a conscious
82+
# choice for the user. This also increases chances charts run on environments with little
83+
# resources, such as Minikube. If you do want to specify resources, uncomment the following
84+
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
85+
# requests:
86+
# cpu: 50m
87+
# memory: 32Mi
88+
# limits:
89+
# cpu: 100m
90+
# memory: 64Mi
91+
7592
oidc:
7693
enabled: false
7794

0 commit comments

Comments
 (0)