Skip to content

Commit 3eb2170

Browse files
Copilotbcollamore
andauthored
fix: Remove obsolete PH2035 analyzer (TestMethodsMustHaveTheCorrectNumberOfArguments) (#861)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bcollamore <57269455+bcollamore@users.noreply.github.com>
1 parent 81adecf commit 3eb2170

5 files changed

Lines changed: 1 addition & 403 deletions

File tree

Documentation/Diagnostics/PH2035.md

Lines changed: 0 additions & 61 deletions
This file was deleted.

Philips.CodeAnalysis.Common/DiagnosticId.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ public enum DiagnosticId
3434
AvoidTryParseWithoutCulture = 2031,
3535
AvoidEmptyTypeInitializer = 2032,
3636
TestMethodsMustBeInTestClass = 2034,
37-
TestMethodsMustHaveTheCorrectNumberOfArguments = 2035,
3837
TestMethodsMustBePublic = 2036,
3938
TestMethodsMustHaveUniqueNames = 2037,
4039
TestClassesMustBePublic = 2038,

Philips.CodeAnalysis.MsTestAnalyzers/Philips.CodeAnalysis.MsTestAnalyzers.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616
| [PH2017](../Documentation/Diagnostics/PH2017.md) | Avoid ClassInitialize attribute | This attribute is unnecessary in the C# programming language. They circumvent TestTimeouts, allowing for slower Test Runs. They can contribute to non-deterministic test execution order, resulting complications while debugging. |
1717
| [PH2018](../Documentation/Diagnostics/PH2018.md) | Avoid ClassCleanup attribute | This attribute is unnecessary in the C# programming language. They circumvent TestTimeouts, allowing for slower Test Runs. They can contribute to non-deterministic test execution order, resulting complications while debugging. |
1818
| [PH2019](../Documentation/Diagnostics/PH2019.md) | Avoid TestCleanup attribute | This attribute is unnecessary in the C# programming language. They circumvent TestTimeouts, allowing for slower Test Runs. They can contribute to non-deterministic test execution order, resulting complications while debugging. |
19-
| [PH2034](../Documentation/Diagnostics/PH2034.md) | TestMethod requires TestClass | TestMethods not inside a TestClass are not executed. They are dead code. |
20-
| [PH2035](../Documentation/Diagnostics/PH2035.md) | DataTestMethod requires correct parameter count | DataTestMethods must have the same number of parameters of the DataRows, TestMethods should have no arguments. |
19+
| [PH2034](../Documentation/Diagnostics/PH2034.md) | TestMethod requires TestClass | TestMethods not inside a TestClass are not executed. They are dead code. |
2120
| [PH2036](../Documentation/Diagnostics/PH2036.md) | TestMethod is public | TestMethods must be public. |
2221
| [PH2037](../Documentation/Diagnostics/PH2037.md) | TestMethods and DataTestMethods require unique names | TestMethods and DataTestMethods require unique names. |
2322
| [PH2038](../Documentation/Diagnostics/PH2038.md) | TestClass is public | TestClass must be public. |

Philips.CodeAnalysis.MsTestAnalyzers/TestMethodsMustHaveTheCorrectNumberOfArgumentsAnalyzer.cs

Lines changed: 0 additions & 135 deletions
This file was deleted.

0 commit comments

Comments
 (0)