Skip to content

Commit 5d0a8f5

Browse files
Copilotbcollamore
andauthored
fix: Remove obsolete DataTestMethodsHaveDataRowsAnalyzer (PH2033) (#851)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bcollamore <57269455+bcollamore@users.noreply.github.com>
1 parent 134423e commit 5d0a8f5

5 files changed

Lines changed: 1 addition & 314 deletions

File tree

Documentation/Diagnostics/PH2033.md

Lines changed: 0 additions & 71 deletions
This file was deleted.

Philips.CodeAnalysis.Common/DiagnosticId.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ public enum DiagnosticId
3333
VariableNamingConventions = 2030,
3434
AvoidTryParseWithoutCulture = 2031,
3535
AvoidEmptyTypeInitializer = 2032,
36-
DataTestMethodsHaveDataRows = 2033,
3736
TestMethodsMustBeInTestClass = 2034,
3837
TestMethodsMustHaveTheCorrectNumberOfArguments = 2035,
3938
TestMethodsMustBePublic = 2036,

Philips.CodeAnalysis.MsTestAnalyzers/DataTestMethodsHaveDataRowsAnalyzer.cs

Lines changed: 0 additions & 111 deletions
This file was deleted.

Philips.CodeAnalysis.MsTestAnalyzers/Philips.CodeAnalysis.MsTestAnalyzers.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@
1515
| [PH2016](../Documentation/Diagnostics/PH2016.md) | Avoid TestInitialize attribute | This attribute is unnecessary in the C# programming language. They circumvent TestTimeouts, allowing for slower Test Runs. They can contribute to non-deterministic test execution order, resulting complications while debugging. |
1616
| [PH2017](../Documentation/Diagnostics/PH2017.md) | Avoid ClassInitialize attribute | This attribute is unnecessary in the C# programming language. They circumvent TestTimeouts, allowing for slower Test Runs. They can contribute to non-deterministic test execution order, resulting complications while debugging. |
1717
| [PH2018](../Documentation/Diagnostics/PH2018.md) | Avoid ClassCleanup attribute | This attribute is unnecessary in the C# programming language. They circumvent TestTimeouts, allowing for slower Test Runs. They can contribute to non-deterministic test execution order, resulting complications while debugging. |
18-
| [PH2019](../Documentation/Diagnostics/PH2019.md) | Avoid TestCleanup attribute | This attribute is unnecessary in the C# programming language. They circumvent TestTimeouts, allowing for slower Test Runs. They can contribute to non-deterministic test execution order, resulting complications while debugging. |
19-
| [PH2033](../Documentation/Diagnostics/PH2033.md) | DataTestMethod requires DataRows | DataTestMethods must have at least 1 DataRow. TestMethods must not have any DataRows. |
18+
| [PH2019](../Documentation/Diagnostics/PH2019.md) | Avoid TestCleanup attribute | This attribute is unnecessary in the C# programming language. They circumvent TestTimeouts, allowing for slower Test Runs. They can contribute to non-deterministic test execution order, resulting complications while debugging. |
2019
| [PH2034](../Documentation/Diagnostics/PH2034.md) | TestMethod requires TestClass | TestMethods not inside a TestClass are not executed. They are dead code. |
2120
| [PH2035](../Documentation/Diagnostics/PH2035.md) | DataTestMethod requires correct parameter count | DataTestMethods must have the same number of parameters of the DataRows, TestMethods should have no arguments. |
2221
| [PH2036](../Documentation/Diagnostics/PH2036.md) | TestMethod is public | TestMethods must be public. |

Philips.CodeAnalysis.Test/MsTest/DataTestMethodsHaveDataRowsAnalyzerTest.cs

Lines changed: 0 additions & 129 deletions
This file was deleted.

0 commit comments

Comments
 (0)