Remove obsolete DataTestMethodsHaveDataRowsAnalyzer (PH2033)

The DataTestMethodsHaveDataRowsAnalyzer is obsolete due to changes in MSTest framework. As of MSTest v3.8, TestMethod supports DataRow, and as of MSTest v3.10, DataTestMethod is marked obsolete with MSTEST0044. Microsoft now provides MSTEST0014 for parameter validation.

Removed:
- DataTestMethodsHaveDataRowsAnalyzer.cs and tests
- PH2033 documentation
- DiagnosticId enum entry
- Updated summary documentation

Build and all tests pass successfully.

Co-authored-by: bcollamore <57269455+bcollamore@users.noreply.github.com>

Author: Copilot

Documentation/Diagnostics/PH2033.md

@@ -33,7 +33,6 @@ public enum DiagnosticId
 		VariableNamingConventions = 2030,
 		AvoidTryParseWithoutCulture = 2031,
 		AvoidEmptyTypeInitializer = 2032,
-		DataTestMethodsHaveDataRows = 2033,
 		TestMethodsMustBeInTestClass = 2034,
 		TestMethodsMustHaveTheCorrectNumberOfArguments = 2035,
 		TestMethodsMustBePublic = 2036,

Philips.CodeAnalysis.Common/DiagnosticId.cs

@@ -15,8 +15,7 @@
 | [PH2016](../Documentation/Diagnostics/PH2016.md)  | Avoid TestInitialize attribute                       | This attribute is unnecessary in the C# programming language. They circumvent TestTimeouts, allowing for slower Test Runs.  They can contribute to non-deterministic test execution order, resulting complications while debugging. |
 | [PH2017](../Documentation/Diagnostics/PH2017.md)  | Avoid ClassInitialize attribute                      | This attribute is unnecessary in the C# programming language. They circumvent TestTimeouts, allowing for slower Test Runs.  They can contribute to non-deterministic test execution order, resulting complications while debugging. |
 | [PH2018](../Documentation/Diagnostics/PH2018.md)  | Avoid ClassCleanup attribute                         | This attribute is unnecessary in the C# programming language. They circumvent TestTimeouts, allowing for slower Test Runs.  They can contribute to non-deterministic test execution order, resulting complications while debugging. |
-| [PH2019](../Documentation/Diagnostics/PH2019.md)  | Avoid TestCleanup attribute                          | This attribute is unnecessary in the C# programming language. They circumvent TestTimeouts, allowing for slower Test Runs.  They can contribute to non-deterministic test execution order, resulting complications while debugging. |
-| [PH2033](../Documentation/Diagnostics/PH2033.md)  | DataTestMethod requires DataRows                     | DataTestMethods must have at least 1 DataRow.  TestMethods must not have any DataRows. |
+| [PH2019](../Documentation/Diagnostics/PH2019.md)  | Avoid TestCleanup attribute                          | This attribute is unnecessary in the C# programming language. They circumvent TestTimeouts, allowing for slower Test Runs.  They can contribute to non-deterministic test execution order, resulting complications while debugging. |
 | [PH2034](../Documentation/Diagnostics/PH2034.md)  | TestMethod requires TestClass                        | TestMethods not inside a TestClass are not executed.  They are dead code. |
 | [PH2035](../Documentation/Diagnostics/PH2035.md)  | DataTestMethod requires correct parameter count      | DataTestMethods must have the same number of parameters of the DataRows, TestMethods should have no arguments. |
 | [PH2036](../Documentation/Diagnostics/PH2036.md)  | TestMethod is public                                 | TestMethods must be public.                                  |