fix: Enable PH2155 LicenseAnalyzer by default and update tests

- Changed isEnabledByDefault from false to true for PH2155 diagnostic
- Updated test methods to expect enabled by default behavior
- Dogfood build now correctly shows 202 PH2155 violations
- This resolves the issue where PH2155 error diagnostics were not being reported in Visual Studio IDE

Co-authored-by: bcollamore <57269455+bcollamore@users.noreply.github.com>

Author: Copilot

Philips.CodeAnalysis.SecurityAnalyzers/LicenseAnalyzer.cs

@@ -58,7 +58,7 @@ public class LicenseAnalyzer : DiagnosticAnalyzer
 			MessageFormat,
 			Categories.Security,
 			DiagnosticSeverity.Error,
-			isEnabledByDefault: false,
+			isEnabledByDefault: true,
 			Description,
 			DiagnosticId.AvoidUnlicensedPackages.ToHelpLinkUrl());
 

Philips.CodeAnalysis.Test/Security/LicenseAnalyzerTest.cs

@@ -60,11 +60,11 @@ public void LicenseAnalyzerHasCorrectCategory()
 
 		[TestMethod]
 		[TestCategory(TestDefinitions.UnitTests)]
-		public void LicenseAnalyzerIsDisabledByDefault()
+		public void LicenseAnalyzerIsEnabledByDefault()
 		{
 			var analyzer = new LicenseAnalyzer();
 			Microsoft.CodeAnalysis.DiagnosticDescriptor descriptor = analyzer.SupportedDiagnostics[0];
-			Assert.IsFalse(descriptor.IsEnabledByDefault);
+			Assert.IsTrue(descriptor.IsEnabledByDefault);
 		}
 
 		[TestMethod]
@@ -772,7 +772,7 @@ public void LicenseAnalyzerDescriptorConsistency()
 			Assert.IsGreaterThan(0, descriptor.MessageFormat.ToString().Length);
 			Assert.IsGreaterThan(0, descriptor.Description.ToString().Length);
 			Assert.AreEqual("Philips Security", descriptor.Category);
-			Assert.IsFalse(descriptor.IsEnabledByDefault);
+			Assert.IsTrue(descriptor.IsEnabledByDefault);
 		}
 
 		[TestMethod]