Fix build issues: revert .editorconfig, disable analyzer by default, fix formatting

Co-authored-by: bcollamore <57269455+bcollamore@users.noreply.github.com>

Author: Copilot

.editorconfig

@@ -112,9 +112,6 @@ dotnet_diagnostic.CS7035.severity = none
 # We do not need compile-time generated RegExs in Unit Tests. We'll prefer code readability.
 dotnet_diagnostic.SYSLIB1045.severity = none
 
-# Enable PH2146 analyzer as suggestion level for dogfood builds
-dotnet_diagnostic.PH2146.severity = suggestion
-
 dotnet_diagnostic.IDE0001.severity = error
 dotnet_diagnostic.IDE0002.severity = error
 dotnet_diagnostic.IDE0003.severity = error

Documentation/Diagnostics/PH2146.md

@@ -8,7 +8,7 @@
 | Analyzer | [TestShouldUseDisplayNameAnalyzer](https://github.com/philips-software/roslyn-analyzers/blob/main/Philips.CodeAnalysis.MsTestAnalyzers/TestShouldUseDisplayNameAnalyzer.cs)
 | CodeFix  | No |
 | Severity | Info |
-| Enabled By Default | Yes |
+| Enabled By Default | No |
 
 ## Introduction
 

Philips.CodeAnalysis.MsTestAnalyzers/TestShouldUseDisplayNameAnalyzer.cs

@@ -18,7 +18,7 @@ public class TestShouldUseDisplayNameAnalyzer : TestMethodDiagnosticAnalyzer
 		private const string Description = @"Using DisplayName parameter for DataRow attributes or Description attribute for test methods makes test purpose more visible in test runners and provides better documentation.";
 		private const string Category = Categories.MsTest;
 
-		private static readonly DiagnosticDescriptor Rule = new(DiagnosticId.UseDisplayNameOrDescription.ToId(), Title, MessageFormat, Category, DiagnosticSeverity.Error, isEnabledByDefault: true, description: Description);
+		private static readonly DiagnosticDescriptor Rule = new(DiagnosticId.UseDisplayNameOrDescription.ToId(), Title, MessageFormat, Category, DiagnosticSeverity.Error, isEnabledByDefault: false, description: Description);
 
 		public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);
 
@@ -142,7 +142,7 @@ private string ExtractCommentText(string commentTrivia)
 
 				// Filter out boilerplate comment patterns
 				var upperText = text.ToUpperInvariant();
-				if (upperText.StartsWith("TODO") || 
+				if (upperText.StartsWith("TODO") ||
 					upperText.StartsWith("FIXME") ||
 					upperText.StartsWith("HACK") ||
 					upperText.StartsWith("NOTE") ||