Skip to content

Commit d19c4f4

Browse files
committed
Fix comment
1 parent 1a979f8 commit d19c4f4

2 files changed

Lines changed: 14 additions & 14 deletions

File tree

velox/core/QueryConfig.h

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,6 @@ class QueryConfig {
3636
static constexpr const char* kQueryMaxMemoryPerNode =
3737
"query_max_memory_per_node";
3838

39-
/// If true, Velox will use an ANSI-compliant dialect. For example, Velox will
40-
/// throw a runtime exception instead of returning null results when the inputs
41-
/// to a SQL operator or function are invalid.
42-
static constexpr const char* kAnsiEnabled = "ansi_enabled";
43-
4439
/// User provided session timezone. Stores a string with the actual timezone
4540
/// name, e.g: "America/Los_Angeles".
4641
static constexpr const char* kSessionTimezone = "session_timezone";
@@ -368,6 +363,11 @@ class QueryConfig {
368363
static constexpr const char* kPrestoArrayAggIgnoreNulls =
369364
"presto.array_agg.ignore_nulls";
370365

366+
/// If true, Velox will use an ANSI-compliant dialect. For example, Velox will
367+
/// throw a runtime exception instead of returning null results when the
368+
/// inputs to a SQL operator or function are invalid.
369+
static constexpr const char* kSparkAnsiEnabled = "spark.ansi_enabled";
370+
371371
/// The default number of expected items for the bloomfilter.
372372
static constexpr const char* kSparkBloomFilterExpectedNumItems =
373373
"spark.bloom_filter.expected_num_items";
@@ -869,10 +869,6 @@ class QueryConfig {
869869
return get<uint64_t>(kExprMaxCompiledRegexes, 100);
870870
}
871871

872-
bool ansiEnabled() const {
873-
return get<bool>(kAnsiEnabled, false);
874-
}
875-
876872
bool adjustTimestampToTimezone() const {
877873
return get<bool>(kAdjustTimestampToTimezone, false);
878874
}
@@ -1030,6 +1026,10 @@ class QueryConfig {
10301026
return get<bool>(kPrestoArrayAggIgnoreNulls, false);
10311027
}
10321028

1029+
bool sparkAnsiEnabled() const {
1030+
return get<bool>(kSparkAnsiEnabled, false);
1031+
}
1032+
10331033
int64_t sparkBloomFilterExpectedNumItems() const {
10341034
constexpr int64_t kDefault = 1'000'000L;
10351035
return get<int64_t>(kSparkBloomFilterExpectedNumItems, kDefault);

velox/docs/configs.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,6 @@ Generic Configuration
4343
- integer
4444
- 80
4545
- Abandons partial TopNRowNumber if number of output rows equals or exceeds this percentage of the number of input rows.
46-
* - ansi_enabled
47-
- bool
48-
- false
49-
- If true, Velox will use an ANSI-compliant dialect. For example, Velox will throw a runtime exception instead of
50-
returning null results when the inputs to a SQL operator or function are invalid.
5146
* - session_timezone
5247
- string
5348
-
@@ -982,6 +977,11 @@ Spark-specific Configuration
982977
- Type
983978
- Default Value
984979
- Description
980+
* - spark.ansi_enabled
981+
- bool
982+
- false
983+
- If true, Velox will use an ANSI-compliant dialect. For example, Velox will throw a runtime exception instead of
984+
returning null results when the inputs to a SQL operator or function are invalid.
985985
* - spark.legacy_size_of_null
986986
- bool
987987
- true

0 commit comments

Comments
 (0)