Merge pull request #1333 from lacatoire/fix/textrole-null-backslash

Guard against null token after trailing backslash in text role

Author: jaapio

packages/guides-restructured-text/src/RestructuredText/Parser/Productions/InlineRules/TextRoleRule.php

@@ -76,8 +76,12 @@ public function apply(BlockContext $blockContext, InlineLexer $lexer): InlineNod
 
                     break;
                 case InlineLexer::BACKSLASH:
-                    $rawPart .= $token->value;
                     $lexer->moveNext();
+                    if ($lexer->token === null) {
+                        break 2;
+                    }
+
+                    $rawPart .= $token->value;
                     $part .= $lexer->token->value;
                     $rawPart .= $lexer->token->value;
 

packages/guides-restructured-text/tests/unit/Parser/Productions/InlineRules/TextRoleRuleTest.php

@@ -148,4 +148,31 @@ public function __construct(
          */
         self::assertSame($expectedRawContent, $node->rawContent);
     }
+
+    public function testApplyReturnsNullOnTrailingBackslashWithoutRaisingWarning(): void
+    {
+        $input = ':role:`text\\';
+
+        $textRoleFactory = $this->createMock(TextRoleFactory::class);
+        $textRoleFactory->expects(self::never())->method('getTextRole');
+
+        $lexer = new InlineLexer();
+        $lexer->setInput($input);
+        $lexer->moveNext();
+        $lexer->moveNext();
+
+        $textRoleRule = new TextRoleRule();
+        self::assertTrue($textRoleRule->applies($lexer));
+
+        $documentParserContext = new DocumentParserContext(
+            self::createStub(ParserContext::class),
+            $textRoleFactory,
+            self::createStub(MarkupLanguageParser::class),
+        );
+
+        self::assertNull($textRoleRule->apply(
+            new BlockContext($documentParserContext, ''),
+            $lexer,
+        ));
+    }
 }