Fix CI

Author: veewee

.github/workflows/grumphp.yml

@@ -62,9 +62,10 @@ jobs:
             - name: Run the tests on Windows
               if: runner.os == 'Windows'
               run: php vendor/bin/grumphp run --no-interaction --testsuite=windows
+              continue-on-error: ${{ matrix.php-versions == '8.5' }} # Psalm is not there yet
             - name: Run the tests on unix
               if: runner.os != 'Windows'
               run: php vendor/bin/grumphp run --no-interaction --testsuite=ci
-              continue-on-error: ${{ matrix.php-versions == '8.5' && matrix.composer-deps == 'lowest' }}
+              continue-on-error: ${{ matrix.php-versions == '8.5' }} # Psalm is not there yet
             - name: Run paratest outside of grumphp
-              run: php ./vendor/bin/paratest --testsuite=E2E -f --verbose
+              run: php ./vendor/bin/paratest --testsuite=E2E --functional --verbose

appveyor.yml

@@ -79,4 +79,4 @@ install:
 test_script:
   - ps: cd $Env:project_directory
   - php ./bin/grumphp run --testsuite=windows --no-interaction
-  - php ./vendor/bin/paratest --testsuite=E2E -f --verbose
+  - php ./vendor/bin/paratest --testsuite=E2E --functional --verbose

composer.json

@@ -45,7 +45,8 @@
         "php-cs-fixer/shim": "^3.88",
         "php-parallel-lint/php-parallel-lint": "^1.3",
         "phpspec/phpspec": "^8.0",
-        "phpspec/prophecy-phpunit": "^2.2",
+        "phpspec/prophecy": "^1.23",
+        "phpspec/prophecy-phpunit": "^2.4",
         "phpunit/phpunit": "^11.5"
     },
     "suggest": {

composer.lock

@@ -16,7 +16,6 @@ grumphp:
       no_check_lock: true
     composer_normalize:
       use_standalone: true
-    composer_validate_autoload: ~
     yamllint:
       parse_custom_tags: true
       ignore_patterns:

grumphp.yml.dist

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phive xmlns="https://phar.io/phive">
-  <phar name="psalm" version="^6.13.0" installed="6.13.1" location="./tools/psalm" copy="true"/>
-  <phar name="phpcs" version="^4.0.0" installed="4.0.0" location="./tools/phpcs" copy="true"/>
-  <phar name="phpcbf" version="^4.0.0" installed="4.0.0" location="./tools/phpcbf" copy="true"/>
-  <phar name="composer-normalize" version="^2.48.0" installed="2.48.2" location="./tools/composer-normalize" copy="true"/>
+  <phar name="psalm" version="^6.13.0" installed="6.13.1" location="./tools/psalm.phar" copy="true"/>
+  <phar name="phpcs" version="^4.0.0" installed="4.0.0" location="./tools/phpcs.phar" copy="true"/>
+  <phar name="phpcbf" version="^4.0.0" installed="4.0.0" location="./tools/phpcbf.phar" copy="true"/>
+  <phar name="composer-normalize" version="^2.48.0" installed="2.48.2" location="./tools/composer-normalize.phar" copy="true"/>
 </phive>

phive.xml

@@ -6,7 +6,7 @@
     colors="true"
     displayDetailsOnTestsThatTriggerWarnings="true"
     failOnWarning="true"
-    failOnPhpunitWarning="true">
+>
     <php>
         <ini name="error_reporting" value="-1" />
     </php>

phpunit.xml.dist

@@ -8,6 +8,8 @@
     findUnusedBaselineEntry="false"
     findUnusedCode="false"
     ensureOverrideAttribute="false"
+    ignoreInternalFunctionFalseReturn="true"
+    ignoreInternalFunctionNullReturn="true"
 >
     <projectFiles>
         <directory name="src" />
@@ -25,5 +27,10 @@
                 <directory name="src/" />
             </errorLevel>
         </RiskyTruthyFalsyComparison>
+        <ClassMustBeFinal>
+            <errorLevel type="suppress">
+                <directory name="src/" />
+            </errorLevel>
+        </ClassMustBeFinal>
     </issueHandlers>
 </psalm>

psalm.xml

@@ -5,16 +5,7 @@
 namespace GrumPHP\Event;
 
 use Symfony\Contracts\EventDispatcher\Event as SymfonyEventContract;
-use Symfony\Component\EventDispatcher\Event as SymfonyLegacyEvent;
 
-// @codingStandardsIgnoreStart
-if (class_exists(SymfonyEventContract::class)) {
-    class Event extends SymfonyEventContract
-    {
-    }
-} else {
-    class Event extends SymfonyLegacyEvent
-    {
-    }
+class Event extends SymfonyEventContract
+{
 }
-// @codingStandardsIgnoreEnd

src/Event/Event.php

@@ -131,7 +131,8 @@ public function run(ContextInterface $context): TaskResultInterface
             return TaskResult::createSkipped($this, $context);
         }
 
-        $coverage = round(($checkedElements / $totalElements) * 100, 2);
+        $coverage = (float) ($checkedElements / $totalElements);
+        $coverage = round($coverage * 100.0, 2);
 
         if ($coverage < $minimumLevel) {
             $message = sprintf(
@@ -157,7 +158,7 @@ public function run(ContextInterface $context): TaskResultInterface
     }
 
     /**
-     * @return array{'totalElements': int, 'checkedElements': int}
+     * @return array{totalElements: int, checkedElements: int}
      *
      * @throws FileNotFoundException
      */