Skip to content

Commit b3511b4

Browse files
committed
Fix abstract test case methods to be static for PHPUnit 12
- Make provideSkipsOnStuff method static in abstract class - Update dataProvider annotations to PHPUnit 12 attributes - Handle empty data provider case for BranchName test Made by GitHub Copilot CLI assistant
1 parent 781a2b7 commit b3511b4

2 files changed

Lines changed: 9 additions & 6 deletions

File tree

src/Test/Task/AbstractTaskTestCase.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ abstract public static function provideConfigurableOptions(): iterable;
3333
abstract public function provideRunContexts(): iterable;
3434
abstract public function provideFailsOnStuff(): iterable;
3535
abstract public function providePassesOnStuff(): iterable;
36-
abstract public function provideSkipsOnStuff(): iterable;
36+
abstract public static function provideSkipsOnStuff(): iterable;
3737

3838
protected function setUp(): void
3939
{
@@ -132,10 +132,8 @@ public function it_passes_on_stuff(
132132
self::assertSame('', $result->getMessage());
133133
}
134134

135-
/**
136-
* @test
137-
* @dataProvider provideSkipsOnStuff
138-
*/
135+
#[DataProvider('provideSkipsOnStuff')]
136+
#[Test]
139137
public function it_skips_on_stuff(
140138
array $config,
141139
ContextInterface $context,

test/Unit/Task/Git/BranchNameTest.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@
77
use Gitonomy\Git\Exception\ProcessException;
88
use GrumPHP\Git\GitRepository;
99
use GrumPHP\Task\Git\BranchName;
10+
use GrumPHP\Task\Context\ContextInterface;
1011
use GrumPHP\Task\Context\GitPreCommitContext;
1112
use GrumPHP\Task\Context\RunContext;
1213
use GrumPHP\Task\TaskInterface;
1314
use GrumPHP\Test\Task\AbstractTaskTestCase;
15+
use PHPUnit\Framework\Attributes\Test;
1416
use Prophecy\Argument;
1517
use Prophecy\Prophecy\ObjectProphecy;
1618

@@ -189,6 +191,9 @@ function () {
189191

190192
public static function provideSkipsOnStuff(): iterable
191193
{
192-
return [];
194+
// BranchName task doesn't have skip conditions, so skip this test
195+
if (false) {
196+
yield;
197+
}
193198
}
194199
}

0 commit comments

Comments
 (0)