KM-17485: only remove version

kp-mario-nachbaur · kp-mario-nachbaur · commit 9138ce5f8ad0 · 2026-07-28T09:15:06.000+02:00
Instead of removing the last element every time, which leads to items
disappearing from the side menu every time this method is called, just
remove the intended "version" item.
diff --git a/PIA VPN/UI/Menu/MenuViewController.swift b/PIA VPN/UI/Menu/MenuViewController.swift
@@ -167,7 +167,7 @@ final class MenuViewController: AutolayoutViewController {
 
             } else {
                 labelVersion.text = Macros.localizedVersionFullString()
-                allItems[1].removeLast()
+                allItems[1].removeAll { $0 == .version }
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ final class MenuViewController: AutolayoutViewController {`
`167`	`167`
`168`	`168`	`} else {`
`169`	`169`	`labelVersion.text = Macros.localizedVersionFullString()`
`170`		`- allItems[1].removeLast()`
	`170`	`+ allItems[1].removeAll { $0 == .version }`
`171`	`171`	`}`
`172`	`172`	`}`
`173`	`173`	`}`