KM-13543 Remove FF for Dedicated IP feature

Author: kp-diego-trevisan

PIA VPN/Bootstrapper.swift

@@ -169,7 +169,6 @@ class Bootstrapper {
         }
 
         Client.providers.accountProvider.featureFlags({ _ in
-            AppPreferences.shared.showsDedicatedIPView = Client.configuration.featureFlags.contains(Client.FeatureFlags.dedicatedIp)
             AppPreferences.shared.checksDipExpirationRequest = Client.configuration.featureFlags.contains(Client.FeatureFlags.checkDipExpirationRequest)
             AppPreferences.shared.disablesMultiDipTokens = Client.configuration.featureFlags.contains(Client.FeatureFlags.disableMultiDipTokens)
             AppPreferences.shared.showNewInitialScreen = Client.configuration.featureFlags.contains(Client.FeatureFlags.showNewInitialScreen)

PIA VPN/Global/AppPreferences.swift

@@ -101,7 +101,6 @@ class AppPreferences {
         static let showServiceMessages = "showServiceMessages"
 
         // Features
-        static let showsDedicatedIPView = "showsDedicatedIPView"
         static let disablesMultiDipTokens = "disablesMultiDipTokens"
         static let checksDipExpirationRequest = "checksDipExpirationRequest"
         static let showNewInitialScreen = "showNewInitialScreen"
@@ -513,15 +512,6 @@ class AppPreferences {
         }
     }
 
-    var showsDedicatedIPView: Bool {
-        get {
-            return defaults.bool(forKey: Entries.showsDedicatedIPView)
-        }
-        set {
-            defaults.set(newValue, forKey: Entries.showsDedicatedIPView)
-        }
-    }
-    
     var disablesMultiDipTokens: Bool {
         get {
             return defaults.bool(forKey: Entries.disablesMultiDipTokens)
@@ -647,7 +637,6 @@ class AppPreferences {
             Entries.showGeoServers: true,
             Entries.dismissedMessages: [],
             Entries.showServiceMessages: false,
-            Entries.showsDedicatedIPView: true,
             Entries.disablesMultiDipTokens: true,
             Entries.checksDipExpirationRequest: true,
             Entries.userInteractedWithSurvey: false,

PIA VPN/UI/Menu/MenuViewController.swift

@@ -78,6 +78,7 @@ class MenuViewController: AutolayoutViewController {
         [
             .selectRegion,
             .account,
+            .dedicatedIp,
             .settings,
             .logout
         ], [
@@ -122,11 +123,6 @@ class MenuViewController: AutolayoutViewController {
     override func viewDidLoad() {
         super.viewDidLoad()
 
-        if AppPreferences.shared.showsDedicatedIPView,
-           !allItems[0].contains(.dedicatedIp) {
-            allItems[0].insert(.dedicatedIp, at: 2)
-        }
-        
         Theme.current.applySideMenu()
 
         modalPresentationCapturesStatusBarAppearance = true