KM-17445: skip showing username+password

when we don't know the password there's no point in showing it

Author: kp-mario-nachbaur

LocalPackages/PIALibrary/Sources/PIALibrary/Account/DefaultAccountProvider.swift

@@ -119,7 +119,6 @@ public final class DefaultAccountProvider: AccountProvider, ConfigurationAccess,
             guard let username = accessedDatabase.secure.username() else {
                 return nil
             }
-            // TODO: do we need this???
             let password = accessedDatabase.secure.password(for: username) ?? ""
             return UserAccount(
                 credentials: Credentials(username: username, password: password),

PIA VPN/UI/ConfirmVPNPlanViewController.swift

@@ -135,7 +135,7 @@ final class ConfirmVPNPlanViewController: AutolayoutViewController, BrandableNav
 
                 let alert = Macros.alert(L10n.Signup.Unreachable.vcTitle, L10n.Welcome.Update.Account.Email.error)
                 alert.addActionWithTitle(L10n.Global.close) {
-                    self?.perform(segue: StoryboardSegue.Signup.successShowCredentialsSegueIdentifier)
+                    self?.onSuccess(password: password)
                 }
                 self?.present(alert, animated: true, completion: nil)
 
@@ -144,7 +144,20 @@ final class ConfirmVPNPlanViewController: AutolayoutViewController, BrandableNav
 
             log.debug("Account: Email successfully modified")
             self?.textEmail.endEditing(true)
-            self?.perform(segue: StoryboardSegue.Signup.successShowCredentialsSegueIdentifier)
+            self?.onSuccess(password: password)
+        }
+    }
+
+    private func onSuccess(password: String) {
+        if password.isEmpty {
+            // we skip the screen showing username+password
+            guard let user = config.metadata.user else {
+                log.error("User account not set in metadata")
+                return
+            }
+            config.completionDelegate?.welcomeDidSignup(withUser: user, topViewController: self)
+        } else {
+            perform(segue: StoryboardSegue.Signup.successShowCredentialsSegueIdentifier)
         }
     }