KM-17006 connection stats (#367)

* KM-17006: update ui on the main thread

* KM-17006: remove broken conditional compilation

The protocols are not available on tvOS, but it really doesnt matter if
we keep them on the switch.

Author: kp-mario-nachbaur

LocalPackages/PIALibrary/Sources/PIALibrary/Daemons/ConnectivityDaemon.swift

@@ -91,6 +91,10 @@ final class ConnectivityDaemon: Daemon, ConfigurationAccess, DatabaseAccess, Pre
         networkObserver.whenUnreachable = { [weak self] in
             guard let self else { return }
             DispatchQueue.main.async {
+                guard self.accessedDatabase.transient.vpnStatus != .connecting else {
+                    // while connecting we are unreachable, but expected, skip reporting
+                    return
+                }
                 guard self.accessedDatabase.transient.isNetworkReachable else {
                     return
                 }

LocalPackages/PIALibrary/Sources/PIALibrary/ServiceQuality/ServiceQualityManager.swift

@@ -244,17 +244,14 @@ public final class ServiceQualityManager: NSObject {
     }
 
     private func currentProtocol() -> KPIVpnProtocol {
-
         switch Client.providers.vpnProvider.currentVPNType {
-        case IKEv2Profile.vpnType:
-            return KPIVpnProtocol.ipsec
-        #if (iOS)
-            case PIATunnelProfile.vpnType:
-                return KPIVpnProtocol.ovpn
-            case PIAWGTunnelProfile.vpnType:
-                return KPIVpnProtocol.wireguard
+        case IKEv2Profile.vpnType: return .ipsec
+        #if !os(tvOS)
+            case PIATunnelProfile.vpnType: return .ovpn
+            case PIAWGTunnelProfile.vpnType: return .wireguard
         #endif
-        default:
+        case let other:
+            log.warning("Unknown VPN type: \(other)")
             return KPIVpnProtocol.ipsec
         }
     }

PIA VPN/UI/Menu/ShowConnectionStatsViewController.swift

@@ -27,7 +27,7 @@ import UIKit
 
 private let log = PIALogger.logger(for: ShowConnectionStatsViewController.self)
 
-class ShowConnectionStatsViewController: AutolayoutViewController {
+final class ShowConnectionStatsViewController: AutolayoutViewController {
 
     private var licenseByComponentName: [String: String] = [:]
 
@@ -51,8 +51,10 @@ class ShowConnectionStatsViewController: AutolayoutViewController {
             nc.addObserver(self, selector: #selector(viewHasRotated), name: UIDevice.orientationDidChangeNotification, object: nil)
         }
 
-        ServiceQualityManager.shared.availableData { data in
-            self.textData.text = data.joined(separator: "\n\n")
+        ServiceQualityManager.shared.availableData { [weak self] data in
+            DispatchQueue.main.async {
+                self?.textData.text = data.joined(separator: "\n\n")
+            }
         }
 
         viewDataFooter.isHidden = false