Restore quiet start task failures

Author: jptaylor

src/gradientbang/runtime/orchestrator.py

@@ -3309,19 +3309,12 @@ async def _send_hello_and_wait(self, agent_name: str) -> BusAgentHelloResponse:
 
     async def _handle_start_task_tool(self, params: FunctionCallParams):
         result = await self._handle_start_task(params)
-        if not result.get("success"):
-            # Surface the failure (e.g. ship_busy) so the LLM can decide its
-            # next action — call steer_task with current_task_id, tell the
-            # commander to wait, or ask for clarification. Default
-            # result_callback properties trigger the follow-up inference;
-            # no event injection or forced cycle, mirroring
-            # _handle_stop_task_tool's failure path.
-            await params.result_callback({"result": result})
-            return
         await params.result_callback(
             {"result": result},
             properties=FunctionCallResultProperties(run_llm=False),
         )
+        if not result.get("success"):
+            return
         task_id = str(result.get("task_id", "")).strip()
         task_type = str(result.get("task_type", "player_ship")).strip() or "player_ship"
         steered = bool(result.get("steered"))

tests/unit/test_voice_agent.py

@@ -1203,7 +1203,7 @@ async def test_start_task_tool_success_queues_started_event(self):
         assert "Task started" in deferred_frame.messages[0]["content"]
 
     @pytest.mark.asyncio
-    async def test_start_task_tool_failure_surfaces_result_without_event_injection(self):
+    async def test_start_task_tool_failure_stays_quiet(self):
         agent = _make_orchestrator()
         result = {
             "success": False,
@@ -1216,11 +1216,10 @@ async def test_start_task_tool_failure_surfaces_result_without_event_injection(s
 
         await agent._handle_start_task_tool(params)
 
-        # Default result_callback (no FunctionCallResultProperties) lets the
-        # LLM run on its tool result so it can speak the failure message.
         params.result_callback.assert_awaited_once()
         assert params.result_callback.await_args.args[0] == {"result": result}
-        assert "properties" not in params.result_callback.await_args.kwargs
+        properties = params.result_callback.await_args.kwargs["properties"]
+        assert properties.run_llm is False
         # No task.started/task.steered event_xml on failure — the tool result
         # is the only signal.
         assert len(agent._deferred_frames) == 0