fix bot crash: pin Deno to v2.7.14 and use defineProperty for serve monkey-patch (#412)

Deno 2.8.0 converted Deno.serve into a lazy getter with no setter, so
server.ts's `(Deno as any).serve = stub` assignment now throws
"Cannot set property serve … which has only a getter" and the bot
container fails to start.

- Pin Deno to v2.7.14 in Dockerfile.bot (last 2.7.x, pre-getter)
- Replace plain assignment with Object.defineProperty in server.ts,
  which bypasses the getter and survives a future bump to 2.8.x

Author: jptaylor

deployment/Dockerfile.bot

@@ -11,10 +11,13 @@ ENV PCC_LOG_FEATURES_SUMMARY=true
 
 ENV PYTHONPATH=/app
 
-# Install Deno for running edge functions locally
+# Install Deno for running edge functions locally.
+# Pinned: Deno 2.8.0 made Deno.serve a lazy getter, breaking the
+# monkey-patch in edge-functions/server.ts. Stay on the last 2.7.x.
 ENV DENO_INSTALL=/root/.deno
+ENV DENO_VERSION=v2.7.14
 RUN apt-get update && apt-get install -y --no-install-recommends curl unzip git \
-    && curl -fsSL https://deno.land/install.sh | sh \
+    && curl -fsSL https://deno.land/install.sh | sh -s "${DENO_VERSION}" \
     && apt-get purge -y curl unzip && apt-get autoremove -y \
     && rm -rf /var/lib/apt/lists/*
 ENV PATH="${DENO_INSTALL}/bin:${PATH}"

deployment/supabase/functions/server.ts

@@ -41,25 +41,32 @@ let currentFunctionName = "";
 // Save the real Deno.serve so we can restore it later
 const realServe = Deno.serve.bind(Deno);
 
-// Replace Deno.serve with a stub that captures the handler
-// deno-lint-ignore no-explicit-any
-(Deno as any).serve = (handlerOrOpts: any, maybeHandler?: any) => {
-  const fn: Handler | undefined =
-    typeof handlerOrOpts === "function" ? handlerOrOpts : maybeHandler;
-  if (currentFunctionName && fn) {
-    routes[currentFunctionName] = fn;
-  }
-  // Return a fake Deno.HttpServer to satisfy any callers
-  return {
-    finished: Promise.resolve(),
-    ref() {},
-    unref() {},
-    shutdown() {
-      return Promise.resolve();
-    },
-    addr: { port: 0, hostname: "localhost", transport: "tcp" as const },
-  };
-};
+// Replace Deno.serve with a stub that captures the handler.
+// Deno 2.8+ defines Deno.serve as a lazy getter with no setter, so plain
+// assignment throws "Cannot set property serve … which has only a getter".
+// defineProperty bypasses the getter because the property is configurable.
+Object.defineProperty(Deno, "serve", {
+  // deno-lint-ignore no-explicit-any
+  value: (handlerOrOpts: any, maybeHandler?: any) => {
+    const fn: Handler | undefined =
+      typeof handlerOrOpts === "function" ? handlerOrOpts : maybeHandler;
+    if (currentFunctionName && fn) {
+      routes[currentFunctionName] = fn;
+    }
+    // Return a fake Deno.HttpServer to satisfy any callers
+    return {
+      finished: Promise.resolve(),
+      ref() {},
+      unref() {},
+      shutdown() {
+        return Promise.resolve();
+      },
+      addr: { port: 0, hostname: "localhost", transport: "tcp" as const },
+    };
+  },
+  configurable: true,
+  writable: true,
+});
 
 // Dynamically import each edge function — Deno.serve inside each module
 // will call our stub, populating `routes`.
@@ -73,9 +80,12 @@ for (const name of functionNames) {
 }
 currentFunctionName = "";
 
-// Restore the real Deno.serve
-// deno-lint-ignore no-explicit-any
-(Deno as any).serve = realServe;
+// Restore the real Deno.serve (see defineProperty note above)
+Object.defineProperty(Deno, "serve", {
+  value: realServe,
+  configurable: true,
+  writable: true,
+});
 
 const loadedCount = Object.keys(routes).length;
 console.log(