Skip to content

Commit 4b438b6

Browse files
mvaligurskyMartin Valigursky
andauthored
Remove unused Camera.beforePasses (#8957)
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
1 parent 22b706e commit 4b438b6

2 files changed

Lines changed: 0 additions & 29 deletions

File tree

src/scene/camera.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -117,14 +117,6 @@ class Camera {
117117
*/
118118
framePasses = [];
119119

120-
/**
121-
* Frame passes that execute before this camera's main scene rendering. Entries are picked up
122-
* by the RenderPassForward that renders this camera's layers.
123-
*
124-
* @type {FramePass[]}
125-
*/
126-
beforePasses = [];
127-
128120
/** @type {number} */
129121
jitter = 0;
130122

src/scene/renderer/render-pass-forward.js

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -168,26 +168,6 @@ class RenderPassForward extends RenderPass {
168168
return index;
169169
}
170170

171-
// Collect before-passes from cameras whose first render action lives in this
172-
// RenderPassForward. Uses the existing firstCameraUse flag (set by LayerComposition)
173-
// to guarantee each camera's before-passes are scheduled exactly once, even when
174-
// multiple RenderPassForward instances reference the same camera (e.g. CameraFrame's
175-
// scenePass vs afterPass).
176-
updateCameraBeforePasses() {
177-
for (let i = 0; i < this.renderActions.length; i++) {
178-
const ra = this.renderActions[i];
179-
if (ra.firstCameraUse) {
180-
const camera = ra.camera?.camera;
181-
if (camera) {
182-
const { beforePasses } = camera;
183-
for (let j = 0; j < beforePasses.length; j++) {
184-
this.beforePasses.push(beforePasses[j]);
185-
}
186-
}
187-
}
188-
}
189-
}
190-
191171
updateDirectionalShadows() {
192172
// add directional shadow passes if needed for the cameras used in this render pass
193173
const { renderer, renderActions } = this;
@@ -237,7 +217,6 @@ class RenderPassForward extends RenderPass {
237217

238218
frameUpdate() {
239219
super.frameUpdate();
240-
this.updateCameraBeforePasses();
241220
this.updateDirectionalShadows();
242221
this.updateClears();
243222
}

0 commit comments

Comments
 (0)