Skip to content

Commit 6f875f7

Browse files
mvaligurskyMartin Valigursky
mvaligursky
and
Martin Valigursky
authored
refactor(gsplat): remove the compute renderer (#8921)
Removes the experimental, unmaintained gsplat compute-local renderer (GSPLAT_RENDERER_COMPUTE) to simplify the gsplat pipeline ahead of further refactoring. The hybrid (GPU-sort) and CPU-sort paths are untouched. GSPLAT_RENDERER_COMPUTE and GSPLAT_DEBUG_HEATMAP are kept but deprecated: setting them now logs a Debug.removed warning and falls back to GSPLAT_RENDERER_AUTO / is ignored. They will be removed in a future release. Deletes the compute renderer, its frame pass, dispatch set, tile compositor, and 15 WGSL compute/tile-composite shader chunks; removes the compute branches and compactGpu from GSplatManager. Updates gsplat example control panels to drop the Compute renderer and Heatmap debug options, and the benchmark's compute row. Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
1 parent d47e281 commit 6f875f7

59 files changed

Lines changed: 63 additions & 3792 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎examples/src/examples/gaussian-splatting-xr/vr-lod.controls.jsx‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ export function Controls({ observer }) {
2929
options={[
3030
{ v: 0, t: 'Auto' },
3131
{ v: 1, t: 'Raster (CPU Sort)' },
32-
{ v: 2, t: 'Raster (GPU Sort)' },
33-
{ v: 3, t: 'Compute' }
32+
{ v: 2, t: 'Raster (GPU Sort)' }
3433
]}
3534
/>
3635
</LabelGroup>

‎examples/src/examples/gaussian-splatting/annotations.controls.jsx‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ export function Controls({ observer }) {
2828
options={[
2929
{ v: 0, t: 'Auto' },
3030
{ v: 1, t: 'Raster (CPU Sort)' },
31-
{ v: 2, t: 'Raster (GPU Sort)' },
32-
{ v: 3, t: 'Compute' }
31+
{ v: 2, t: 'Raster (GPU Sort)' }
3332
]}
3433
/>
3534
</LabelGroup>

‎examples/src/examples/gaussian-splatting/benchmark.example.mjs‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ const IDLE_FPS_SAMPLE_MS = 1000;
3232
const RENDERERS = [
3333
{ device: 'webgl2', renderer: pc.GSPLAT_RENDERER_RASTER_CPU_SORT, label: 'WebGL2 CPU Sort', shortLabel: 'GL2 CPU' },
3434
{ device: 'webgpu', renderer: pc.GSPLAT_RENDERER_RASTER_CPU_SORT, label: 'WebGPU CPU Sort', shortLabel: 'GPU CPU' },
35-
{ device: 'webgpu', renderer: pc.GSPLAT_RENDERER_RASTER_GPU_SORT, label: 'WebGPU GPU Sort', shortLabel: 'GPU Sort' },
36-
{ device: 'webgpu', renderer: pc.GSPLAT_RENDERER_COMPUTE, label: 'WebGPU Compute', shortLabel: 'Compute' }
35+
{ device: 'webgpu', renderer: pc.GSPLAT_RENDERER_RASTER_GPU_SORT, label: 'WebGPU GPU Sort', shortLabel: 'GPU Sort' }
3736
];
3837

3938
const BUDGETS = [1, 2, 3, 4, 6, 8, 10, 15, 20, 25, 30, 35]; // millions

‎examples/src/examples/gaussian-splatting/clipping.controls.jsx‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ export function Controls({ observer }) {
3838
options={[
3939
{ v: 0, t: 'Auto' },
4040
{ v: 1, t: 'Raster (CPU Sort)' },
41-
{ v: 2, t: 'Raster (GPU Sort)' },
42-
{ v: 3, t: 'Compute' }
41+
{ v: 2, t: 'Raster (GPU Sort)' }
4342
]}
4443
/>
4544
</LabelGroup>

‎examples/src/examples/gaussian-splatting/crop.controls.jsx‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ export function Controls({ observer }) {
2828
options={[
2929
{ v: 0, t: 'Auto' },
3030
{ v: 1, t: 'Raster (CPU Sort)' },
31-
{ v: 2, t: 'Raster (GPU Sort)' },
32-
{ v: 3, t: 'Compute' }
31+
{ v: 2, t: 'Raster (GPU Sort)' }
3332
]}
3433
/>
3534
</LabelGroup>

‎examples/src/examples/gaussian-splatting/editor.controls.jsx‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ export function Controls({ observer }) {
2929
options={[
3030
{ v: 0, t: 'Auto' },
3131
{ v: 1, t: 'Raster (CPU Sort)' },
32-
{ v: 2, t: 'Raster (GPU Sort)' },
33-
{ v: 3, t: 'Compute' }
32+
{ v: 2, t: 'Raster (GPU Sort)' }
3433
]}
3534
/>
3635
</LabelGroup>

‎examples/src/examples/gaussian-splatting/first-person.controls.jsx‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ export function Controls({ observer }) {
2929
options={[
3030
{ v: 0, t: 'Auto' },
3131
{ v: 1, t: 'Raster (CPU Sort)' },
32-
{ v: 2, t: 'Raster (GPU Sort)' },
33-
{ v: 3, t: 'Compute' }
32+
{ v: 2, t: 'Raster (GPU Sort)' }
3433
]}
3534
/>
3635
</LabelGroup>

‎examples/src/examples/gaussian-splatting/flipbook.controls.jsx‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ export function Controls({ observer }) {
2121
options={[
2222
{ v: 0, t: 'Auto' },
2323
{ v: 1, t: 'Raster (CPU Sort)' },
24-
{ v: 2, t: 'Raster (GPU Sort)' },
25-
{ v: 3, t: 'Compute' }
24+
{ v: 2, t: 'Raster (GPU Sort)' }
2625
]}
2726
/>
2827
</LabelGroup>

‎examples/src/examples/gaussian-splatting/global-sorting.controls.jsx‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ export function Controls({ observer }) {
2121
options={[
2222
{ v: 0, t: 'Auto' },
2323
{ v: 1, t: 'Raster (CPU Sort)' },
24-
{ v: 2, t: 'Raster (GPU Sort)' },
25-
{ v: 3, t: 'Compute' }
24+
{ v: 2, t: 'Raster (GPU Sort)' }
2625
]}
2726
/>
2827
</LabelGroup>

‎examples/src/examples/gaussian-splatting/lod-instances.controls.jsx‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ export function Controls({ observer }) {
3030
options={[
3131
{ v: 0, t: 'Auto' },
3232
{ v: 1, t: 'Raster (CPU Sort)' },
33-
{ v: 2, t: 'Raster (GPU Sort)' },
34-
{ v: 3, t: 'Compute' }
33+
{ v: 2, t: 'Raster (GPU Sort)' }
3534
]}
3635
/>
3736
</LabelGroup>

0 commit comments

Comments
 (0)