Merging of #1695. Thanks @RafalUrbanski

Author: bjansen

src/sdk/CHANGELOG.md

@@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Page API: fix to retain empty, collapsible sections #1682 [czullu - Christian Zuellig]
 - Page API: fix to retain NoImage setting on custom page header #1682 [czullu - Christian Zuellig]
 - Page API: support for setting the header size of collapsible sections #1687 [shunsaker - Shayne Hunsaker]
+- Support for setting and getting the DisableCommenting property of a list #1695 [RafalUrbanski - Rafal Urbanski]
 
 ### Changed
 

src/sdk/PnP.Core.Test/SharePoint/MockData/ListTests/DisableCommentingSettingDefaultValueTest-0-00000.response.json

@@ -0,0 +1 @@
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"9934c9a1-401e-e000-16ec-194150db6dc6","SPClientServiceRequestDuration":"13","X-SharePointHealthScore":"0","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022RegionalSettings\u0022:{\u0022TimeZone\u0022:{\u0022Description\u0022:\u0022(UTC-08:00) Pacific Time (US and Canada)\u0022,\u0022Id\u0022:13,\u0022Information\u0022:{\u0022Bias\u0022:480,\u0022DaylightBias\u0022:-60,\u0022StandardBias\u0022:0}},\u0022AdjustHijriDays\u0022:0,\u0022AlternateCalendarType\u0022:0,\u0022AM\u0022:\u0022AM\u0022,\u0022CalendarType\u0022:1,\u0022Collation\u0022:25,\u0022CollationLCID\u0022:2070,\u0022DateFormat\u0022:0,\u0022DateSeparator\u0022:\u0022/\u0022,\u0022DecimalSeparator\u0022:\u0022.\u0022,\u0022DigitGrouping\u0022:\u00223;0\u0022,\u0022FirstDayOfWeek\u0022:0,\u0022FirstWeekOfYear\u0022:0,\u0022IsEastAsia\u0022:false,\u0022IsRightToLeft\u0022:false,\u0022IsUIRightToLeft\u0022:false,\u0022ListSeparator\u0022:\u0022,\u0022,\u0022LocaleId\u0022:1033,\u0022NegativeSign\u0022:\u0022-\u0022,\u0022NegNumberMode\u0022:1,\u0022PM\u0022:\u0022PM\u0022,\u0022PositiveSign\u0022:\u0022\u0022,\u0022ShowWeeks\u0022:false,\u0022ThousandSeparator\u0022:\u0022,\u0022,\u0022Time24\u0022:false,\u0022TimeMarkerPosition\u0022:0,\u0022TimeSeparator\u0022:\u0022:\u0022,\u0022WorkDayEndHour\u0022:1020,\u0022WorkDays\u0022:62,\u0022WorkDayStartHour\u0022:480},\u0022Id\u0022:\u00222c99a486-d6c9-4a4b-8d6f-a9faa364c92c\u0022,\u0022Url\u0022:\u0022https://bertonline.sharepoint.com/sites/prov-2\u0022}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/ListTests/DisableCommentingSettingDefaultValueTest-0-00001.response.json

@@ -0,0 +1 @@
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"9934c9a1-f02c-e000-16ec-1a1e34e9979b","SPClientServiceRequestDuration":"14","X-SharePointHealthScore":"0","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022GroupId\u0022:\u0022d40d729b-df60-4b57-ac8f-102595090e0a\u0022,\u0022Id\u0022:\u0022f92f9e40-1110-43ef-aa0e-0822e13fb7ba\u0022}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/ListTests/DisableCommentingSettingDefaultValueTest-0-00002.response.json

@@ -0,0 +1 @@
+{"IsSuccessStatusCode":false,"StatusCode":404,"Headers":{"SPRequestGuid":"9934c9a1-80e6-e000-16ec-18da8b3d45e8","SPClientServiceRequestDuration":"15","X-SharePointHealthScore":"1","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022odata.error\u0022:{\u0022code\u0022:\u0022-1, System.ArgumentException\u0022,\u0022message\u0022:{\u0022lang\u0022:\u0022en-US\u0022,\u0022value\u0022:\u0022List \u0027DisableCommentingListSettingsTest\u0027 does not exist at site with URL \u0027https://bertonline.sharepoint.com/sites/prov-2\u0027.\u0022}}}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/ListTests/DisableCommentingSettingDefaultValueTest-0-00003.response.json

@@ -0,0 +1 @@
+{"IsSuccessStatusCode":true,"StatusCode":201,"Headers":{"SPRequestGuid":"9a34c9a1-d055-e000-16ec-10c610fe86d9","SPClientServiceRequestDuration":"627","X-SharePointHealthScore":"3","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022AllowContentTypes\u0022:true,\u0022BaseTemplate\u0022:100,\u0022BaseType\u0022:0,\u0022ContentTypesEnabled\u0022:false,\u0022CrawlNonDefaultViews\u0022:false,\u0022Created\u0022:\u00222025-09-25T13:42:53Z\u0022,\u0022CurrentChangeToken\u0022:{\u0022StringValue\u0022:\u00221;3;9ff71512-05ee-4e31-9094-a3fee32999c4;638944045731130000;1038112977\u0022},\u0022DefaultContentApprovalWorkflowId\u0022:\u002200000000-0000-0000-0000-000000000000\u0022,\u0022DefaultItemOpenUseListSetting\u0022:false,\u0022Description\u0022:\u0022\u0022,\u0022Direction\u0022:\u0022none\u0022,\u0022DisableCommenting\u0022:false,\u0022DisableGridEditing\u0022:false,\u0022DocumentTemplateUrl\u0022:null,\u0022DraftVersionVisibility\u0022:0,\u0022EnableAttachments\u0022:true,\u0022EnableFolderCreation\u0022:false,\u0022EnableMinorVersions\u0022:false,\u0022EnableModeration\u0022:false,\u0022EnableRequestSignOff\u0022:true,\u0022EnableVersioning\u0022:true,\u0022EntityTypeName\u0022:\u0022DisableCommentingListSettingsTestList\u0022,\u0022ExemptFromBlockDownloadOfNonViewableFiles\u0022:false,\u0022FileSavePostProcessingEnabled\u0022:false,\u0022ForceCheckout\u0022:false,\u0022HasExternalDataSource\u0022:false,\u0022Hidden\u0022:false,\u0022Id\u0022:\u00229ff71512-05ee-4e31-9094-a3fee32999c4\u0022,\u0022ImagePath\u0022:{\u0022DecodedUrl\u0022:\u0022/_layouts/15/images/itgen.png?rev=47\u0022},\u0022ImageUrl\u0022:\u0022/_layouts/15/images/itgen.png?rev=47\u0022,\u0022DefaultSensitivityLabelForLibrary\u0022:\u0022\u0022,\u0022SensitivityLabelToEncryptOnDownloadForLibrary\u0022:null,\u0022IrmEnabled\u0022:false,\u0022IrmExpire\u0022:false,\u0022IrmReject\u0022:false,\u0022IsApplicationList\u0022:false,\u0022IsCatalog\u0022:false,\u0022IsPrivate\u0022:false,\u0022ItemCount\u0022:0,\u0022LastItemDeletedDate\u0022:\u00222025-09-25T13:42:53Z\u0022,\u0022LastItemModifiedDate\u0022:\u00222025-09-25T13:42:53Z\u0022,\u0022LastItemUserModifiedDate\u0022:\u00222025-09-25T13:42:53Z\u0022,\u0022ListExperienceOptions\u0022:0,\u0022ListItemEntityTypeFullName\u0022:\u0022SP.Data.DisableCommentingListSettingsTestListItem\u0022,\u0022MajorVersionLimit\u0022:50,\u0022MajorWithMinorVersionsLimit\u0022:0,\u0022MultipleDataList\u0022:false,\u0022NoCrawl\u0022:false,\u0022ParentWebPath\u0022:{\u0022DecodedUrl\u0022:\u0022/sites/prov-2\u0022},\u0022ParentWebUrl\u0022:\u0022/sites/prov-2\u0022,\u0022ParserDisabled\u0022:false,\u0022ServerTemplateCanCreateFolders\u0022:true,\u0022TemplateFeatureId\u0022:\u002200bfea71-de22-43b2-a848-c05709900100\u0022,\u0022Title\u0022:\u0022DisableCommentingListSettingsTest\u0022}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/ListTests/DisableCommentingSettingDefaultValueTest-0-00004.response.json

@@ -0,0 +1 @@
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"9a34c9a1-f0f6-e000-16ec-1356c212dfc7","SPClientServiceRequestDuration":"18","X-SharePointHealthScore":"3","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022DisableCommenting\u0022:false,\u0022Id\u0022:\u00229ff71512-05ee-4e31-9094-a3fee32999c4\u0022}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/ListTests/DisableCommentingSettingDefaultValueTest-0-00005.response.json

@@ -0,0 +1 @@
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"9d34c9a1-c01d-e000-16ec-1feceea3d23a","SPClientServiceRequestDuration":"200","X-SharePointHealthScore":"1","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":""}

src/sdk/PnP.Core.Test/SharePoint/MockData/ListTests/DisableCommentingSettingTest-0-00000.response.json

@@ -0,0 +1 @@
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"a434c9a1-d07f-e000-16ec-1657d1d07f83","SPClientServiceRequestDuration":"11","X-SharePointHealthScore":"0","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022RegionalSettings\u0022:{\u0022TimeZone\u0022:{\u0022Description\u0022:\u0022(UTC-08:00) Pacific Time (US and Canada)\u0022,\u0022Id\u0022:13,\u0022Information\u0022:{\u0022Bias\u0022:480,\u0022DaylightBias\u0022:-60,\u0022StandardBias\u0022:0}},\u0022AdjustHijriDays\u0022:0,\u0022AlternateCalendarType\u0022:0,\u0022AM\u0022:\u0022AM\u0022,\u0022CalendarType\u0022:1,\u0022Collation\u0022:25,\u0022CollationLCID\u0022:2070,\u0022DateFormat\u0022:0,\u0022DateSeparator\u0022:\u0022/\u0022,\u0022DecimalSeparator\u0022:\u0022.\u0022,\u0022DigitGrouping\u0022:\u00223;0\u0022,\u0022FirstDayOfWeek\u0022:0,\u0022FirstWeekOfYear\u0022:0,\u0022IsEastAsia\u0022:false,\u0022IsRightToLeft\u0022:false,\u0022IsUIRightToLeft\u0022:false,\u0022ListSeparator\u0022:\u0022,\u0022,\u0022LocaleId\u0022:1033,\u0022NegativeSign\u0022:\u0022-\u0022,\u0022NegNumberMode\u0022:1,\u0022PM\u0022:\u0022PM\u0022,\u0022PositiveSign\u0022:\u0022\u0022,\u0022ShowWeeks\u0022:false,\u0022ThousandSeparator\u0022:\u0022,\u0022,\u0022Time24\u0022:false,\u0022TimeMarkerPosition\u0022:0,\u0022TimeSeparator\u0022:\u0022:\u0022,\u0022WorkDayEndHour\u0022:1020,\u0022WorkDays\u0022:62,\u0022WorkDayStartHour\u0022:480},\u0022Id\u0022:\u00222c99a486-d6c9-4a4b-8d6f-a9faa364c92c\u0022,\u0022Url\u0022:\u0022https://bertonline.sharepoint.com/sites/prov-2\u0022}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/ListTests/DisableCommentingSettingTest-0-00001.response.json

@@ -0,0 +1 @@
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"a434c9a1-708e-e000-16ec-1690bc0fd6f2","SPClientServiceRequestDuration":"19","X-SharePointHealthScore":"3","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022GroupId\u0022:\u0022d40d729b-df60-4b57-ac8f-102595090e0a\u0022,\u0022Id\u0022:\u0022f92f9e40-1110-43ef-aa0e-0822e13fb7ba\u0022}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/ListTests/DisableCommentingSettingTest-0-00002.response.json

@@ -0,0 +1 @@
+{"IsSuccessStatusCode":false,"StatusCode":404,"Headers":{"SPRequestGuid":"a434c9a1-20ee-e000-16ec-1d275ff8dac2","SPClientServiceRequestDuration":"15","X-SharePointHealthScore":"1","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022odata.error\u0022:{\u0022code\u0022:\u0022-1, System.ArgumentException\u0022,\u0022message\u0022:{\u0022lang\u0022:\u0022en-US\u0022,\u0022value\u0022:\u0022List \u0027DisableCommentingListSettingsTest\u0027 does not exist at site with URL \u0027https://bertonline.sharepoint.com/sites/prov-2\u0027.\u0022}}}"}