Skip to content

Security: TaskManager self-review bypass for project managers #127

@hudsonhrh

Description

@hudsonhrh

Problem

In TaskManager.completeTask, the self-review guard is bypassed when the caller is a project manager (_isPM check). A project manager can claim a task, submit work, and approve their own submission — minting participation tokens and receiving bounties without independent review.

Location

src/TaskManager.solcompleteTask function, around line 537-543

Impact

Medium — A malicious or compromised project manager can self-award tokens and bounties, though they are already a trusted role within the project scope.

Recommended Fix

Remove the _isPM exemption from the self-review check, requiring even PMs to have another reviewer complete their tasks. Alternatively, add a separate PM_SELF_REVIEW permission flag.

Severity

Medium — Backlog

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions