First off, awesome work on this ripper! I love it and have used it for literally over a decade by now.
However:
There is an issue where the album art gets copied to the artist folder rather than the album folder (or rather, to the folder above the output folder) under some circumstances.
The issue is that the target directory is attempted found by evaluating the target filename and grabbing the directory of that. All well and good, except the evaluation happens at a time where the track-specific variables are empty. If the evaluation then ends up with no actual filename, the dirname at the line below ends up cutting the last layer off the directory structure.
|
FINALALBUMARTDIR="$(dirname "$OUTPUTDIR/$ALBUMARTDIR")" |
Example:
Say my configuration has the following output format:
OUTPUTFORMAT='${OUTPUT}/${ARTISTFILE}/${ALBUMFILE}/${TRACKNUM} ${TRACKFILE}'
Without the track-specific variables, this might evaluate to /home/alice/Music/mp3/bob/bobbing/
dirname then evaluates this to /home/alice/Music/mp3/bob into which the album art is then copied.
There are several ways to fix this issue, I've just thrown something at the end of that line to make it always contain a "filename" for dirname to strip, but that feels kind of dirty.
First off, awesome work on this ripper! I love it and have used it for literally over a decade by now.
However:
There is an issue where the album art gets copied to the artist folder rather than the album folder (or rather, to the folder above the output folder) under some circumstances.
The issue is that the target directory is attempted found by evaluating the target filename and grabbing the directory of that. All well and good, except the evaluation happens at a time where the track-specific variables are empty. If the evaluation then ends up with no actual filename, the
dirnameat the line below ends up cutting the last layer off the directory structure.abcde/abcde
Line 3738 in d793fa5
Example:
Say my configuration has the following output format:
Without the track-specific variables, this might evaluate to
/home/alice/Music/mp3/bob/bobbing/dirnamethen evaluates this to/home/alice/Music/mp3/bobinto which the album art is then copied.There are several ways to fix this issue, I've just thrown something at the end of that line to make it always contain a "filename" for
dirnameto strip, but that feels kind of dirty.