buildah/pkg/util/util_test.go at de5bd7ac77eb9ba7642dc673b972dddc9b9bff7e · podman-container-tools/buildah · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
package util //nolint:revive,nolintlint

import (
	"io/fs"
	"os"
	"path/filepath"
	"testing"

	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
)

func absPath(t *testing.T, rel string) string {
	t.Helper()
	p, err := filepath.Abs(rel)
	require.NoError(t, err)
	return p
}

func TestDiscoverContainerfile(t *testing.T) {
	t.Parallel()
	_, err := DiscoverContainerfile("./bogus")
	assert.NotNil(t, err)

	_, err = DiscoverContainerfile("./")
	assert.NotNil(t, err)

	name, err := DiscoverContainerfile("test/test1/Dockerfile")
	assert.Nil(t, err)
	assert.Equal(t, absPath(t, "test/test1/Dockerfile"), name)

	name, err = DiscoverContainerfile("test/test1/Containerfile")
	assert.Nil(t, err)
	assert.Equal(t, absPath(t, "test/test1/Containerfile"), name)

	name, err = DiscoverContainerfile("test/test1")
	assert.Nil(t, err)
	assert.Equal(t, absPath(t, "test/test1/Containerfile"), name)

	name, err = DiscoverContainerfile("test/test2")
	assert.Nil(t, err)
	assert.Equal(t, absPath(t, "test/test2/Dockerfile"), name)
}

func TestDiscoverContainerfileRejectsSymlinkOutsideContext(t *testing.T) {
	t.Parallel()
	tmpDir := t.TempDir()

	secretFile := filepath.Join(tmpDir, "secret-Containerfile")
	require.NoError(t, os.WriteFile(secretFile, []byte("FROM scratch\n"), 0o644))

	contextDir := filepath.Join(tmpDir, "context")
	require.NoError(t, os.Mkdir(contextDir, 0o755))
	require.NoError(t, os.Symlink(secretFile, filepath.Join(contextDir, "Containerfile")))

	_, err := DiscoverContainerfile(contextDir)
	assert.Error(t, err)
	assert.ErrorIs(t, err, fs.ErrNotExist)
}

func TestDiscoverContainerfileAcceptsSymlinkInsideContext(t *testing.T) {
	t.Parallel()
	contextDir := t.TempDir()

	subdir := filepath.Join(contextDir, "subdir")
	require.NoError(t, os.Mkdir(subdir, 0o755))
	require.NoError(t, os.WriteFile(filepath.Join(subdir, "Containerfile.real"), []byte("FROM scratch\n"), 0o644))
	require.NoError(t, os.Symlink(filepath.Join("subdir", "Containerfile.real"), filepath.Join(contextDir, "Containerfile")))

	name, err := DiscoverContainerfile(contextDir)
	require.NoError(t, err)
	assert.Equal(t, filepath.Join(contextDir, "subdir", "Containerfile.real"), name)
}

func TestDiscoverContainerfileAcceptsEscapeClampedToRoot(t *testing.T) {
	t.Parallel()
	tmpDir := t.TempDir()

	contextDir := filepath.Join(tmpDir, "context")
	require.NoError(t, os.Mkdir(contextDir, 0o755))
	require.NoError(t, os.WriteFile(filepath.Join(contextDir, "file"), []byte("FROM scratch\n"), 0o644))
	require.NoError(t, os.Symlink("../file", filepath.Join(contextDir, "Containerfile")))

	name, err := DiscoverContainerfile(contextDir)
	require.NoError(t, err)
	assert.Equal(t, filepath.Join(contextDir, "file"), name)
}

func TestDiscoverContainerfileAcceptsAbsoluteSymlinkRerooted(t *testing.T) {
	t.Parallel()
	contextDir := t.TempDir()

	subdir := filepath.Join(contextDir, "subdirectory")
	require.NoError(t, os.Mkdir(subdir, 0o755))
	require.NoError(t, os.WriteFile(filepath.Join(subdir, "real.file"), []byte("FROM scratch\n"), 0o644))
	require.NoError(t, os.Symlink("/subdirectory/real.file", filepath.Join(contextDir, "Containerfile")))

	name, err := DiscoverContainerfile(contextDir)
	require.NoError(t, err)
	assert.Equal(t, filepath.Join(contextDir, "subdirectory", "real.file"), name)
}

func TestDiscoverContainerfileAcceptsMultiLevelEscapeClampedToRoot(t *testing.T) {
	t.Parallel()
	tmpDir := t.TempDir()

	contextDir := filepath.Join(tmpDir, "context")
	require.NoError(t, os.Mkdir(contextDir, 0o755))
	subdir := filepath.Join(contextDir, "subdir")
	require.NoError(t, os.Mkdir(subdir, 0o755))
	require.NoError(t, os.WriteFile(filepath.Join(subdir, "file"), []byte("FROM scratch\n"), 0o644))
	require.NoError(t, os.Symlink("../../subdir/file", filepath.Join(contextDir, "Containerfile")))

	name, err := DiscoverContainerfile(contextDir)
	require.NoError(t, err)
	assert.Equal(t, filepath.Join(contextDir, "subdir", "file"), name)
}

func TestDiscoverContainerfileAcceptsSymlinkedDirectory(t *testing.T) {
	t.Parallel()
	tmpDir := t.TempDir()

	realDir := filepath.Join(tmpDir, "real-context")
	require.NoError(t, os.Mkdir(realDir, 0o755))
	require.NoError(t, os.WriteFile(filepath.Join(realDir, "Containerfile"), []byte("FROM scratch\n"), 0o644))

	symlinkedDir := filepath.Join(tmpDir, "symlinked-context")
	require.NoError(t, os.Symlink(realDir, symlinkedDir))

	name, err := DiscoverContainerfile(symlinkedDir)
	require.NoError(t, err)
	assert.Equal(t, filepath.Join(symlinkedDir, "Containerfile"), name)
}

func TestDiscoverContainerfileRejectsNonExistentClampedTarget(t *testing.T) {
	t.Parallel()
	tmpDir := t.TempDir()

	contextDir := filepath.Join(tmpDir, "context")
	require.NoError(t, os.Mkdir(contextDir, 0o755))
	require.NoError(t, os.Symlink("../nonexistent", filepath.Join(contextDir, "Containerfile")))

	_, err := DiscoverContainerfile(contextDir)
	assert.Error(t, err)
	assert.ErrorIs(t, err, fs.ErrNotExist)
}