Skip to content

Commit 90e4cd3

Browse files
authored
Rename "latest" tag to nightly (#22)
It is more accurate as it is based on the nightly ponyc image releases.
1 parent 7f29de6 commit 90e4cd3

4 files changed

Lines changed: 25 additions & 26 deletions

File tree

.github/workflows/pr.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,13 @@ jobs:
3838
- name: Docker build
3939
run: make build-release config=public
4040

41-
validate-public-latest-image-builds:
42-
name: Validate public latest image builds
41+
validate-public-nightly-image-builds:
42+
name: Validate public nightly image builds
4343
runs-on: ubuntu-latest
4444
steps:
4545
- uses: actions/checkout@v4.1.1
4646
- name: Docker build
47-
run: make build-latest config=public
47+
run: make build-nightly config=public
4848

4949
validate-private-release-image-builds:
5050
name: Validate private release image builds
@@ -56,13 +56,12 @@ jobs:
5656
env:
5757
MATERIAL_INSIDERS_ACCESS: ${{ secrets.MATERIAL_INSIDERS_ACCESS }}
5858

59-
validate-private-latest-image-builds:
60-
name: Validate private latest image builds
59+
validate-private-nightly-image-builds:
60+
name: Validate private nightly image builds
6161
runs-on: ubuntu-latest
6262
steps:
6363
- uses: actions/checkout@v4.1.1
6464
- name: Docker build
65-
run: make build-latest config=private
65+
run: make build-nightly config=private
6666
env:
6767
MATERIAL_INSIDERS_ACCESS: ${{ secrets.MATERIAL_INSIDERS_ACCESS }}
68-

.github/workflows/update-latest-image.yml renamed to .github/workflows/update-nightly-image.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Update latest images
1+
name: Update nightly images
22

33
on:
44
repository_dispatch:
@@ -10,12 +10,12 @@ on:
1010
- main
1111

1212
concurrency:
13-
group: "rebuild-latest-images"
13+
group: "rebuild-nightly-images"
1414
cancel-in-progress: true
1515

1616
jobs:
17-
rebuild-public-latest-image:
18-
name: Rebuild latest public image
17+
rebuild-public-nightly-image:
18+
name: Rebuild nightly public image
1919
runs-on: ubuntu-latest
2020
steps:
2121
- name: Checkout source
@@ -29,8 +29,8 @@ jobs:
2929
password: ${{ secrets.GITHUB_TOKEN }}
3030
- name: Build and push to GitHub Container Registry
3131
run: |
32-
make build-latest config=public
33-
make push-latest config=public
32+
make build-nightly config=public
33+
make push-nightly config=public
3434
- name: Send alert on failure
3535
if: ${{ failure() }}
3636
uses: zulip/github-actions-zulip/send-message@e4c8f27c732ba9bd98ac6be0583096dea82feea5
@@ -43,8 +43,8 @@ jobs:
4343
topic: ${{ github.repository }} scheduled job failure
4444
content: ${{ github.server_url}}/${{ github.repository }}/actions/runs/${{ github.run_id }} failed.
4545

46-
rebuild-private-latest-image:
47-
name: Rebuild latest private image
46+
rebuild-private-nightly-image:
47+
name: Rebuild nightly private image
4848
runs-on: ubuntu-latest
4949
steps:
5050
- name: Checkout source
@@ -57,11 +57,11 @@ jobs:
5757
username: ${{ github.repository_owner }}
5858
password: ${{ secrets.GITHUB_TOKEN }}
5959
- name: Build
60-
run: make build-latest config=private
60+
run: make build-nightly config=private
6161
env:
6262
MATERIAL_INSIDERS_ACCESS: ${{ secrets.MATERIAL_INSIDERS_ACCESS }}
6363
- name: Push
64-
run: make push-latest config=private
64+
run: make push-nightly config=private
6565
- name: Send alert on failure
6666
if: ${{ failure() }}
6767
uses: zulip/github-actions-zulip/send-message@e4c8f27c732ba9bd98ac6be0583096dea82feea5
@@ -76,7 +76,7 @@ jobs:
7676

7777
prune-untagged-public-images:
7878
needs:
79-
- rebuild-public-latest-image
79+
- rebuild-public-nightly-image
8080

8181
name: Prune untagged public images
8282
runs-on: ubuntu-latest
@@ -103,7 +103,7 @@ jobs:
103103

104104
prune-untagged-private-images:
105105
needs:
106-
- rebuild-private-latest-image
106+
- rebuild-private-nightly-image
107107

108108
name: Prune untagged private images
109109
runs-on: ubuntu-latest

Makefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,22 +19,22 @@ all: pylint
1919
build:
2020
docker build --pull --build-arg PACKAGE="${PACKAGE}" --build-arg FROM_TAG="${version}" -t "${IMAGE}:${version}" .
2121

22-
build-latest:
23-
docker build --pull --build-arg PACKAGE="${PACKAGE}" --build-arg FROM_TAG="nightly" -t "${IMAGE}:latest" .
22+
build-nightly:
23+
docker build --pull --build-arg PACKAGE="${PACKAGE}" --build-arg FROM_TAG="nightly" -t "${IMAGE}:nightly" .
2424

2525
build-release:
2626
docker build --pull --build-arg PACKAGE="${PACKAGE}" --build-arg FROM_TAG="release" -t "${IMAGE}:release" .
2727

2828
push:
2929
docker push "${IMAGE}:${version}"
3030

31-
push-latest:
32-
docker push "${IMAGE}:latest"
31+
push-nightly:
32+
docker push "${IMAGE}:nightly"
3333

3434
push-release:
3535
docker push "${IMAGE}:release"
3636

37-
pylint: build-latest
38-
docker run --entrypoint pylint --rm "${IMAGE}:latest" /entrypoint.py
37+
pylint: build-nightly
38+
docker run --entrypoint pylint --rm "${IMAGE}:nightly" /entrypoint.py
3939

4040
.PHONY: build pylint

RELEASE_PROCESS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@ This document is aimed at members of the team who might be cutting a release of
66

77
There's no release process library-documentation-action. New images are created in response to new versions of ponyc being released. See the following GitHub workflows to see exactly what is created:
88

9-
- [Update latest images](https://github.com/ponylang/library-documentation-action-v2/blob/main/.github/workflows/update-latest-image.yml)
9+
- [Update nightly images](https://github.com/ponylang/library-documentation-action-v2/blob/main/.github/workflows/update-nightly-image.yml)
1010
- [Update release images](https://github.com/ponylang/library-documentation-action-v2/blob/main/.github/workflows/update-release-image.yml)

0 commit comments

Comments
 (0)