Skip to content
This repository was archived by the owner on Jun 30, 2026. It is now read-only.

Commit 2c9f1a5

Browse files
committed
Fix Dockerfile label placement and close connection on parse error
Move the OCI image source label from the build stage to the final stage — in a multi-stage build only the final stage's labels end up in the resulting image, so GHCR couldn't associate the package with the repo. Add _http.close() to on_parse_error for consistency with on_response_complete — after a parse error the connection is in an undefined state and should be torn down.
1 parent 8468572 commit 2c9f1a5

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
FROM ghcr.io/ponylang/shared-docker-ci-standard-builder-with-libressl-4.2.0:release AS build
2-
LABEL org.opencontainers.image.source="https://github.com/ponylang/zulip-action"
32

43
WORKDIR /src
54
COPY . .
65

76
RUN make build-action ssl=libressl static=true config=release
87

98
FROM alpine:3.21
9+
LABEL org.opencontainers.image.source="https://github.com/ponylang/zulip-action"
1010

1111
RUN apk add --no-cache ca-certificates
1212

zulip_action/zulip_client.pony

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ actor ZulipClient is courier.HTTPClientConnectionActor
121121
fun ref on_parse_error(err: courier.ParseError) =>
122122
_notified = true
123123
_notify.failure("HTTP parse error")
124+
_http.close()
124125

125126
fun ref on_closed() =>
126127
"""

0 commit comments

Comments
 (0)