Merge remote-tracking branch 'origin/main' into multi-processor

Author: rkistner

.changeset/fix-sync-streams-iif-arity.md

@@ -0,0 +1,5 @@
+---
+'@powersync/service-sync-rules': patch
+---
+
+Validate `iif()` calls with the same three-argument arity used by the sync stream evaluator.

packages/jpgwire/src/certs.ts

@@ -1,15 +1,16 @@
 import * as fs from 'fs/promises';
-import { resolve } from 'path';
+import * as path from 'path';
+import { fileURLToPath } from 'url';
 
 export const DEFAULT_CERTS = await loadDefaultCertificates();
 
 async function loadDefaultCertificates() {
-  const dir = new URL('../ca', import.meta.url).pathname;
+  const dir = path.join(path.dirname(fileURLToPath(import.meta.url)), '../ca');
   const files = await fs.readdir(dir);
   let sum = '';
   for (let file of files) {
     if (file.endsWith('.pem')) {
-      sum += (await fs.readFile(resolve(dir, file), 'utf-8')) + '\n';
+      sum += (await fs.readFile(path.resolve(dir, file), 'utf-8')) + '\n';
     }
   }
   return sum;

packages/sync-rules/src/sync_plan/expression.ts

@@ -143,7 +143,7 @@ export const supportedFunctions: Record<string, ArgumentCount> = {
   hex: 1,
   ifnull: { min: 2 },
   //if: { min: 2 },
-  iif: { min: 2 },
+  iif: 3,
   instr: 2,
   length: 1,
   // TODO: Establish defaults for case sensitivity, changing escape characters, ICU support.

packages/sync-rules/test/src/compiler/sqlite.test.ts

@@ -85,6 +85,22 @@ describe('sqlite conversion', () => {
         ]);
       });
 
+      test('iif requires exactly three args', () => {
+        expect(translate('iif(1, 2)')[1]).toStrictEqual([
+          {
+            message: 'Expected at least 3 arguments',
+            source: 'iif(1, 2)'
+          }
+        ]);
+
+        expect(translate('iif(1, 2, 3, 4)')[1]).toStrictEqual([
+          {
+            message: 'Expected at most 3 arguments',
+            source: 'iif(1, 2, 3, 4)'
+          }
+        ]);
+      });
+
       test.skip('must be even', () => {
         expect(translate("json_object('foo')")[1]).toStrictEqual([
           {