fix: resolve CI configuration and static analysis issues

Summary:
- Upgraded CI actions to v4.
- Added explicit sanitizer flags for linker to resolve ThreadSanitizer issues.
- Fixed potential null socket dereference in tests/cloudSQL_tests.cpp.

Author: poyrazK

.github/workflows/ci.yml

@@ -49,7 +49,6 @@ jobs:
         mkdir build
         cd build
         export CCACHE_DIR=~/.ccache
-        # Use matrix sanitizer. ThreadSanitizer requires specialized flags.
         if [ "${{ matrix.sanitizer }}" == "thread" ]; then
           SAN_FLAGS="-fsanitize=thread"
         else
@@ -60,6 +59,8 @@ jobs:
           -DCMAKE_CXX_COMPILER=${{ matrix.compiler }} \
           -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
           -DCMAKE_CXX_FLAGS="$SAN_FLAGS" \
+          -DCMAKE_EXE_LINKER_FLAGS="$SAN_FLAGS" \
+          -DCMAKE_SHARED_LINKER_FLAGS="$SAN_FLAGS" \
           -DBUILD_TESTS=ON \
           -DBUILD_COVERAGE=${{ matrix.sanitizer == 'address' && 'ON' || 'OFF' }}
 

tests/cloudSQL_tests.cpp

@@ -379,6 +379,9 @@ TEST(NetworkTest_Handshake) {
     std::this_thread::sleep_for(std::chrono::milliseconds(200));
 
     int sock = socket(AF_INET, SOCK_STREAM, 0);
+    if (sock < 0) {
+        throw std::runtime_error("Failed to create socket in NetworkTest_Handshake");
+    }
     struct sockaddr_in addr;
     addr.sin_family = AF_INET;
     addr.sin_port = htons(port);