Found during the #1546 multi-agent review.
tests/fixtures/adcp_schemas_pinned/ (PINNED_SHA 04f59d2d5, see _refresh.py) predates the 3.1.1 pin: 64 error codes vs the authoritative 92 at dist/schemas/3.1.1/enums/error-code.json@v3.1.1, and 4 shared codes carry different suggestion texts (REQUOTE_REQUIRED, CREDENTIAL_IN_ARGS, PACKAGE_NOT_FOUND, MEDIA_BUY_NOT_FOUND). The suggestion/recovery conformance oracles ground in this fixture, so their guarantee is only as fresh as its vintage. Advance PINNED_SHA to the v3.1.1 tag commit and regenerate, per the script's own documented procedure.- The suggestion conformance chain is constant↔fixture + wire-presence-only; no test asserts the EMITTED wire suggestion equals the pinned enum text, so a boundary that rebuilds the error and substitutes/drops the suggestion passes every current test. Add one wire test per pinned code asserting
wire_error_envelope["errors"][0]["suggestion"] equals the enumMetadata text loaded from the pinned enum (not from the production constant — that is a lockstep tautology).
AUTH_REQUIRED_SUGGESTION (src/core/exceptions.py:479) diverges from the pinned enum's suggestion for AUTH_REQUIRED with no deliberate-deviation comment and is excluded from the conformance list — align it or document the deviation inline.
Found during the #1546 multi-agent review.
tests/fixtures/adcp_schemas_pinned/(PINNED_SHA04f59d2d5, see_refresh.py) predates the 3.1.1 pin: 64 error codes vs the authoritative 92 atdist/schemas/3.1.1/enums/error-code.json@v3.1.1, and 4 shared codes carry different suggestion texts (REQUOTE_REQUIRED, CREDENTIAL_IN_ARGS, PACKAGE_NOT_FOUND, MEDIA_BUY_NOT_FOUND). The suggestion/recovery conformance oracles ground in this fixture, so their guarantee is only as fresh as its vintage. Advance PINNED_SHA to the v3.1.1 tag commit and regenerate, per the script's own documented procedure.wire_error_envelope["errors"][0]["suggestion"]equals the enumMetadata text loaded from the pinned enum (not from the production constant — that is a lockstep tautology).AUTH_REQUIRED_SUGGESTION(src/core/exceptions.py:479) diverges from the pinned enum's suggestion for AUTH_REQUIRED with no deliberate-deviation comment and is excluded from the conformance list — align it or document the deviation inline.