fix: fix incorrect coercion (#5491)

This is a pretty confusing behavior, but our choice of fields for
`add_condition` doesn't actually affect the final m2m filter being
generated, because it uses the linking table which isn't represented in
`query_ast`, so this change does not change the actual filter. It only
fixes a bug that occurs when we attempt to coerce the value being
filtered against the column it's meant to filter. When we filter against
an m2m table, for the coercion to work correctly we need to use
`parent_field.linking_fields()`.


[ORM-1124](https://linear.app/prisma-company/issue/ORM-1124/fix-conversion-failure-on-upsert-update-relationship)

Fixes prisma/prisma#27452

Author: jacek-prisma

query-compiler/query-compiler/src/translate/query/read.rs

@@ -234,8 +234,6 @@ fn build_read_related_records(
 
     if let Some(results) = rrq.parent_results {
         let parent_link_id = rrq.parent_field.linking_fields();
-        let child_link_id = rrq.parent_field.related_field().linking_fields();
-
         let selection = results
             .into_iter()
             .exactly_one()
@@ -244,7 +242,19 @@ fn build_read_related_records(
             .pop()
             .unwrap();
 
-        for (field, val) in child_link_id
+        // When we query for children by parent, we typically want to generate a query with filters
+        // for every field in `parent_field.related_field().linking_fields()`. It's not correct to
+        // do that for many-to-many relations though, because their `related_field` points at the
+        // primary identifier of the child model, which cannot be used as a filter for the parent
+        // identifiers. The actual field that must be used belongs to the linking table, and it
+        // corresponds to the primary identifier of the parent model.
+        let fields_to_filter_by = if rrq.parent_field.relation().is_many_to_many() {
+            parent_link_id
+        } else {
+            rrq.parent_field.related_field().linking_fields()
+        };
+
+        for (field, val) in fields_to_filter_by
             .assimilate(selection)
             .map_err(QueryGraphBuilderError::from)?
             .pairs

query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/mod.rs

@@ -30,6 +30,7 @@ mod prisma_22298;
 mod prisma_22971;
 mod prisma_24072;
 mod prisma_25290;
+mod prisma_27452;
 mod prisma_5952;
 mod prisma_6173;
 mod prisma_7010;

query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/prisma_27452.rs

@@ -0,0 +1,124 @@
+use query_engine_tests::*;
+
+#[test_suite(schema(schema), exclude(MongoDb, SqlServer))]
+mod prisma_27452 {
+    fn schema() -> String {
+        indoc! {
+            r#"
+            model User {
+              id    String  @id @default(cuid())
+
+              posts        Post[]
+              comments     Comment[]
+              commentLikes CommentLike[]
+            }
+
+            model Post {
+              id    String @id @default(cuid())
+
+              user         User          @relation(fields: [ownerId], references: [id], onDelete: Cascade)
+              ownerId      String
+              comments     Comment[]
+              commentLikes CommentLike[]
+
+              @@unique([id, ownerId])
+            }
+
+            model Comment {
+              id      String @id @default(cuid())
+
+              post         Post          @relation(fields: [postId], references: [id], onDelete: Cascade)
+              postId       String
+              user         User          @relation(fields: [ownerId], references: [id], onDelete: Cascade)
+              ownerId      String
+              commentLikes CommentLike[]
+            }
+
+            model CommentLike {
+              id Int @id @default(autoincrement())
+
+              user     User      @relation(fields: [ownerId], references: [id], onDelete: Cascade)
+              ownerId  String
+              post     Post      @relation(fields: [postId], references: [id], onDelete: Cascade)
+              postId   String
+              comments Comment[]
+
+              @@unique([postId, ownerId])
+            }
+            "#
+        }
+        .to_string()
+    }
+
+    #[connector_test]
+    async fn comment_like_upsert_with_nested_comments(runner: Runner) -> TestResult<()> {
+        let user_id = "1";
+        let post_id = "1";
+        let comment1_id = "1";
+        let comment2_id = "2";
+
+        runner
+            .query(&format!(
+                r#"
+                mutation {{
+                  createOneUser(data: {{
+                    id: "{user_id}"
+                    posts: {{
+                      createMany: {{
+                        data: [{{ id: "{post_id}" }}]
+                      }}
+                    }}
+                    comments: {{
+                      createMany: {{
+                        data: [
+                          {{ id: "{comment1_id}", postId: "{post_id}" }},
+                          {{ id: "{comment2_id}", postId: "{post_id}" }}
+                        ]
+                      }}
+                    }}
+                  }}) {{
+                    id
+                  }}
+                }}
+                "#,
+            ))
+            .await?;
+
+        let result = runner
+            .query(&format!(
+                r#"
+                mutation {{
+                  upsertOneCommentLike(
+                    where: {{
+                      postId_ownerId: {{ postId: "{post_id}", ownerId: "{user_id}" }}
+                    }}
+                    create: {{
+                      postId: "{post_id}"
+                      ownerId: "{user_id}"
+                      comments: {{
+                        connect: [{{ id: "{comment1_id}" }}]
+                      }}
+                    }}
+                    update: {{
+                      comments: {{
+                        set: [{{ id: "{comment2_id}" }}]
+                      }}
+                    }}
+                  ) {{
+                    comments {{
+                      id
+                    }}
+                  }}
+                }}
+                "#,
+            ))
+            .await?;
+
+        insta::assert_snapshot!(
+            result,
+            @r###"{"data":{"upsertOneCommentLike":{"comments":[{"id":"1"}]}}}"###
+        );
+
+        Ok(())
+    }
+}