fix: remove redundant if statement

Author: LucianBuzzo

query-engine/core/src/interactive_transactions/manager.rs

@@ -116,12 +116,8 @@ impl ItxManager {
         if self.transactions.read().await.contains_key(&tx_id) {
             let transaction_entry = self.get_transaction(&tx_id, "begin").await?;
             let mut tx = transaction_entry.lock().await;
-            // If the transaction is already open, we need to create a savepoint.
-            if tx.depth() > 0 {
-                tx.create_savepoint().await?;
-            } else {
-                tx.begin().await?;
-            }
+            // The transaction is already open, so we need to create a savepoint.
+            tx.create_savepoint().await?;
         } else {
             // This task notifies the task spawned in `new()` method that the timeout for this
             // transaction has expired.

query-engine/core/src/interactive_transactions/transaction.rs

@@ -204,23 +204,6 @@ impl InteractiveTransaction {
         }
     }
 
-    pub async fn begin(&mut self) -> crate::Result<()> {
-        tx_timeout!(self, "begin", async {
-            let name = self.name();
-            let conn = self.state.as_open("begin")?;
-            let span = info_span!("prisma:engine:itx_begin", user_facing = true);
-
-            if let Err(err) = conn.begin().instrument(span).await {
-                error!(?err, ?name, "transaction failed to begin");
-                let _ = self.rollback(false).await;
-                Err(err.into())
-            } else {
-                debug!(?name, "transaction started");
-                Ok(())
-            }
-        })
-    }
-
     pub async fn commit(&mut self) -> crate::Result<()> {
         tx_timeout!(self, "commit", async {
             let name = self.name();