chore: update tests for value out of range errors

aqrln · aqrln · commit 7ab8920f83ed · 2025-06-27T16:54:01.000+02:00
diff --git a/.github/workflows/test-query-engine.yml b/.github/workflows/test-query-engine.yml
@@ -228,7 +228,7 @@ jobs:
           - name: 'd1 (wasm)'
             setup_task: 'dev-d1'
           - name: 'better-sqlite3 (wasm)'
-            setup_task: 'dev-better-sqlite3'
+            setup_task: 'dev-better-sqlite3-wasm'
           - name: 'mssql (wasm)'
             setup_task: 'dev-mssql-wasm'
           - name: 'mariadb (wasm)'
diff --git a/Makefile b/Makefile
@@ -194,17 +194,11 @@ dev-d1: build-qe-wasm build-se-wasm build-driver-adapters-kit-qe
 test-d1: dev-d1 test-qe-st
 test-driver-adapter-d1: test-d1
 
-dev-better-sqlite3: build-qe-wasm build-se-wasm build-driver-adapters-kit-qe
-	cp $(CONFIG_PATH)/better-sqlite3 $(CONFIG_FILE)
+dev-better-sqlite3-wasm: build-qe-wasm build-se-wasm build-driver-adapters-kit-qe
+	cp $(CONFIG_PATH)/better-sqlite3-wasm $(CONFIG_FILE)
 
-test-better-sqlite3: dev-better-sqlite3 test-qe-st
-test-driver-adapter-better-sqlite3: test-better-sqlite3
-
-dev-sqlite3: build-qe-wasm build-se-wasm build-driver-adapters-kit-qe
-	cp $(CONFIG_PATH)/sqlite3 $(CONFIG_FILE)
-
-test-sqlite3: dev-sqlite3 test-qe-st
-test-driver-adapter-sqlite3: test-sqlite3
+test-better-sqlite3-wasm: dev-better-sqlite3-wasm test-qe-st
+test-driver-adapter-better-sqlite3-wasm: test-better-sqlite3-wasm
 
 start-postgres9:
 	docker compose -f docker-compose.yml up --wait -d --remove-orphans postgres9
diff --git a/libs/user-facing-errors/src/query_engine/mod.rs b/libs/user-facing-errors/src/query_engine/mod.rs
@@ -200,7 +200,7 @@ pub struct InputError {
 }
 
 #[derive(Debug, UserFacingError, Serialize)]
-#[user_facing(code = "P2020", message = "Value out of range for the type. {details}")]
+#[user_facing(code = "P2020", message = "Value out of range for the type: {details}")]
 pub struct ValueOutOfRange {
     pub details: String,
 }
diff --git a/query-compiler/query-engine-tests-todo/better-sqlite3/fail/query b/query-compiler/query-engine-tests-todo/better-sqlite3/fail/query
@@ -1,5 +1,4 @@
 new::interactive_tx::interactive_tx::batch_queries_failure
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
 new::regressions::prisma_7434::not_in_chunking::not_in_batch_filter
 queries::aggregation::group_by::aggregation_group_by::group_by_ordering_sum_aggregation
 queries::chunking::chunking::order_by_aggregation_should_fail
diff --git a/query-compiler/query-engine-tests-todo/libsql/fail/query b/query-compiler/query-engine-tests-todo/libsql/fail/query
@@ -1,5 +1,4 @@
 new::interactive_tx::interactive_tx::batch_queries_failure
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
 new::regressions::prisma_15204::conversion_error::convert_to_bigint_sqlite_js
 new::regressions::prisma_15204::conversion_error::convert_to_int_sqlite_js
 new::regressions::prisma_7434::not_in_chunking::not_in_batch_filter
diff --git a/query-compiler/query-engine-tests-todo/pg-cockroachdb/fail/join b/query-compiler/query-engine-tests-todo/pg-cockroachdb/fail/join
@@ -1,5 +1,3 @@
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
-new::regressions::max_integer::max_integer::unfitted_int_should_fail_pg_js
 new::regressions::prisma_13097::prisma_13097::group_by_boolean_array
 new::regressions::prisma_13097::prisma_13097::group_by_enum_array
 new::regressions::prisma_7434::not_in_chunking_cockroachdb::not_in_batch_filter
diff --git a/query-compiler/query-engine-tests-todo/pg-cockroachdb/fail/query b/query-compiler/query-engine-tests-todo/pg-cockroachdb/fail/query
@@ -1,5 +1,3 @@
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
-new::regressions::max_integer::max_integer::unfitted_int_should_fail_pg_js
 new::regressions::prisma_13097::prisma_13097::group_by_boolean_array
 new::regressions::prisma_13097::prisma_13097::group_by_enum_array
 new::regressions::prisma_7434::not_in_chunking_cockroachdb::not_in_batch_filter
diff --git a/query-compiler/query-engine-tests-todo/pg/fail/join b/query-compiler/query-engine-tests-todo/pg/fail/join
@@ -1,5 +1,3 @@
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
-new::regressions::max_integer::max_integer::unfitted_int_should_fail_pg_js
 new::regressions::prisma_13097::prisma_13097::group_by_boolean_array
 new::regressions::prisma_13097::prisma_13097::group_by_enum_array
 new::regressions::prisma_7434::not_in_chunking::not_in_batch_filter
diff --git a/query-compiler/query-engine-tests-todo/pg/fail/query b/query-compiler/query-engine-tests-todo/pg/fail/query
@@ -1,5 +1,3 @@
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
-new::regressions::max_integer::max_integer::unfitted_int_should_fail_pg_js
 new::regressions::prisma_13097::prisma_13097::group_by_boolean_array
 new::regressions::prisma_13097::prisma_13097::group_by_enum_array
 new::regressions::prisma_7434::not_in_chunking::not_in_batch_filter
diff --git a/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/logs.rs b/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/logs.rs
@@ -6,7 +6,7 @@ use query_engine_tests::*;
         MongoDb,
         Vitess("planetscale.js.wasm"),
         Postgres("neon.js.wasm", "pg.js.wasm"),
-        Sqlite("libsql.js.wasm", "cfd1", "react-native", "better-sqlite3"),
+        Sqlite("libsql.js.wasm", "cfd1", "react-native", "better-sqlite3.js.wasm"),
         Sqlserver("mssql.js.wasm"),
         Mysql("mariadb.js.wasm"),
         CockroachDb("pg.js.wasm")
diff --git a/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/metrics.rs b/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/metrics.rs
@@ -5,7 +5,7 @@ use query_engine_tests::test_suite;
     exclude(
         Vitess("planetscale.js.wasm"),
         Postgres("neon.js.wasm", "pg.js.wasm"),
-        Sqlite("libsql.js.wasm", "cfd1", "react-native", "better-sqlite3"),
+        Sqlite("libsql.js.wasm", "cfd1", "react-native", "better-sqlite3.js.wasm"),
         Sqlserver("mssql.js.wasm"),
         Mysql("mariadb.js.wasm"),
         CockroachDb("pg.js.wasm"),
diff --git a/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/max_integer.rs b/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/max_integer.rs
@@ -163,7 +163,12 @@ mod max_integer {
     // ```
     // Expected result to return an error, but found success: {"data":{"createOneTest":{"id":1,"int":2147483648}}}
     // ```
-    #[connector_test(exclude(MongoDb, MySql(5.6), Sqlite("cfd1")))]
+    //
+    // Likewise, these writes succeed with better-sqlite3 and libSQL driver adapters. When using the query compiler,
+    // the queries are executed successfully and the test fails because it expects an error. When using the query
+    // engine, the test only passes by accident: the queries succeed on the database level, but conversion of JS values
+    // to quaint values fails after reading the inserted values back from the database.
+    #[connector_test(exclude(MongoDb, MySql(5.6), Sqlite("cfd1", "better-sqlite3.js.wasm", "libsql.js.wasm")))]
     async fn unfitted_int_should_fail(runner: Runner) -> TestResult<()> {
         assert_error!(
             runner,
@@ -254,36 +259,36 @@ mod max_integer {
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ int: {I32_OVERFLOW_MAX} }}) {{ id }} }}"),
-            None,
-            "value \\\"2147483648\\\" is out of range for type integer"
+            2020,
+            r#"Value out of range for the type: value "2147483648" is out of range for type integer"#
         );
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ int: {I32_OVERFLOW_MIN} }}) {{ id }} }}"),
-            None,
-            "value \\\"-2147483649\\\" is out of range for type integer"
+            2020,
+            r#"Value out of range for the type: value "-2147483649" is out of range for type integer"#
         );
 
         // smallint
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ smallint: {I16_OVERFLOW_MAX} }}) {{ id }} }}"),
-            None,
-            "value \\\"32768\\\" is out of range for type smallint"
+            2020,
+            r#"Value out of range for the type: value "32768" is out of range for type smallint"#
         );
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ smallint: {I16_OVERFLOW_MIN} }}) {{ id }} }}"),
-            None,
-            "value \\\"-32769\\\" is out of range for type smallint"
+            2020,
+            r#"Value out of range for the type: value "-32769" is out of range for type smallint"#
         );
 
         //oid
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ oid: {U32_OVERFLOW_MAX} }}) {{ id }} }}"),
-            None,
-            "value \\\"4294967296\\\" is out of range for type oid"
+            2020,
+            r#"Value out of range for the type: value "4294967296" is out of range for type oid"#
         );
 
         // The underlying driver swallows a negative id by interpreting it as unsigned.
@@ -358,55 +363,55 @@ mod max_integer {
             runner,
             format!("mutation {{ createOneTest(data: {{ tinyint: {I8_OVERFLOW_MAX} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'tinyint'"
+            "Value out of range for the type: Out of range value for column 'tinyint'"
         );
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ tinyint: {I8_OVERFLOW_MIN} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'tinyint'"
+            "Value out of range for the type: Out of range value for column 'tinyint'"
         );
 
         // smallint
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ smallint: {I16_OVERFLOW_MAX} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'smallint'"
+            "Value out of range for the type: Out of range value for column 'smallint'"
         );
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ smallint: {I16_OVERFLOW_MIN} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'smallint'"
+            "Value out of range for the type: Out of range value for column 'smallint'"
         );
 
         // mediumint
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ mediumint: {I24_OVERFLOW_MAX} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'mediumint'"
+            "Value out of range for the type: Out of range value for column 'mediumint'"
         );
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ mediumint: {I24_OVERFLOW_MIN} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'mediumint'"
+            "Value out of range for the type: Out of range value for column 'mediumint'"
         );
 
         // int
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ int: {I32_OVERFLOW_MAX} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'int'"
+            "Value out of range for the type: Out of range value for column 'int'"
         );
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ int: {I32_OVERFLOW_MIN} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'int'"
+            "Value out of range for the type: Out of range value for column 'int'"
         );
 
         // year
@@ -415,69 +420,69 @@ mod max_integer {
             runner,
             format!("mutation {{ createOneTest(data: {{ year: {} }}) {{ id }} }}", 2156),
             2020,
-            "Value out of range for the type. Out of range value for column 'year'"
+            "Value out of range for the type: Out of range value for column 'year'"
         );
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ year: {} }}) {{ id }} }}", 1900),
             2020,
-            "Value out of range for the type. Out of range value for column 'year'"
+            "Value out of range for the type: Out of range value for column 'year'"
         );
 
         // unsigned tinyint
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ unsigned_tinyint: {U8_OVERFLOW_MAX} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'unsigned_tinyint'"
+            "Value out of range for the type: Out of range value for column 'unsigned_tinyint'"
         );
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ unsigned_tinyint: {OVERFLOW_MIN} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'unsigned_tinyint'"
+            "Value out of range for the type: Out of range value for column 'unsigned_tinyint'"
         );
 
         // unsigned smallint
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ unsigned_smallint: {U16_OVERFLOW_MAX} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'unsigned_smallint'"
+            "Value out of range for the type: Out of range value for column 'unsigned_smallint'"
         );
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ unsigned_smallint: {OVERFLOW_MIN} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'unsigned_smallint'"
+            "Value out of range for the type: Out of range value for column 'unsigned_smallint'"
         );
 
         // unsigned mediumint
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ unsigned_mediumint: {U24_OVERFLOW_MAX} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'unsigned_mediumint'"
+            "Value out of range for the type: Out of range value for column 'unsigned_mediumint'"
         );
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ unsigned_mediumint: {OVERFLOW_MIN} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'unsigned_mediumint'"
+            "Value out of range for the type: Out of range value for column 'unsigned_mediumint'"
         );
 
         // unsigned int
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ unsigned_int: {U32_OVERFLOW_MAX} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'unsigned_int'"
+            "Value out of range for the type: Out of range value for column 'unsigned_int'"
         );
         assert_error!(
             runner,
             format!("mutation {{ createOneTest(data: {{ unsigned_int: {OVERFLOW_MIN} }}) {{ id }} }}"),
             2020,
-            "Value out of range for the type. Out of range value for column 'unsigned_int'"
+            "Value out of range for the type: Out of range value for column 'unsigned_int'"
         );
 
         Ok(())
diff --git a/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/prisma_15204.rs b/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/prisma_15204.rs
@@ -27,7 +27,7 @@ mod conversion_error {
     #[connector_test(
         schema(schema_int),
         only(Sqlite),
-        exclude(Sqlite("libsql.js.wasm", "better-sqlite3"))
+        exclude(Sqlite("libsql.js.wasm", "better-sqlite3.js.wasm"))
     )]
     async fn convert_to_int_sqlite_quaint(runner: Runner) -> TestResult<()> {
         create_test_data(&runner).await?;
@@ -59,7 +59,7 @@ mod conversion_error {
     #[connector_test(
         schema(schema_bigint),
         only(Sqlite),
-        exclude(Sqlite("libsql.js.wasm", "better-sqlite3"))
+        exclude(Sqlite("libsql.js.wasm", "better-sqlite3.js.wasm"))
     )]
     async fn convert_to_bigint_sqlite_quaint(runner: Runner) -> TestResult<()> {
         create_test_data(&runner).await?;
diff --git a/query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/json.rs b/query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/json.rs
@@ -214,7 +214,7 @@ mod json {
         exclude(
             Vitess("planetscale.js.wasm"),
             Postgres("neon.js.wasm", "pg.js.wasm"),
-            Sqlite("libsql.js.wasm", "cfd1", "better-sqlite3"),
+            Sqlite("libsql.js.wasm", "cfd1", "better-sqlite3.js.wasm"),
             MySQL(5.6, "mariadb.js.wasm"),
             CockroachDb("pg.js.wasm"),
         )
diff --git a/query-engine/connector-test-kit-rs/query-engine-tests/tests/raw/sql/errors.rs b/query-engine/connector-test-kit-rs/query-engine-tests/tests/raw/sql/errors.rs
@@ -38,7 +38,7 @@ mod raw_errors {
         only(Postgres, Sqlite),
         exclude(
             Postgres("neon.js.wasm", "pg.js.wasm"),
-            Sqlite("libsql.js.wasm", "cfd1", "better-sqlite3")
+            Sqlite("libsql.js.wasm", "cfd1", "better-sqlite3.js.wasm")
         )
     )]
     async fn invalid_parameter_count(runner: Runner) -> TestResult<()> {
diff --git a/query-engine/connector-test-kit-rs/query-tests-setup/src/connector_tag/sqlite.rs b/query-engine/connector-test-kit-rs/query-tests-setup/src/connector_tag/sqlite.rs
@@ -44,7 +44,7 @@ impl Display for SqliteVersion {
             SqliteVersion::V3 => f.write_str("3"),
             SqliteVersion::LibsqlJsWasm => f.write_str("libsql.js.wasm"),
             SqliteVersion::CloudflareD1 => f.write_str("cfd1"),
-            SqliteVersion::BetterSQLite3 => f.write_str("better-sqlite3"),
+            SqliteVersion::BetterSQLite3 => f.write_str("better-sqlite3.js.wasm"),
         }
     }
 }
@@ -58,7 +58,7 @@ impl TryFrom<&str> for SqliteVersion {
             "libsql.js.wasm" => Self::LibsqlJsWasm,
             "react-native" => Self::ReactNative,
             "cfd1" => Self::CloudflareD1,
-            "better-sqlite3" => Self::BetterSQLite3,
+            "better-sqlite3.js.wasm" => Self::BetterSQLite3,
             _ => return Err(TestError::parse_error(format!("Unknown SQLite version `{s}`"))),
         };
         Ok(version)
diff --git a/query-engine/connector-test-kit-rs/test-configs/better-sqlite3-qc b/query-engine/connector-test-kit-rs/test-configs/better-sqlite3-qc
@@ -1,6 +1,6 @@
 {
     "connector": "sqlite",
-    "version": "better-sqlite3",
+    "version": "better-sqlite3.js.wasm.qc",
     "driver_adapter": "better-sqlite3",
     "external_test_executor": "QueryCompiler"
-}
+}
diff --git a/query-engine/connector-test-kit-rs/test-configs/better-sqlite3-wasm b/query-engine/connector-test-kit-rs/test-configs/better-sqlite3-wasm
@@ -1,6 +1,6 @@
 {
     "connector": "sqlite",
-    "version": "better-sqlite3",
+    "version": "better-sqlite3.js.wasm",
     "driver_adapter": "better-sqlite3",
     "external_test_executor": "Wasm"
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ pub struct InputError {`
`200`	`200`	`}`
`201`	`201`
`202`	`202`	`#[derive(Debug, UserFacingError, Serialize)]`
`203`		`-#[user_facing(code = "P2020", message = "Value out of range for the type. {details}")]`
	`203`	`+#[user_facing(code = "P2020", message = "Value out of range for the type: {details}")]`
`204`	`204`	`pub struct ValueOutOfRange {`
`205`	`205`	`pub details: String,`
`206`	`206`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`new::interactive_tx::interactive_tx::batch_queries_failure`
`2`		`-new::regressions::max_integer::max_integer::unfitted_int_should_fail`
`3`	`2`	`new::regressions::prisma_7434::not_in_chunking::not_in_batch_filter`
`4`	`3`	`queries::aggregation::group_by::aggregation_group_by::group_by_ordering_sum_aggregation`
`5`	`4`	`queries::chunking::chunking::order_by_aggregation_should_fail`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-new::regressions::max_integer::max_integer::unfitted_int_should_fail`
`2`		`-new::regressions::max_integer::max_integer::unfitted_int_should_fail_pg_js`
`3`	`1`	`new::regressions::prisma_13097::prisma_13097::group_by_boolean_array`
`4`	`2`	`new::regressions::prisma_13097::prisma_13097::group_by_enum_array`
`5`	`3`	`new::regressions::prisma_7434::not_in_chunking_cockroachdb::not_in_batch_filter`