chore: update tests for value out of range errors (#5506)

aqrln · web-flow · commit 9c30299f5a0e · 2025-06-27T22:06:21.000+02:00
Ref: https://linear.app/prisma-company/issue/ORM-963/validation-error-for-out-of-range-integer Ref: prisma/prisma#27542
diff --git a/.github/workflows/test-query-engine.yml b/.github/workflows/test-query-engine.yml
@@ -228,7 +228,7 @@ jobs:
           - name: 'd1 (wasm)'
             setup_task: 'dev-d1'
           - name: 'better-sqlite3 (wasm)'
-            setup_task: 'dev-better-sqlite3'
+            setup_task: 'dev-better-sqlite3-wasm'
           - name: 'mssql (wasm)'
             setup_task: 'dev-mssql-wasm'
           - name: 'mariadb (wasm)'
diff --git a/Makefile b/Makefile
@@ -194,17 +194,11 @@ dev-d1: build-qe-wasm build-se-wasm build-driver-adapters-kit-qe
 test-d1: dev-d1 test-qe-st
 test-driver-adapter-d1: test-d1
 
-dev-better-sqlite3: build-qe-wasm build-se-wasm build-driver-adapters-kit-qe
-	cp $(CONFIG_PATH)/better-sqlite3 $(CONFIG_FILE)
+dev-better-sqlite3-wasm: build-qe-wasm build-se-wasm build-driver-adapters-kit-qe
+	cp $(CONFIG_PATH)/better-sqlite3-wasm $(CONFIG_FILE)
 
-test-better-sqlite3: dev-better-sqlite3 test-qe-st
-test-driver-adapter-better-sqlite3: test-better-sqlite3
-
-dev-sqlite3: build-qe-wasm build-se-wasm build-driver-adapters-kit-qe
-	cp $(CONFIG_PATH)/sqlite3 $(CONFIG_FILE)
-
-test-sqlite3: dev-sqlite3 test-qe-st
-test-driver-adapter-sqlite3: test-sqlite3
+test-better-sqlite3-wasm: dev-better-sqlite3-wasm test-qe-st
+test-driver-adapter-better-sqlite3-wasm: test-better-sqlite3-wasm
 
 start-postgres9:
 	docker compose -f docker-compose.yml up --wait -d --remove-orphans postgres9
diff --git a/libs/user-facing-errors/src/query_engine/mod.rs b/libs/user-facing-errors/src/query_engine/mod.rs
@@ -200,7 +200,7 @@ pub struct InputError {
 }
 
 #[derive(Debug, UserFacingError, Serialize)]
-#[user_facing(code = "P2020", message = "Value out of range for the type. {details}")]
+#[user_facing(code = "P2020", message = "Value out of range for the type: {details}")]
 pub struct ValueOutOfRange {
     pub details: String,
 }
diff --git a/quaint/src/connector/mssql/error.rs b/quaint/src/connector/mssql/error.rs
@@ -212,6 +212,17 @@ impl From<MssqlError> for Error {
 
                 builder.build()
             }
+            108 | 168 | 183 | 187 | 220 | 232 | 236 | 242 | 244 | 248 | 294 | 296 | 298 | 304 | 517 | 535 | 1007
+            | 1080 | 2386 | 2568 | 2570 | 2579 | 2742 | 2950 | 3194 | 3250 | 3606 | 3995 | 4079 | 4867 | 6244
+            | 6398 | 6937 | 6938 | 6960 | 7116 | 7135 | 7722 | 7810 | 7981 | 8115 | 8165 | 8351 | 8411 | 8727
+            | 8729 | 8968 | 8991 | 9109 | 9204 | 9526 | 9527 | 9746 | 9813 | 9835 | 9838 | 9839 => {
+                let mut builder = Error::builder(ErrorKind::value_out_of_range(error.message.clone()));
+
+                builder.set_original_code(error.code.to_string());
+                builder.set_original_message(error.message);
+
+                builder.build()
+            }
             _ => {
                 let kind = ErrorKind::QueryError(error.clone().into());
 
diff --git a/quaint/src/error/mod.rs b/quaint/src/error/mod.rs
@@ -259,7 +259,6 @@ impl From<std::io::Error> for Error {
 }
 
 impl ErrorKind {
-    #[cfg(feature = "mysql-native")]
     pub(crate) fn value_out_of_range(msg: impl Into<String>) -> Self {
         Self::ValueOutOfRange { message: msg.into() }
     }
diff --git a/query-compiler/query-engine-tests-todo/better-sqlite3/fail/query b/query-compiler/query-engine-tests-todo/better-sqlite3/fail/query
@@ -1,5 +1,4 @@
 new::interactive_tx::interactive_tx::batch_queries_failure
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
 new::regressions::prisma_7434::not_in_chunking::not_in_batch_filter
 queries::aggregation::group_by::aggregation_group_by::group_by_ordering_sum_aggregation
 queries::chunking::chunking::order_by_aggregation_should_fail
diff --git a/query-compiler/query-engine-tests-todo/libsql/fail/query b/query-compiler/query-engine-tests-todo/libsql/fail/query
@@ -1,5 +1,4 @@
 new::interactive_tx::interactive_tx::batch_queries_failure
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
 new::regressions::prisma_15204::conversion_error::convert_to_bigint_sqlite_js
 new::regressions::prisma_15204::conversion_error::convert_to_int_sqlite_js
 new::regressions::prisma_7434::not_in_chunking::not_in_batch_filter
diff --git a/query-compiler/query-engine-tests-todo/mssql/fail/query b/query-compiler/query-engine-tests-todo/mssql/fail/query
@@ -1,5 +1,3 @@
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
-new::regressions::max_integer::max_integer::unfitted_int_should_fail_mssql
 new::regressions::prisma_7434::not_in_chunking::not_in_batch_filter
 queries::aggregation::group_by::aggregation_group_by::group_by_ordering_sum_aggregation
 queries::chunking::chunking::order_by_aggregation_should_fail
diff --git a/query-compiler/query-engine-tests-todo/neon/fail/join b/query-compiler/query-engine-tests-todo/neon/fail/join
@@ -1,5 +1,3 @@
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
-new::regressions::max_integer::max_integer::unfitted_int_should_fail_pg_js
 new::regressions::prisma_13097::prisma_13097::group_by_boolean_array
 new::regressions::prisma_13097::prisma_13097::group_by_enum_array
 new::regressions::prisma_7434::not_in_chunking::not_in_batch_filter
diff --git a/query-compiler/query-engine-tests-todo/neon/fail/query b/query-compiler/query-engine-tests-todo/neon/fail/query
@@ -1,5 +1,3 @@
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
-new::regressions::max_integer::max_integer::unfitted_int_should_fail_pg_js
 new::regressions::prisma_13097::prisma_13097::group_by_boolean_array
 new::regressions::prisma_13097::prisma_13097::group_by_enum_array
 new::regressions::prisma_7434::not_in_chunking::not_in_batch_filter
diff --git a/query-compiler/query-engine-tests-todo/pg-cockroachdb/fail/join b/query-compiler/query-engine-tests-todo/pg-cockroachdb/fail/join
@@ -1,5 +1,3 @@
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
-new::regressions::max_integer::max_integer::unfitted_int_should_fail_pg_js
 new::regressions::prisma_13097::prisma_13097::group_by_boolean_array
 new::regressions::prisma_13097::prisma_13097::group_by_enum_array
 new::regressions::prisma_7434::not_in_chunking_cockroachdb::not_in_batch_filter
diff --git a/query-compiler/query-engine-tests-todo/pg-cockroachdb/fail/query b/query-compiler/query-engine-tests-todo/pg-cockroachdb/fail/query
@@ -1,5 +1,3 @@
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
-new::regressions::max_integer::max_integer::unfitted_int_should_fail_pg_js
 new::regressions::prisma_13097::prisma_13097::group_by_boolean_array
 new::regressions::prisma_13097::prisma_13097::group_by_enum_array
 new::regressions::prisma_7434::not_in_chunking_cockroachdb::not_in_batch_filter
diff --git a/query-compiler/query-engine-tests-todo/pg/fail/join b/query-compiler/query-engine-tests-todo/pg/fail/join
@@ -1,5 +1,3 @@
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
-new::regressions::max_integer::max_integer::unfitted_int_should_fail_pg_js
 new::regressions::prisma_13097::prisma_13097::group_by_boolean_array
 new::regressions::prisma_13097::prisma_13097::group_by_enum_array
 new::regressions::prisma_7434::not_in_chunking::not_in_batch_filter
diff --git a/query-compiler/query-engine-tests-todo/pg/fail/query b/query-compiler/query-engine-tests-todo/pg/fail/query
@@ -1,5 +1,3 @@
-new::regressions::max_integer::max_integer::unfitted_int_should_fail
-new::regressions::max_integer::max_integer::unfitted_int_should_fail_pg_js
 new::regressions::prisma_13097::prisma_13097::group_by_boolean_array
 new::regressions::prisma_13097::prisma_13097::group_by_enum_array
 new::regressions::prisma_7434::not_in_chunking::not_in_batch_filter
diff --git a/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/logs.rs b/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/logs.rs
@@ -6,7 +6,7 @@ use query_engine_tests::*;
         MongoDb,
         Vitess("planetscale.js.wasm"),
         Postgres("neon.js.wasm", "pg.js.wasm"),
-        Sqlite("libsql.js.wasm", "cfd1", "react-native", "better-sqlite3"),
+        Sqlite("libsql.js.wasm", "cfd1", "react-native", "better-sqlite3.js.wasm"),
         Sqlserver("mssql.js.wasm"),
         Mysql("mariadb.js.wasm"),
         CockroachDb("pg.js.wasm")
diff --git a/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/metrics.rs b/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/metrics.rs
@@ -5,7 +5,7 @@ use query_engine_tests::test_suite;
     exclude(
         Vitess("planetscale.js.wasm"),
         Postgres("neon.js.wasm", "pg.js.wasm"),
-        Sqlite("libsql.js.wasm", "cfd1", "react-native", "better-sqlite3"),
+        Sqlite("libsql.js.wasm", "cfd1", "react-native", "better-sqlite3.js.wasm"),
         Sqlserver("mssql.js.wasm"),
         Mysql("mariadb.js.wasm"),
         CockroachDb("pg.js.wasm"),
diff --git a/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/max_integer.rs b/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/max_integer.rs
diff --git a/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/prisma_15204.rs b/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/prisma_15204.rs
diff --git a/query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/json.rs b/query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/json.rs
diff --git a/query-engine/connector-test-kit-rs/query-engine-tests/tests/raw/sql/errors.rs b/query-engine/connector-test-kit-rs/query-engine-tests/tests/raw/sql/errors.rs
diff --git a/query-engine/connector-test-kit-rs/query-tests-setup/src/connector_tag/sqlite.rs b/query-engine/connector-test-kit-rs/query-tests-setup/src/connector_tag/sqlite.rs
diff --git a/query-engine/connector-test-kit-rs/test-configs/better-sqlite3-qc b/query-engine/connector-test-kit-rs/test-configs/better-sqlite3-qc
diff --git a/query-engine/connector-test-kit-rs/test-configs/better-sqlite3-wasm b/query-engine/connector-test-kit-rs/test-configs/better-sqlite3-wasm

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ pub struct InputError {`
`200`	`200`	`}`
`201`	`201`
`202`	`202`	`#[derive(Debug, UserFacingError, Serialize)]`
`203`		`-#[user_facing(code = "P2020", message = "Value out of range for the type. {details}")]`
	`203`	`+#[user_facing(code = "P2020", message = "Value out of range for the type: {details}")]`
`204`	`204`	`pub struct ValueOutOfRange {`
`205`	`205`	`pub details: String,`
`206`	`206`	`}`
Original file line number	Diff line number	Diff line change
`@@ -259,7 +259,6 @@ impl From<std::io::Error> for Error {`
`259`	`259`	`}`
`260`	`260`
`261`	`261`	`impl ErrorKind {`
`262`		`- #[cfg(feature = "mysql-native")]`
`263`	`262`	`pub(crate) fn value_out_of_range(msg: impl Into<String>) -> Self {`
`264`	`263`	`Self::ValueOutOfRange { message: msg.into() }`
`265`	`264`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`new::interactive_tx::interactive_tx::batch_queries_failure`
`2`		`-new::regressions::max_integer::max_integer::unfitted_int_should_fail`
`3`	`2`	`new::regressions::prisma_7434::not_in_chunking::not_in_batch_filter`
`4`	`3`	`queries::aggregation::group_by::aggregation_group_by::group_by_ordering_sum_aggregation`
`5`	`4`	`queries::chunking::chunking::order_by_aggregation_should_fail`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-new::regressions::max_integer::max_integer::unfitted_int_should_fail`
`2`		`-new::regressions::max_integer::max_integer::unfitted_int_should_fail_mssql`
`3`	`1`	`new::regressions::prisma_7434::not_in_chunking::not_in_batch_filter`
`4`	`2`	`queries::aggregation::group_by::aggregation_group_by::group_by_ordering_sum_aggregation`
`5`	`3`	`queries::chunking::chunking::order_by_aggregation_should_fail`