refactor: remove inject_result_into_args (#5489)

[ORM-951](https://linear.app/prisma-company/issue/ORM-951/get-rid-of-data-dependency-functions-that-use-writequeryinject-result)

Author: jacek-prisma

query-engine/core/src/query_ast/write.rs

@@ -46,27 +46,6 @@ impl WriteQuery {
         }
     }
 
-    /// Takes a SelectionResult and writes its contents into the write arguments of the underlying query.
-    pub fn inject_result_into_args(&mut self, result: SelectionResult) {
-        let model = self.model();
-
-        let inject = |args: &mut WriteArgs| {
-            args.inject(result.clone());
-            args.update_datetimes(&model);
-        };
-
-        match self {
-            Self::CreateRecord(ref mut x) => inject(&mut x.args),
-            Self::CreateManyRecords(ref mut x) => x.args.iter_mut().map(inject).collect(),
-            Self::UpdateRecord(ref mut x) => match x {
-                UpdateRecord::WithSelection(u) => inject(&mut u.args),
-                UpdateRecord::WithoutSelection(u) => inject(&mut u.args),
-            },
-            Self::UpdateManyRecords(x) => inject(&mut x.args),
-            _ => (),
-        };
-    }
-
     pub fn set_selectors(&mut self, selectors: Vec<SelectionResult>) {
         match self {
             Self::UpdateManyRecords(x) => x.set_selectors(selectors),

query-engine/core/src/query_graph_builder/write/nested/disconnect_nested.rs

@@ -1,10 +1,11 @@
 use super::*;
 use crate::{
-    query_graph::{Node, NodeRef, QueryGraph, QueryGraphDependency},
-    ParsedInputMap, ParsedInputValue, Query, WriteQuery,
+    inputs::UpdateManyRecordsSelectorsInput,
+    query_graph::{NodeRef, QueryGraph, QueryGraphDependency},
+    ParsedInputMap, ParsedInputValue, RowSink,
 };
 use itertools::Itertools;
-use query_structure::{Filter, Model, PrismaValue, RelationCompare, RelationFieldRef, SelectionResult};
+use query_structure::{Filter, Model, PrismaValue, RelationCompare, RelationFieldRef, SelectionResult, WriteArgs};
 use std::convert::TryInto;
 
 /// Handles nested disconnect cases.
@@ -194,27 +195,16 @@ fn handle_one_to_x(
             )
         };
 
-    let update_node = utils::update_records_node_placeholder(graph, filter, model_to_update);
+    let write_args = WriteArgs::from_result(null_record_id, crate::executor::get_request_now());
+    let update_node = utils::update_records_node_placeholder_with_args(graph, filter, model_to_update, write_args);
 
     // Edge to inject the correct data into the update (either from the parent or child).
     graph.create_edge(
         node_to_attach,
         &update_node,
-        QueryGraphDependency::ProjectedDataDependency(
+        QueryGraphDependency::ProjectedDataSinkDependency(
             extractor_model_id,
-            Box::new(move |mut update_node, links| {
-                if links.is_empty() {
-                    return Ok(update_node);
-                }
-
-                // Handle filter & arg injection
-                if let Node::Query(Query::Write(ref mut wq @ WriteQuery::UpdateManyRecords(_))) = update_node {
-                    wq.set_selectors(links);
-                    wq.inject_result_into_args(null_record_id);
-                };
-
-                Ok(update_node)
-            }),
+            RowSink::All(&UpdateManyRecordsSelectorsInput),
             None,
         ),
     )?;

query-engine/core/src/query_graph_builder/write/nested/set_nested.rs

@@ -1,12 +1,14 @@
 use super::*;
 use crate::{
-    inputs::{IfInput, LeftSideDiffInput, RightSideDiffInput, UpdateOrCreateArgsInput},
+    inputs::{
+        IfInput, LeftSideDiffInput, RightSideDiffInput, UpdateManyRecordsSelectorsInput, UpdateOrCreateArgsInput,
+    },
     query_ast::*,
     query_graph::*,
     ParsedInputValue,
 };
 use itertools::Itertools;
-use query_structure::{Filter, Model, RelationFieldRef, SelectionResult};
+use query_structure::{Filter, Model, RelationFieldRef, SelectionResult, WriteArgs};
 use std::convert::TryInto;
 
 /// Only for x-to-many relations.
@@ -321,7 +323,9 @@ fn handle_one_to_many(
 
     // Update (disconnect) case: Check right diff IDs.
     let disconnect_if_node = graph.create_node(Node::Flow(Flow::if_non_empty()));
-    let update_disconnect_node = utils::update_records_node_placeholder(graph, Filter::empty(), child_model);
+    let write_args = WriteArgs::from_result(empty_child_link, crate::executor::get_request_now());
+    let update_disconnect_node =
+        utils::update_records_node_placeholder_with_args(graph, Filter::empty(), child_model, write_args);
 
     let child_side_required = parent_relation_field.related_field().is_required();
     let rf = parent_relation_field.clone();
@@ -341,19 +345,9 @@ fn handle_one_to_many(
     graph.create_edge(
         &diff_right_to_left_node,
         &update_disconnect_node,
-        QueryGraphDependency::ProjectedDataDependency(
+        QueryGraphDependency::ProjectedDataSinkDependency(
             child_model_identifier,
-            Box::new(move |mut node, diff_right_result| {
-                if let Node::Query(Query::Write(WriteQuery::UpdateManyRecords(ref mut ur))) = node {
-                    ur.record_filter = diff_right_result.to_vec().into();
-                }
-
-                if let Node::Query(Query::Write(ref mut wq)) = node {
-                    wq.inject_result_into_args(empty_child_link);
-                }
-
-                Ok(node)
-            }),
+            RowSink::All(&UpdateManyRecordsSelectorsInput),
             None,
         ),
     )?;