fix: do not wrap array parameters in arrays in push

Author: jacek-prisma

query-compiler/query-builders/sql-query-builder/src/write.rs

@@ -163,13 +163,16 @@ pub fn build_update_and_set_query(
                 ScalarWriteOperation::Set(rhs) => field.value(rhs, ctx).into(),
                 ScalarWriteOperation::Add(rhs) if field.is_list() => {
                     let e: Expression = Column::from((table.clone(), name.clone())).into();
-                    let vals: Vec<_> = match rhs {
-                        PrismaValue::List(vals) => vals.into_iter().map(|val| field.value(val, ctx)).collect(),
-                        _ => vec![field.value(rhs, ctx)],
+                    let arr = match rhs {
+                        PrismaValue::List(vals) => Value::array(vals.into_iter().map(|val| field.value(val, ctx))),
+                        PrismaValue::Placeholder(ref ph) if matches!(ph.r#type, PrismaValueType::List(_)) => {
+                            field.value(rhs, ctx)
+                        }
+                        _ => Value::array(vec![field.value(rhs, ctx)]),
                     };
 
                     // Postgres only
-                    e.compare_raw("||", Value::array(vals)).into()
+                    e.compare_raw("||", arr).into()
                 }
                 ScalarWriteOperation::Add(rhs) => {
                     let e: Expression<'_> = Column::from((table.clone(), name.clone())).into();

query-compiler/query-compiler/tests/data/update-push.json

@@ -0,0 +1,28 @@
+{
+  "modelName": "DataTypes",
+  "action": "updateOne",
+  "query": {
+    "arguments": {
+      "where": {
+        "id": ""
+      },
+      "data": {
+        "intArray": {
+          "push": {
+            "$type": "Param",
+            "value": {
+              "name": "intArray",
+              "type": "List",
+              "inner": {
+                "type": "Int"
+              }
+            }
+          }
+        }
+      }
+    },
+    "selection": {
+      "$scalars": true
+    }
+  }
+}

query-compiler/query-compiler/tests/snapshots/queries__queries@update-push.json.snap

@@ -0,0 +1,22 @@
+---
+source: query-compiler/query-compiler/tests/queries.rs
+expression: pretty
+input_file: query-compiler/query-compiler/tests/data/update-push.json
+---
+dataMap {
+    id: Bytes (id)
+    optString: String? (optString)
+    intArray: Int[] (intArray)
+}
+let 0 = unique (query «UPDATE "public"."DataTypes" SET "intArray" =
+                       "public"."DataTypes"."intArray" || $1 WHERE
+                       ("public"."DataTypes"."id" = $2 AND 1=1) RETURNING
+                       "public"."DataTypes"."id",
+                       "public"."DataTypes"."optString",
+                       "public"."DataTypes"."intArray"»
+                params [var(intArray as Int), const(Bytes([]))])
+in let 0 = validate (get 0)
+       [ rowCountNeq 0
+       ] orRaise "MISSING_RECORD"
+   in ();
+   get 0