perf(query-compiler): skip create branch return forwarding

Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>

Author: tensordreams

query-compiler/core/src/query_graph_builder/write/nested/connect_or_create_nested.rs

@@ -414,7 +414,6 @@ fn one_to_many_inlined_parent(
     let if_node = graph.create_node(Flow::if_non_empty());
     let create_node = create::create_record_node(graph, query_schema, child_model.clone(), create_map)?;
     let return_existing = graph.create_node(Flow::Return(None));
-    let return_create = graph.create_node(Flow::Return(None));
 
     graph.create_edge(
         &read_node,
@@ -449,12 +448,6 @@ fn one_to_many_inlined_parent(
         ),
     )?;
 
-    graph.create_edge(
-        &create_node,
-        &return_create,
-        QueryGraphDependency::ProjectedDataDependency(child_link, RowSink::ProjectedPlaceholder(&ReturnInput), None),
-    )?;
-
     Ok(())
 }
 
@@ -551,7 +544,6 @@ fn one_to_one_inlined_parent(
     let if_node = graph.create_node(Flow::if_non_empty());
     let create_node = create::create_record_node(graph, query_schema, child_model.clone(), create_data)?;
     let return_existing = graph.create_node(Flow::Return(None));
-    let return_create = graph.create_node(Flow::Return(None));
 
     graph.create_edge(
         &read_node,
@@ -586,16 +578,6 @@ fn one_to_one_inlined_parent(
 
     // Else branch handling
     graph.create_edge(&if_node, &create_node, QueryGraphDependency::Else)?;
-    graph.create_edge(
-        &create_node,
-        &return_create,
-        QueryGraphDependency::ProjectedDataDependency(
-            child_link.clone(),
-            RowSink::ProjectedPlaceholder(&ReturnInput),
-            None,
-        ),
-    )?;
-
     if utils::node_is_create(graph, &parent_node) {
         // No need to perform checks, a child can't exist if the parent is just getting created. Simply inject.
         graph.create_edge(

query-compiler/query-compiler/tests/snapshots/queries__queries@create-nested-connectOrCreate-mixed.json.snap

@@ -43,14 +43,14 @@ transaction
                                    "public"."Post"."id"»
                             params [const(String("Quantum Topological Embeddings of Mycorrhizal Networks: A Fractal Analysis of Phyllotaxic Algorithms in Non-Euclidean Plant Informatic")),
                                     var(2$id as Int)])
-            in let 6 = unique (query «SELECT "public"."Category"."id" FROM
+            in let 5 = unique (query «SELECT "public"."Category"."id" FROM
                                       "public"."Category" WHERE
                                       ("public"."Category"."id" = $1 AND 1=1)
                                       LIMIT $2 OFFSET $3»
                                params [const(BigInt(10)), const(BigInt(1)),
                                        const(BigInt(0))])
-               in let 8 = if (rowCountNeq 0 (get 6))
-                      then get 6
+               in let 7 = if (rowCountNeq 0 (get 5))
+                      then get 5
                       else unique (query «INSERT INTO "public"."Category"
                                           ("id","name") VALUES ($1,$2) RETURNING
                                           "public"."Category"."id"»
@@ -60,15 +60,15 @@ transaction
                          [ rowCountNeq 0
                          ] orRaise "MISSING_RELATED_RECORD");
                          0$id = mapField id (get 0);
-                         8 = validate (get 8)
+                         7 = validate (get 7)
                          [ rowCountEq 1
                          ] orRaise "INCOMPLETE_CONNECT_INPUT";
-                         8$id = mapField id (get 8)
+                         7$id = mapField id (get 7)
                      in execute «INSERT INTO "public"."_CategoryToPost"
                                  ("B","A") VALUES [($1),*],* ON CONFLICT DO
                                  NOTHING»
                         params [product(var(0$id as Int[]),
-                                        var(8$id as Int[]))];
+                                        var(7$id as Int[]))];
                let 0 = unique (validate (get 0)
                    [ rowCountNeq 0
                    ] orRaise "MISSING_RECORD");