Skip to content

chore: remove query engine - #5685

Merged
aqrln merged 6 commits into
nextfrom
push-uusrpqlxoltx
Nov 7, 2025
Merged

chore: remove query engine#5685
aqrln merged 6 commits into
nextfrom
push-uusrpqlxoltx

Conversation

@aqrln

@aqrln aqrln commented Nov 4, 2025

Copy link
Copy Markdown
Member

Remove the top level QE crates, SQL query connector and QE-specific code from query-core, and move the crates used by QC to the query-compiler directory.

Also removes the Node-API specific code from driver-adapters and leaves only the Wasm implementation to be used by schema-engine-wasm.

Unused MongoDB query connector is left for future reference as we are going to be porting that logic to QC.

Required for #5683.

Closes: https://linear.app/prisma-company/issue/TML-1554/remove-query-engine-from-prisma-engines
Ref: prisma/prisma#28375

/prisma-branch next

@aqrln
aqrln force-pushed the push-uusrpqlxoltx branch 8 times, most recently from c870072 to 5647c16 Compare November 5, 2025 14:03
@aqrln aqrln added this to the 7.0.0 milestone Nov 5, 2025
@aqrln
aqrln force-pushed the push-uusrpqlxoltx branch 5 times, most recently from bb799fe to 54cf99c Compare November 5, 2025 21:07
@codspeed-hq

codspeed-hq Bot commented Nov 5, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #5685 will create unknown performance changes

Comparing push-uusrpqlxoltx (46b3003) with next (fca7ed8)

Summary

🆕 11 new
⏩ 11 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 deep_read_query N/A 1.9 ms N/A
🆕 large_read N/A 1.6 ms N/A
🆕 medium_read N/A 318.5 µs N/A
🆕 mutation N/A 6.4 ms N/A
🆕 small_read N/A 106.3 µs N/A
🆕 validate (large) N/A 71.1 ms N/A
🆕 validate (medium) N/A 15.4 ms N/A
🆕 validate (small) N/A 2.3 ms N/A
🆕 build (large) N/A 5.3 ms N/A
🆕 build (medium) N/A 2.6 ms N/A
🆕 build (small) N/A 307.5 µs N/A

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@aqrln
aqrln force-pushed the push-uusrpqlxoltx branch 7 times, most recently from c02847c to 30d96cf Compare November 6, 2025 09:17
@github-actions

github-actions Bot commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

WASM Query Compiler File Size

Engine This PR Base branch Diff
Postgres 1.778MiB 1.858MiB -82.389KiB
Postgres (gzip) 697.325KiB 733.499KiB -36.174KiB
Mysql 1.746MiB 1.826MiB -81.865KiB
Mysql (gzip) 685.707KiB 722.105KiB -36.399KiB
Sqlite 1.702MiB 1.783MiB -82.674KiB
Sqlite (gzip) 667.933KiB 704.628KiB -36.696KiB
SQL Server 1.775MiB 1.856MiB -83.001KiB
SQL Server (gzip) 699.217KiB 735.563KiB -36.346KiB
CockroachDB 1.801MiB 1.883MiB -83.833KiB
CockroachDB (gzip) 707.049KiB 743.805KiB -36.756KiB

@aqrln
aqrln force-pushed the push-uusrpqlxoltx branch from 30d96cf to c0f5506 Compare November 6, 2025 09:58
@aqrln
aqrln marked this pull request as ready for review November 6, 2025 10:02
Comment thread query-compiler/core/src/query_graph_builder/builder.rs Outdated

@jkomyno jkomyno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with two minor questions

@aqrln
aqrln force-pushed the push-uusrpqlxoltx branch from c0f5506 to f633b1c Compare November 6, 2025 14:52
@aqrln
aqrln force-pushed the push-uusrpqlxoltx branch from 7a01488 to 46b3003 Compare November 6, 2025 15:26
aqrln added a commit to prisma/prisma that referenced this pull request Nov 7, 2025
@aqrln
aqrln merged commit 978ba84 into next Nov 7, 2025
112 checks passed
@aqrln
aqrln deleted the push-uusrpqlxoltx branch November 7, 2025 09:32
aqrln added a commit to prisma/prisma that referenced this pull request Nov 7, 2025
aqrln added a commit that referenced this pull request Nov 17, 2025
Remove the top level QE crates, SQL query connector and QE-specific code
from `query-core`, and move the crates used by QC to the
`query-compiler` directory.

Also removes the Node-API specific code from `driver-adapters` and
leaves only the Wasm implementation to be used by `schema-engine-wasm`.

Unused MongoDB query connector is left for future reference as we are
going to be porting that logic to QC.

Required for #5683.

Closes:
https://linear.app/prisma-company/issue/TML-1554/remove-query-engine-from-prisma-engines
Ref: prisma/prisma#28375

/prisma-branch next
aqrln added a commit that referenced this pull request Nov 17, 2025
Remove the top level QE crates, SQL query connector and QE-specific code
from `query-core`, and move the crates used by QC to the
`query-compiler` directory.

Also removes the Node-API specific code from `driver-adapters` and
leaves only the Wasm implementation to be used by `schema-engine-wasm`.

Unused MongoDB query connector is left for future reference as we are
going to be porting that logic to QC.

Required for #5683.

Closes:
https://linear.app/prisma-company/issue/TML-1554/remove-query-engine-from-prisma-engines
Ref: prisma/prisma#28375

/prisma-branch next
aqrln added a commit that referenced this pull request Nov 17, 2025
Remove the top level QE crates, SQL query connector and QE-specific code
from `query-core`, and move the crates used by QC to the
`query-compiler` directory.

Also removes the Node-API specific code from `driver-adapters` and
leaves only the Wasm implementation to be used by `schema-engine-wasm`.

Unused MongoDB query connector is left for future reference as we are
going to be porting that logic to QC.

Required for #5683.

Closes:
https://linear.app/prisma-company/issue/TML-1554/remove-query-engine-from-prisma-engines
Ref: prisma/prisma#28375

/prisma-branch next
aqrln added a commit to prisma/prisma that referenced this pull request Nov 17, 2025
aqrln added a commit to prisma/prisma that referenced this pull request Nov 17, 2025
aqrln added a commit to prisma/prisma that referenced this pull request Nov 17, 2025
aqrln added a commit that referenced this pull request Nov 17, 2025
Remove the top level QE crates, SQL query connector and QE-specific code
from `query-core`, and move the crates used by QC to the
`query-compiler` directory.

Also removes the Node-API specific code from `driver-adapters` and
leaves only the Wasm implementation to be used by `schema-engine-wasm`.

Unused MongoDB query connector is left for future reference as we are
going to be porting that logic to QC.

Required for #5683.

Closes:
https://linear.app/prisma-company/issue/TML-1554/remove-query-engine-from-prisma-engines
Ref: prisma/prisma#28375

/prisma-branch next
Aijeyomah pushed a commit to Aijeyomah/prisma-engines that referenced this pull request Jan 26, 2026
Remove the top level QE crates, SQL query connector and QE-specific code
from `query-core`, and move the crates used by QC to the
`query-compiler` directory.

Also removes the Node-API specific code from `driver-adapters` and
leaves only the Wasm implementation to be used by `schema-engine-wasm`.

Unused MongoDB query connector is left for future reference as we are
going to be porting that logic to QC.

Required for prisma#5683.

Closes:
https://linear.app/prisma-company/issue/TML-1554/remove-query-engine-from-prisma-engines
Ref: prisma/prisma#28375

/prisma-branch next
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants