Skip to content

Updated prometheus crate version for akri-shared module#633

Merged
johnsonshih merged 2 commits intoproject-akri:mainfrom
ag17sep:custom-metrics-fix
Jul 18, 2023
Merged

Updated prometheus crate version for akri-shared module#633
johnsonshih merged 2 commits intoproject-akri:mainfrom
ag17sep:custom-metrics-fix

Conversation

@ag17sep
Copy link
Copy Markdown
Contributor

@ag17sep ag17sep commented Jul 18, 2023

What this PR does / why we need it:

Code changes for #632

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Signed-off-by: ag17sep <animeshgarg@microsoft.com>
Copy link
Copy Markdown

@varunpuranik varunpuranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
@johnsonshih PTAL.

@johnsonshih
Copy link
Copy Markdown
Contributor

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Jul 18, 2023
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@johnsonshih johnsonshih merged commit af878cd into project-akri:main Jul 18, 2023
@fwmarcel
Copy link
Copy Markdown
Contributor

@ag17sep I have the same error as you. Do you have any advice for me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version/patch Patch version change is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants