Skip to content

Commit 85f7944

Browse files
adityamukhoclaude
andcommitted
fix(node): use explicit cp to distribute .node binaries; tolerate already-published platform packages
- Replace 'napi artifacts' (silently skips copying) with explicit cp commands for each platform's .node file - Add '|| echo' to platform publish step so already-published packages don't abort the entire job (the bad 0.25.0 packages published without .node files need manual unpublish before this will update them) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent e241f07 commit 85f7944

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

.github/workflows/node-release.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,14 @@ jobs:
101101
path: minigraf-node
102102
merge-multiple: true
103103

104-
- name: Move artifacts into platform packages
104+
- name: Distribute .node binaries to platform packages
105105
working-directory: minigraf-node
106-
run: npx @napi-rs/cli artifacts
106+
run: |
107+
# napi artifacts does not reliably copy files; do it explicitly.
108+
cp minigraf.linux-x64-gnu.node packages/@minigraf/linux-x64-gnu/
109+
cp minigraf.linux-arm64-gnu.node packages/@minigraf/linux-arm64-gnu/
110+
cp minigraf.darwin-universal.node packages/@minigraf/darwin-universal/
111+
cp minigraf.win32-x64-msvc.node packages/@minigraf/win32-x64-msvc/
107112
108113
- name: Sync platform package versions
109114
working-directory: minigraf-node
@@ -124,7 +129,7 @@ jobs:
124129
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
125130
run: |
126131
for dir in packages/@minigraf/*/; do
127-
npm publish "$dir" --access public
132+
npm publish "$dir" --access public || echo "Skipping $dir (already published or error)"
128133
done
129134
130135
- name: Publish main minigraf package

0 commit comments

Comments
 (0)