Skip to content

Commit 9757f7c

Browse files
authored
ci: fix golangci-lint install URL (#4052)
1. Cause SBOM assets were added to the release checksum file, so you get two lines that contain the same substring, e.g. …linux-amd64.tar.gz and …linux-amd64.tar.gz.sbom.json. The old install.sh logic used something like grep "${BASENAME}", so both lines matched. That breaks want (wrong or ambiguous hash) and shows up as checksum verification errors (including the 8df… vs fd3… style mismatch you debugged). 2. The upstream fix is in golangci/golangci-lint#6539 The matcher was changed so the checksum line must end with the archive name — i.e. grep "${BASENAME}$" — so the .sbom.json line no longer matches. 3. In the same thread they say master on raw.githubusercontent.com is not the right branch anymore and recommend the canonical installer URL: https://golangci-lint.run/install.sh (see the PR description and local install / binaries.) Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
1 parent 5d323c4 commit 9757f7c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ $(GOLINTER): $(TOOLSDIR)/.golangci-lint-$(GOLINTER_VERSION)
341341
$(TOOLSDIR)/.golangci-lint-$(GOLINTER_VERSION):
342342
mkdir -p $(TOOLSDIR)/bin
343343
rm -f $(TOOLSDIR)/.golangci-lint-*
344-
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(TOOLSDIR)/bin $(GOLINTER_VERSION)
344+
curl -sSfL https://golangci-lint.run/install.sh | sh -s -- -b $(TOOLSDIR)/bin $(GOLINTER_VERSION)
345345
$(GOLINTER) version
346346
touch $@
347347

0 commit comments

Comments
 (0)