add test helper funcs

Author: bakito

internal/webhook/breaktheglass/breakrequest_webhook_test.go

@@ -54,15 +54,15 @@ var _ = Describe("BreakRequest Webhook", func() {
 			reader.EXPECT().
 				Get(gm.Any(), client.ObjectKey{Name: br.Spec.TemplateName}, gm.Any(), gm.Any()).
 				Return(errors.New("not found"))
-			response := validator.OnCreate(nil, reader, decoder, nil)(ctx, admission.Request{})
+			response := test.RunWebhook(ctx, validator.OnCreate, reader, decoder)
 			test.VerifyResponse(response, http.StatusInternalServerError, "error loading template foo: not found")
 		})
 		It("Should allow creation if the referenced template is available", func() {
 			By("simulating an invalid creation scenario")
 			br.Spec.TemplateName = "bar"
 			reader.EXPECT().
 				Get(gm.Any(), client.ObjectKey{Name: br.Spec.TemplateName}, gm.Any(), gm.Any())
-			response := validator.OnCreate(nil, reader, decoder, nil)(ctx, admission.Request{})
+			response := test.RunWebhook(ctx, validator.OnCreate, reader, decoder)
 			Expect(response).To(BeNil())
 		})
 		It("Should deny creation if duration exceeds the template max duration", func() {
@@ -73,7 +73,7 @@ var _ = Describe("BreakRequest Webhook", func() {
 					brt.Spec.MaxDuration.Duration = time.Minute
 				})
 
-			response := validator.OnCreate(nil, reader, decoder, nil)(ctx, admission.Request{})
+			response := test.RunWebhook(ctx, validator.OnCreate, reader, decoder)
 			test.VerifyResponse(response, http.StatusForbidden, "requested duration 1h0m0s exceeds template maxDuration 1m0s")
 		})
 	})
@@ -91,14 +91,14 @@ var _ = Describe("BreakRequest Webhook", func() {
 		It("Should be valid if the template name is not changed", func() {
 			oldBr.Spec.TemplateName = defaultTemplateName
 			br.Spec.TemplateName = defaultTemplateName
-			response := validator.OnUpdate(nil, reader, decoder, nil)(ctx, admission.Request{})
+			response := test.RunWebhook(ctx, validator.OnUpdate, reader, decoder)
 			Expect(response).To(BeNil())
 		})
 		It("Should not be allowed to change the templateName", func() {
 			oldBr.Spec.TemplateName = defaultTemplateName
 			br.Spec.TemplateName = alternateTemplateName
 
-			response := validator.OnUpdate(nil, reader, decoder, nil)(ctx, admission.Request{})
+			response := test.RunWebhook(ctx, validator.OnUpdate, reader, decoder)
 			test.VerifyResponse(response, http.StatusForbidden, "templateName cannot be changed. old: foo, new: bar")
 		})
 	})

internal/webhook/breaktheglass/breakrequesttemplate_webhook_test.go

@@ -56,13 +56,13 @@ var _ = Describe("BreakRequestTemplate Webhook", func() {
 			It("Should deny creation", func() {
 				By("simulating an invalid creation scenario")
 
-				response := validator.OnCreate(nil, reader, decoder, nil)(ctx, admission.Request{})
+				response := test.RunWebhook(ctx, validator.OnCreate, reader, decoder)
 				test.VerifyResponse(response, http.StatusForbidden, "approvalCondition should not be set when autoApprove is false")
 			})
 			It("Should deny update", func() {
 				By("simulating an invalid update scenario")
 
-				response := validator.OnUpdate(nil, reader, decoder, nil)(ctx, admission.Request{})
+				response := test.RunWebhook(ctx, validator.OnUpdate, reader, decoder)
 				test.VerifyResponse(response, http.StatusForbidden, "approvalCondition should not be set when autoApprove is false")
 			})
 		})
@@ -73,12 +73,12 @@ var _ = Describe("BreakRequestTemplate Webhook", func() {
 			})
 			It("Should allow creation", func() {
 				By("simulating an valid creation scenario")
-				response := validator.OnCreate(nil, reader, decoder, nil)(ctx, admission.Request{})
+				response := test.RunWebhook(ctx, validator.OnCreate, reader, decoder)
 				Expect(response).To(BeNil())
 			})
 			It("Should allow update", func() {
 				By("simulating an valid update scenario")
-				response := validator.OnUpdate(nil, reader, decoder, nil)(ctx, admission.Request{})
+				response := test.RunWebhook(ctx, validator.OnUpdate, reader, decoder)
 				Expect(response).To(BeNil())
 			})
 		})
@@ -90,12 +90,12 @@ var _ = Describe("BreakRequestTemplate Webhook", func() {
 			})
 			It("Should deny creation", func() {
 				By("simulating an invalid creation scenario")
-				response := validator.OnCreate(nil, reader, decoder, nil)(ctx, admission.Request{})
+				response := test.RunWebhook(ctx, validator.OnCreate, reader, decoder)
 				test.VerifyResponse(response, http.StatusForbidden, "approvalCondition is invalid: ERROR: <input>:1:1: undeclared reference to 'foo' (in container '')\n | foo.spec.reason == 'test'\n | ^")
 			})
 			It("Should deny update", func() {
 				By("simulating an invalid update scenario")
-				response := validator.OnUpdate(nil, reader, decoder, nil)(ctx, admission.Request{})
+				response := test.RunWebhook(ctx, validator.OnUpdate, reader, decoder)
 				test.VerifyResponse(response, http.StatusForbidden, "approvalCondition is invalid: ERROR: <input>:1:1: undeclared reference to 'foo' (in container '')\n | foo.spec.reason == 'test'\n | ^")
 			})
 		})
@@ -107,12 +107,12 @@ var _ = Describe("BreakRequestTemplate Webhook", func() {
 			})
 			It("Should allow creation", func() {
 				By("simulating an valid creation scenario")
-				response := validator.OnCreate(nil, reader, decoder, nil)(ctx, admission.Request{})
+				response := test.RunWebhook(ctx, validator.OnCreate, reader, decoder)
 				Expect(response).To(BeNil())
 			})
 			It("Should allow update", func() {
 				By("simulating an valid update scenario")
-				response := validator.OnUpdate(nil, reader, decoder, nil)(ctx, admission.Request{})
+				response := test.RunWebhook(ctx, validator.OnUpdate, reader, decoder)
 				Expect(response).To(BeNil())
 			})
 		})

internal/webhook/test/response.go

@@ -0,0 +1,37 @@
+// Copyright 2020-2026 Project Capsule Authors
+// SPDX-License-Identifier: Apache-2.0
+
+package test
+
+import (
+	"context"
+
+	"github.com/onsi/ginkgo/v2"
+	"github.com/onsi/gomega"
+	"k8s.io/client-go/tools/events"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+	"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
+
+	"github.com/projectcapsule/capsule/pkg/runtime/handlers"
+)
+
+// RunWebhook is a helper function to run a webhook function.
+// the admission request is always empty. request objects are provided by the provided decoder.
+func RunWebhook(
+	ctx context.Context,
+	validatorFunc func(client.Client, client.Reader, admission.Decoder, events.EventRecorder) handlers.Func,
+	reader client.Reader,
+	decoder admission.Decoder,
+) *admission.Response {
+	ginkgo.GinkgoT().Helper()
+
+	return validatorFunc(nil, reader, decoder, nil)(ctx, admission.Request{})
+}
+
+// VerifyResponse is a helper function to verify the response of a webhook function.
+func VerifyResponse(response *admission.Response, status int32, message string) {
+	ginkgo.GinkgoT().Helper()
+	gomega.Expect(response.Result).NotTo(gomega.BeNil())
+	gomega.Expect(response.Result.Code).To(gomega.Equal(status))
+	gomega.Expect(response.Result.Message).To(gomega.Equal(message))
+}