Skip to content

Commit 0fd9fc1

Browse files
committed
speed up task page load
1 parent ab0416b commit 0fd9fc1

3 files changed

Lines changed: 11 additions & 3 deletions

File tree

app/views/test_executions/_execution_results.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ end %>
6060
</div>
6161
<% end %>
6262
63-
<% collected_errors = Cypress::ErrorCollector.collected_errors(execution) %>
63+
<% collected_errors = Cypress::ErrorCollector.collected_errors(execution, include_locations: false ) %>
6464
6565
<% if collected_errors[:exception] %>
6666
<h2>An internal error occurred when loading this page</h2>

app/views/test_executions/results/_error_table.html.erb

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,19 @@
1616
<% message_title = 'Error' if message_title == 'Errors'
1717
message_title = 'Warning' if message_title == 'Warnings' %>
1818
<th scope="col"><%= "#{message_title} message" %></th>
19-
<% unless export %>
19+
<% unless export || on_execution_show_page %>
2020
<th scope="col" class = 'col-sm-2'>Go To in XML</th>
2121
<% end %>
2222
</tr>
2323
</thead>
2424
<tbody>
25+
<% if on_execution_show_page %>
26+
<% errors.each do |error| %>
27+
<tr>
28+
<td><%= error.message %></td>
29+
</tr>
30+
<% end %>
31+
<% else %>
2532
<% errors.sort { |a, b| compare_error_locations_across_files(a, b) }.each do |error| %>
2633
<tr>
2734
<td><%= error.message %></td>
@@ -33,5 +40,6 @@
3340
</td>
3441
</tr>
3542
<% end %>
43+
<% end %>
3644
</tbody>
3745
</table>

app/views/test_executions/results/_execution_results_for_file.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
<% pop_errors = population_data_errors(error_hash.execution_errors - report_sup_data_errors, 'population') %>
5656
<% pop_sum_errors = population_data_errors(error_hash.execution_errors - pop_errors, 'population_sum') %>
5757
<% non_pop_errors = error_hash.execution_errors - report_sup_data_errors - pop_errors - pop_sum_errors %>
58-
<%= render partial: 'test_executions/results/error_table', locals: { errors: non_pop_errors, message_title: message_title, export: export} %>
58+
<%= render partial: 'test_executions/results/error_table', locals: { errors: non_pop_errors, message_title: message_title, export: export, on_execution_show_page: on_execution_show_page } %>
5959
<%= render partial: 'test_executions/results/supplemental_data_error_table', locals: { errors: report_sup_data_errors + pop_errors + pop_sum_errors, pop_errors_hash: population_error_hash(pop_errors + pop_sum_errors, report_sup_data_errors), task: @task } %>
6060

6161
<% unless on_execution_show_page %>

0 commit comments

Comments
 (0)