address review nits in session-tracking tests

Author: Mzack9999

pkg/server/http_server_test.go

@@ -96,7 +96,7 @@ func TestSessionTotalMetric(t *testing.T) {
 		},
 	})
 	require.NoError(t, err)
-	defer store.Close()
+	defer func() { _ = store.Close() }()
 
 	h := &HTTPServer{
 		options: &Options{
@@ -110,7 +110,7 @@ func TestSessionTotalMetric(t *testing.T) {
 	require.NoError(t, err)
 	pubBytes, err := x509.MarshalPKIXPublicKey(&priv.PublicKey)
 	require.NoError(t, err)
-	pubPem := pem.EncodeToMemory(&pem.Block{Type: "RSA PUBLIC KEY", Bytes: pubBytes})
+	pubPem := pem.EncodeToMemory(&pem.Block{Type: "PUBLIC KEY", Bytes: pubBytes})
 	pubB64 := base64.StdEncoding.EncodeToString(pubPem)
 
 	correlationID := xid.New().String()

pkg/storage/roundtrip_test.go

@@ -469,7 +469,7 @@ func TestOnRemovalSessionTracking(t *testing.T) {
 		OnRemoval:        onRemoval,
 	})
 	require.NoError(t, err)
-	defer db.Close()
+	defer func() { _ = db.Close() }()
 
 	waitRemoval := func(msg string) {
 		t.Helper()
@@ -507,6 +507,7 @@ func TestOnRemovalSessionTracking(t *testing.T) {
 
 	// Periodically access the cache to trigger lazy eviction.
 	stop := make(chan struct{})
+	defer close(stop)
 	go func() {
 		ticker := time.NewTicker(10 * time.Millisecond)
 		defer ticker.Stop()
@@ -520,5 +521,4 @@ func TestOnRemovalSessionTracking(t *testing.T) {
 		}
 	}()
 	waitRemoval("TTL eviction")
-	close(stop)
 }